From 25849313174bdcc97a4d94cb7a5cb2400689cadf Mon Sep 17 00:00:00 2001 From: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Wed, 10 Jan 2024 10:21:04 +0100 Subject: [PATCH 1/3] Update sites/svelte-5-preview/src/routes/docs/content/01-api/03-snippets.md --- .../src/routes/docs/content/01-api/03-snippets.md | 1 + 1 file changed, 1 insertion(+) diff --git a/sites/svelte-5-preview/src/routes/docs/content/01-api/03-snippets.md b/sites/svelte-5-preview/src/routes/docs/content/01-api/03-snippets.md index c9291f6273..92c5282336 100644 --- a/sites/svelte-5-preview/src/routes/docs/content/01-api/03-snippets.md +++ b/sites/svelte-5-preview/src/routes/docs/content/01-api/03-snippets.md @@ -237,6 +237,7 @@ You can import the `Snippet` type from `'svelte'`: The `Snippet` type is generic. Here's how you'd type various cases: ```ts +// @errors: 2305 import type { Snippet } from 'svelte'; type SnippetWithNoArgs = Snippet; From a6a7a7466c4532d73cf143437ade1e22cc6f9dd7 Mon Sep 17 00:00:00 2001 From: "S. Elliott Johnson" Date: Wed, 10 Jan 2024 22:22:24 -0700 Subject: [PATCH 2/3] Update tag.js Co-authored-by: Rich Harris --- packages/svelte/src/compiler/phases/1-parse/state/tag.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/svelte/src/compiler/phases/1-parse/state/tag.js b/packages/svelte/src/compiler/phases/1-parse/state/tag.js index e5163aad7d..f33cf5db6b 100644 --- a/packages/svelte/src/compiler/phases/1-parse/state/tag.js +++ b/packages/svelte/src/compiler/phases/1-parse/state/tag.js @@ -266,7 +266,7 @@ function open(parser) { } if (parser.match('snippet')) { - const snippet_declaraion_end = find_matching_bracket(parser.template, parser.index, '{'); + const snippet_declaration_end = find_matching_bracket(parser.template, parser.index, '{'); if (!snippet_declaraion_end) { error(start, 'TODO', 'Expected a closing curly bracket'); From 7b32431a9f999a7ce3e305aec2cf6498afe044a2 Mon Sep 17 00:00:00 2001 From: "S. Elliott Johnson" Date: Thu, 11 Jan 2024 14:39:41 -0700 Subject: [PATCH 3/3] Update .changeset/curvy-cups-cough.md Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> --- .changeset/curvy-cups-cough.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/curvy-cups-cough.md b/.changeset/curvy-cups-cough.md index 5185886b02..e16cb83777 100644 --- a/.changeset/curvy-cups-cough.md +++ b/.changeset/curvy-cups-cough.md @@ -2,4 +2,4 @@ 'svelte': patch --- -feat: snippets can now take multiple arguments +breaking: snippets can now take multiple arguments, support default parameters. Because of this, the type signature has changed