From a5afc9d55b32f90f26d0ed6661056f0b5b43095b Mon Sep 17 00:00:00 2001
From: Simon He <13917107469@163.com>
Date: Wed, 16 Nov 2022 18:40:38 +0800
Subject: [PATCH] refactor: tidy up compile/nodes

---
 src/compiler/compile/nodes/Binding.ts         |   9 +-
 src/compiler/compile/nodes/ConstTag.ts        |  26 +--
 src/compiler/compile/nodes/DebugTag.ts        |   4 +-
 src/compiler/compile/nodes/Element.ts         |  83 ++++------
 src/compiler/compile/nodes/EventHandler.ts    |   8 +-
 src/compiler/compile/nodes/Head.ts            |   2 +-
 src/compiler/compile/nodes/InlineComponent.ts |  10 +-
 src/compiler/compile/nodes/SlotTemplate.ts    |  25 +--
 src/compiler/compile/nodes/Text.ts            |   7 +-
 src/compiler/compile/nodes/Title.ts           |   2 +-
 src/compiler/compile/nodes/Window.ts          |   9 +-
 .../compile/nodes/shared/AbstractBlock.ts     |   2 +-
 src/compiler/compile/nodes/shared/Context.ts  |  13 +-
 .../compile/nodes/shared/Expression.ts        |  68 ++++----
 src/compiler/compile/nodes/shared/Node.ts     |   7 +-
 .../compile/nodes/shared/TemplateScope.ts     |   3 +-
 .../compile/nodes/shared/get_const_tags.ts    | 148 +++++++++---------
 .../compile/nodes/shared/is_contextual.ts     |   7 +-
 18 files changed, 201 insertions(+), 232 deletions(-)

diff --git a/src/compiler/compile/nodes/Binding.ts b/src/compiler/compile/nodes/Binding.ts
index f826df4828..71e51960db 100644
--- a/src/compiler/compile/nodes/Binding.ts
+++ b/src/compiler/compile/nodes/Binding.ts
@@ -101,11 +101,10 @@ export default class Binding extends Node {
 	validate_binding_rest_properties(scope: TemplateScope) {
 		this.expression.references.forEach(name => {
 			const each_block = scope.get_owner(name);
-			if (each_block && each_block.type === 'EachBlock') {
-				const rest_node = each_block.context_rest_properties.get(name);
-				if (rest_node) {
-					this.component.warn(rest_node as any, compiler_warnings.invalid_rest_eachblock_binding(name));
-				}
+			if (!each_block || each_block.type !== 'EachBlock') return;
+			const rest_node = each_block.context_rest_properties.get(name);
+			if (rest_node) {
+				this.component.warn(rest_node as any, compiler_warnings.invalid_rest_eachblock_binding(name));
 			}
 		});
 	}
diff --git a/src/compiler/compile/nodes/ConstTag.ts b/src/compiler/compile/nodes/ConstTag.ts
index 44a50aa005..4bcf3bd62f 100644
--- a/src/compiler/compile/nodes/ConstTag.ts
+++ b/src/compiler/compile/nodes/ConstTag.ts
@@ -23,7 +23,7 @@ export default class ConstTag extends Node {
 	context_rest_properties: Map<string, ESTreeNode> = new Map();
 
 	assignees: Set<string> = new Set();
-  dependencies: Set<string> = new Set();
+	dependencies: Set<string> = new Set();
 
 	constructor(component: Component, parent: INodeAllowConstTag, scope: TemplateScope, info: ConstTagType) {
 		super(component, parent, scope, info);
@@ -37,22 +37,22 @@ export default class ConstTag extends Node {
 		const { assignees, dependencies } = this;
 
 		extract_identifiers(info.expression.left).forEach(({ name }) => {
-      assignees.add(name);
+			assignees.add(name);
 			const owner = this.scope.get_owner(name);
 			if (owner === parent) {
 				component.error(info, compiler_errors.invalid_const_declaration(name));
 			}
-    });
+		});
 
-    walk(info.expression.right, {
-      enter(node, parent) {
-        if (is_reference(node as NodeWithPropertyDefinition, parent as NodeWithPropertyDefinition)) {
-          const identifier = get_object(node as any);
-          const { name } = identifier;
-          dependencies.add(name);
-        }
-      }
-    });
+		walk(info.expression.right, {
+			enter(node, parent) {
+				if (is_reference(node as NodeWithPropertyDefinition, parent as NodeWithPropertyDefinition)) {
+					const identifier = get_object(node as any);
+					const { name } = identifier;
+					dependencies.add(name);
+				}
+			}
+		});
 	}
 
 	parse_expression() {
@@ -66,7 +66,7 @@ export default class ConstTag extends Node {
 		this.expression = new Expression(this.component, this, this.scope, this.node.expression.right);
 		this.contexts.forEach(context => {
 			const owner = this.scope.get_owner(context.key.name);
-			if (owner && owner.type === 'ConstTag' && owner.parent === this.parent) {
+			if (owner?.type === 'ConstTag' && owner?.parent === this.parent) {
 				this.component.error(this.node, compiler_errors.invalid_const_declaration(context.key.name));
 			}
 			this.scope.add(context.key.name, this.expression.dependencies, this);
diff --git a/src/compiler/compile/nodes/DebugTag.ts b/src/compiler/compile/nodes/DebugTag.ts
index 88e8dd90e6..fe71a19972 100644
--- a/src/compiler/compile/nodes/DebugTag.ts
+++ b/src/compiler/compile/nodes/DebugTag.ts
@@ -13,8 +13,6 @@ export default class DebugTag extends Node {
 	constructor(component: Component, parent: INode, scope: TemplateScope, info: TemplateNode) {
 		super(component, parent, scope, info);
 
-		this.expressions = info.identifiers.map((node: EsTreeNode) => {
-			return new Expression(component, parent, scope, node);
-		});
+		this.expressions = info.identifiers.map((node: EsTreeNode) => new Expression(component, parent, scope, node));
 	}
 }
diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts
index 303b2e9122..702b6530a3 100644
--- a/src/compiler/compile/nodes/Element.ts
+++ b/src/compiler/compile/nodes/Element.ts
@@ -261,24 +261,22 @@ export default class Element extends Node {
 				}
 			}
 
-			if (this.name === 'textarea') {
-				if (info.children.length > 0) {
-					const value_attribute = info.attributes.find(node => node.name === 'value');
-					if (value_attribute) {
-						component.error(value_attribute, compiler_errors.textarea_duplicate_value);
-						return;
-					}
+			if (this.name === 'textarea' && info.children.length) {
+				const value_attribute = info.attributes.find(node => node.name === 'value');
+				if (value_attribute) {
+					component.error(value_attribute, compiler_errors.textarea_duplicate_value);
+					return;
+				}
 
-					// this is an egregious hack, but it's the easiest way to get <textarea>
-					// children treated the same way as a value attribute
-					info.attributes.push({
-						type: 'Attribute',
-						name: 'value',
-						value: info.children
-					});
+				// this is an egregious hack, but it's the easiest way to get <textarea>
+				// children treated the same way as a value attribute
+				info.attributes.push({
+					type: 'Attribute',
+					name: 'value',
+					value: info.children
+				});
 
-					info.children = [];
-				}
+				info.children = [];
 			}
 
 			if (this.name === 'option') {
@@ -348,12 +346,12 @@ export default class Element extends Node {
 				}
 
 				case 'Transition':
-				{
-					const transition = new Transition(component, this, scope, node);
-					if (node.intro) this.intro = transition;
-					if (node.outro) this.outro = transition;
-					break;
-				}
+					{
+						const transition = new Transition(component, this, scope, node);
+						if (node.intro) this.intro = transition;
+						if (node.outro) this.outro = transition;
+						break;
+					}
 
 				case 'Animation':
 					this.animation = new Animation(component, this, scope, node);
@@ -688,20 +686,10 @@ export default class Element extends Node {
 
 		if (this.name === 'label') {
 			const has_input_child = (children: INode[]) => {
-				if (children.some(child => (child instanceof Element && (a11y_labelable.has(child.name) || child.name === 'slot')))) {
-					return true;
-				}
-
-				for (const child of children) {
-					if (!('children' in child) || child.children.length === 0) {
-						continue;
-					}
-					if (has_input_child(child.children)) {
-						return true;
-					}
-				}
-
-				return false;
+				return children.some(child => (child instanceof Element && (a11y_labelable.has(child.name) || child.name === 'slot'))) ||
+					children.some(child =>
+						('children' in child) && child.children.length && has_input_child(child.children)
+					);
 			};
 
 			if (!attribute_map.has('for') && !has_input_child(this.children)) {
@@ -714,11 +702,9 @@ export default class Element extends Node {
 				return;
 			}
 
-			let has_caption;
-			const track = this.children.find((i: Element) => i.name === 'track');
-			if (track) {
-				has_caption = track.attributes.find(a => a.name === 'kind' && a.get_static_value() === 'captions');
-			}
+			const has_caption = this.children
+				.find((i: Element) => i.name === 'track')
+				?.attributes.find(a => a.name === 'kind' && a.get_static_value() === 'captions');
 
 			if (!has_caption) {
 				component.warn(this, compiler_warnings.a11y_media_has_caption);
@@ -1011,15 +997,14 @@ export default class Element extends Node {
 			const attribute = this.attributes.find(a => a.name === attribute_name);
 			if (attribute && !attribute.is_true) {
 				attribute.chunks.forEach((chunk, index) => {
-					if (chunk.type === 'Text') {
-						let data = chunk.data.replace(regex_any_repeated_whitespaces, ' ');
-						if (index === 0) {
-							data = data.trimLeft();
-						} else if (index === attribute.chunks.length - 1) {
-							data = data.trimRight();
-						}
-						chunk.data = data;
+					if (chunk.type !== 'Text') return;
+					let data = chunk.data.replace(regex_any_repeated_whitespaces, ' ');
+					if (index === 0) {
+						data = data.trimLeft();
+					} else if (index === attribute.chunks.length - 1) {
+						data = data.trimRight();
 					}
+					chunk.data = data;
 				});
 			}
 		});
diff --git a/src/compiler/compile/nodes/EventHandler.ts b/src/compiler/compile/nodes/EventHandler.ts
index 4b426580b3..cfb5e1b341 100644
--- a/src/compiler/compile/nodes/EventHandler.ts
+++ b/src/compiler/compile/nodes/EventHandler.ts
@@ -52,12 +52,8 @@ export default class EventHandler extends Node {
 	}
 
 	get reassigned(): boolean {
-		if (!this.expression) {
-			return false;
-		}
-		const node = this.expression.node;
-
-		if (regex_contains_term_function_expression.test(node.type)) {
+		if (!this.expression ||
+			regex_contains_term_function_expression.test(this.expression.node.type)) {
 			return false;
 		}
 
diff --git a/src/compiler/compile/nodes/Head.ts b/src/compiler/compile/nodes/Head.ts
index 1ebe0c053a..2ff533885b 100644
--- a/src/compiler/compile/nodes/Head.ts
+++ b/src/compiler/compile/nodes/Head.ts
@@ -24,7 +24,7 @@ export default class Head extends Node {
 			return (child.type !== 'Text' || regex_non_whitespace_character.test(child.data));
 		}));
 
-		if (this.children.length > 0) {
+		if (this.children.length) {
 			this.id = `svelte-${hash(this.component.source.slice(this.start, this.end))}`;
 		}
 	}
diff --git a/src/compiler/compile/nodes/InlineComponent.ts b/src/compiler/compile/nodes/InlineComponent.ts
index 26cfeb7ef9..860e9185d7 100644
--- a/src/compiler/compile/nodes/InlineComponent.ts
+++ b/src/compiler/compile/nodes/InlineComponent.ts
@@ -52,7 +52,7 @@ export default class InlineComponent extends Node {
 						this.css_custom_properties.push(new Attribute(component, this, scope, node));
 						break;
 					}
-					// fallthrough
+				// fallthrough
 				case 'Spread':
 					this.attributes.push(new Attribute(component, this, scope, node));
 					break;
@@ -172,9 +172,7 @@ function not_whitespace_text(node) {
 function get_namespace(parent: Node, explicit_namespace: string) {
 	const parent_element = parent.find_nearest(/^Element/);
 
-	if (!parent_element) {
-		return explicit_namespace;
-	}
-
-	return parent_element.namespace;
+	return !parent_element
+		? explicit_namespace
+		: parent_element.namespace;
 }
diff --git a/src/compiler/compile/nodes/SlotTemplate.ts b/src/compiler/compile/nodes/SlotTemplate.ts
index 90299c8e39..c3fad663a9 100644
--- a/src/compiler/compile/nodes/SlotTemplate.ts
+++ b/src/compiler/compile/nodes/SlotTemplate.ts
@@ -42,19 +42,20 @@ export default class SlotTemplate extends Node {
 					break;
 				}
 				case 'Attribute': {
-					if (node.name === 'slot') {
-						this.slot_attribute = new Attribute(component, this, scope, node);
-						if (!this.slot_attribute.is_static) {
-							return component.error(node, compiler_errors.invalid_slot_attribute);
-						}
-						const value = this.slot_attribute.get_static_value();
-						if (typeof value === 'boolean') {
-							return component.error(node, compiler_errors.invalid_slot_attribute_value_missing);
-						}
-						this.slot_template_name = value as string;
-						break;
+					if (node.name !== 'slot') {
+						throw new Error(`Invalid attribute '${node.name}' in <svelte:fragment>`);
 					}
-					throw new Error(`Invalid attribute '${node.name}' in <svelte:fragment>`);
+
+					this.slot_attribute = new Attribute(component, this, scope, node);
+					if (!this.slot_attribute.is_static) {
+						return component.error(node, compiler_errors.invalid_slot_attribute);
+					}
+					const value = this.slot_attribute.get_static_value();
+					if (typeof value === 'boolean') {
+						return component.error(node, compiler_errors.invalid_slot_attribute_value_missing);
+					}
+					this.slot_template_name = value as string;
+					break;
 				}
 				default:
 					throw new Error(`Not implemented: ${node.type}`);
diff --git a/src/compiler/compile/nodes/Text.ts b/src/compiler/compile/nodes/Text.ts
index ac6cd9b828..ecb2274912 100644
--- a/src/compiler/compile/nodes/Text.ts
+++ b/src/compiler/compile/nodes/Text.ts
@@ -40,16 +40,15 @@ export default class Text extends Node {
 		if (parent_element.type === 'InlineComponent') return parent_element.children.length === 1 && this === parent_element.children[0];
 
 		// svg namespace exclusions
-		if (regex_ends_with_svg.test(parent_element.namespace)) {
-			if (this.prev && this.prev.type === 'Element' && this.prev.name === 'tspan') return false;
+		if (regex_ends_with_svg.test(parent_element.namespace) && this.prev?.type === 'Element' && this.prev?.name === 'tspan') {
+			return false;
 		}
 
 		return parent_element.namespace || elements_without_text.has(parent_element.name);
 	}
 
 	keep_space(): boolean {
-		if (this.component.component_options.preserveWhitespace) return true;
-		return this.within_pre();
+		return this.component.component_options.preserveWhitespace || this.within_pre();
 	}
 
 	within_pre(): boolean {
diff --git a/src/compiler/compile/nodes/Title.ts b/src/compiler/compile/nodes/Title.ts
index 0abedb2afc..6d60aa2bf2 100644
--- a/src/compiler/compile/nodes/Title.ts
+++ b/src/compiler/compile/nodes/Title.ts
@@ -14,7 +14,7 @@ export default class Title extends Node {
 		super(component, parent, scope, info);
 		this.children = map_children(component, parent, scope, info.children);
 
-		if (info.attributes.length > 0) {
+		if (info.attributes.length) {
 			component.error(info.attributes[0], compiler_errors.illegal_attribute_title);
 			return;
 		}
diff --git a/src/compiler/compile/nodes/Window.ts b/src/compiler/compile/nodes/Window.ts
index c5bec0acd3..c0f8f3abe9 100644
--- a/src/compiler/compile/nodes/Window.ts
+++ b/src/compiler/compile/nodes/Window.ts
@@ -47,11 +47,10 @@ export default class Window extends Node {
 								fuzzymatch(node.name, valid_bindings)
 					);
 
-					if (match) {
-						return component.error(node, compiler_errors.invalid_binding_on(node.name, '<svelte:window>', ` (did you mean '${match}'?)`));
-					} else {
-						return component.error(node, compiler_errors.invalid_binding_on(node.name, '<svelte:window>', ` — valid bindings are ${list(valid_bindings)}`));
-					}
+					return component.error(node, compiler_errors.invalid_binding_on(node.name, '<svelte:window>',
+						match
+							? ` (did you mean '${match}'?)`
+							: ` — valid bindings are ${list(valid_bindings)}`));
 				}
 
 				this.bindings.push(new Binding(component, this, scope, node));
diff --git a/src/compiler/compile/nodes/shared/AbstractBlock.ts b/src/compiler/compile/nodes/shared/AbstractBlock.ts
index 91af3fc0f7..bbc9d281b8 100644
--- a/src/compiler/compile/nodes/shared/AbstractBlock.ts
+++ b/src/compiler/compile/nodes/shared/AbstractBlock.ts
@@ -19,7 +19,7 @@ export default class AbstractBlock extends Node {
 
 		const child = this.children[0];
 
-		if (!child || (child.type === 'Text' && !regex_non_whitespace_characters.test(child.data))) {
+		if (child?.type === 'Text' && !regex_non_whitespace_characters.test(child.data)) {
 			this.component.warn(this, compiler_warnings.empty_block);
 		}
 	}
diff --git a/src/compiler/compile/nodes/shared/Context.ts b/src/compiler/compile/nodes/shared/Context.ts
index 47180d24cd..377b32a63b 100644
--- a/src/compiler/compile/nodes/shared/Context.ts
+++ b/src/compiler/compile/nodes/shared/Context.ts
@@ -48,7 +48,7 @@ export function unpack_destructuring({
 		context_rest_properties.set((node.argument as Identifier).name, node);
 	} else if (node.type === 'ArrayPattern') {
 		node.elements.forEach((element, i) => {
-			if (element && element.type === 'RestElement') {
+			if (element?.type === 'RestElement') {
 				unpack_destructuring({
 					contexts,
 					node: element,
@@ -59,7 +59,7 @@ export function unpack_destructuring({
 					context_rest_properties
 				});
 				context_rest_properties.set((element.argument as Identifier).name, element);
-			} else if (element && element.type === 'AssignmentPattern') {
+			} else if (element?.type === 'AssignmentPattern') {
 				const n = contexts.length;
 				mark_referenced(element.right, scope, component);
 
@@ -195,11 +195,10 @@ function mark_referenced(
 ) {
 	walk(node, {
 		enter(node: any, parent: any) {
-			if (is_reference(node, parent)) {
-				const { name } = flatten_reference(node);
-				if (!scope.is_let(name) && !scope.names.has(name)) {
-					component.add_reference(node, name);
-				}
+			if (!is_reference(node, parent)) return;
+			const { name } = flatten_reference(node);
+			if (!scope.is_let(name) && !scope.names.has(name)) {
+				component.add_reference(node, name);
 			}
 		}
 	});
diff --git a/src/compiler/compile/nodes/shared/Expression.ts b/src/compiler/compile/nodes/shared/Expression.ts
index d726b811a1..a9367bdc0d 100644
--- a/src/compiler/compile/nodes/shared/Expression.ts
+++ b/src/compiler/compile/nodes/shared/Expression.ts
@@ -128,51 +128,49 @@ export default class Expression {
 						deep = node.left.type === 'MemberExpression';
 						names = extract_names(deep ? get_object(node.left) : node.left);
 					} else if (node.type === 'UpdateExpression') {
-                        deep = node.argument.type === 'MemberExpression';
+						deep = node.argument.type === 'MemberExpression';
 						names = extract_names(get_object(node.argument));
 					}
 				}
 
-				if (names) {
-					names.forEach(name => {
-						if (template_scope.names.has(name)) {
-							if (template_scope.is_const(name)) {
-								component.error(node, compiler_errors.invalid_const_update(name));
-							}
-
-							template_scope.dependencies_for_name.get(name).forEach(name => {
-								const variable = component.var_lookup.get(name);
-								if (variable) variable[deep ? 'mutated' : 'reassigned'] = true;
-							});
-							const each_block = template_scope.get_owner(name);
-							(each_block as EachBlock).has_binding = true;
-						} else {
-							component.add_reference(node, name);
+				names?.forEach(name => {
+					if (template_scope.names.has(name)) {
+						if (template_scope.is_const(name)) {
+							component.error(node, compiler_errors.invalid_const_update(name));
+						}
 
+						template_scope.dependencies_for_name.get(name).forEach(name => {
 							const variable = component.var_lookup.get(name);
+							if (variable) variable[deep ? 'mutated' : 'reassigned'] = true;
+						});
+						const each_block = template_scope.get_owner(name);
+						(each_block as EachBlock).has_binding = true;
+					} else {
+						component.add_reference(node, name);
 
-							if (variable) {
-								variable[deep ? 'mutated' : 'reassigned'] = true;
-							}
+						const variable = component.var_lookup.get(name);
 
-							const declaration: any = scope.find_owner(name)?.declarations.get(name);
+						if (variable) {
+							variable[deep ? 'mutated' : 'reassigned'] = true;
+						}
 
-							if (declaration) {
-								if (declaration.kind === 'const' && !deep) {
-									component.error(node, {
-										code: 'assignment-to-const',
-										message: 'You are assigning to a const'
-									});
-								}
-							} else if (variable && variable.writable === false && !deep) {
+						const declaration: any = scope.find_owner(name)?.declarations.get(name);
+
+						if (declaration) {
+							if (declaration.kind === 'const' && !deep) {
 								component.error(node, {
 									code: 'assignment-to-const',
 									message: 'You are assigning to a const'
 								});
 							}
+						} else if (variable && variable.writable === false && !deep) {
+							component.error(node, {
+								code: 'assignment-to-const',
+								message: 'You are assigning to a const'
+							});
 						}
-					});
-				}
+					}
+				});
 			},
 
 			leave(node: Node) {
@@ -189,8 +187,8 @@ export default class Expression {
 
 	dynamic_dependencies() {
 		return Array.from(this.dependencies).filter(name => {
-			if (this.template_scope.is_let(name)) return true;
-			if (is_reserved_keyword(name)) return true;
+			if (this.template_scope.is_let(name) ||
+				is_reserved_keyword(name)) return true;
 
 			const variable = this.component.var_lookup.get(name);
 			return is_dynamic(variable);
@@ -428,11 +426,9 @@ export default class Expression {
 			}
 		});
 
-		if (declarations.length > 0) {
+		if (declarations.length) {
 			block.maintain_context = true;
-			declarations.forEach(declaration => {
-				block.chunks.init.push(declaration);
-			});
+			block.chunks.init.push(...declarations);
 		}
 
 		return (this.manipulated = node as Node);
diff --git a/src/compiler/compile/nodes/shared/Node.ts b/src/compiler/compile/nodes/shared/Node.ts
index 3c39f6d9d3..11ed0943f3 100644
--- a/src/compiler/compile/nodes/shared/Node.ts
+++ b/src/compiler/compile/nodes/shared/Node.ts
@@ -36,10 +36,9 @@ export default class Node {
 	}
 
 	cannot_use_innerhtml() {
-		if (this.can_use_innerhtml !== false) {
-			this.can_use_innerhtml = false;
-			if (this.parent) this.parent.cannot_use_innerhtml();
-		}
+		if (this.can_use_innerhtml === false) return;
+		this.can_use_innerhtml = false;
+		if (this.parent) this.parent.cannot_use_innerhtml();
 	}
 
 	find_nearest(selector: RegExp) {
diff --git a/src/compiler/compile/nodes/shared/TemplateScope.ts b/src/compiler/compile/nodes/shared/TemplateScope.ts
index eae8640ca0..617f50fc94 100644
--- a/src/compiler/compile/nodes/shared/TemplateScope.ts
+++ b/src/compiler/compile/nodes/shared/TemplateScope.ts
@@ -28,8 +28,7 @@ export default class TemplateScope {
 	}
 
 	child() {
-		const child = new TemplateScope(this);
-		return child;
+		return new TemplateScope(this);
 	}
 
 	is_top_level(name: string) {
diff --git a/src/compiler/compile/nodes/shared/get_const_tags.ts b/src/compiler/compile/nodes/shared/get_const_tags.ts
index 77bc26fe9c..fa817f5800 100644
--- a/src/compiler/compile/nodes/shared/get_const_tags.ts
+++ b/src/compiler/compile/nodes/shared/get_const_tags.ts
@@ -7,85 +7,85 @@ import check_graph_for_cycles from '../../utils/check_graph_for_cycles';
 import compiler_errors from '../../compiler_errors';
 
 export default function get_const_tags(children: TemplateNode[], component: Component, node: INodeAllowConstTag, parent: INode): [ConstTag[], Array<Exclude<INode, ConstTag>>] {
-  const const_tags: ConstTagType[] = [];
-  const others: Array<Exclude<TemplateNode, ConstTagType>> = [];
+	const const_tags: ConstTagType[] = [];
+	const others: Array<Exclude<TemplateNode, ConstTagType>> = [];
 
-  for (const child of children) {
-    if (child.type === 'ConstTag') {
-      const_tags.push(child as ConstTagType);
-    } else {
-      others.push(child);
-    }
-  }
+	for (const child of children) {
+		if (child.type === 'ConstTag') {
+			const_tags.push(child as ConstTagType);
+		} else {
+			others.push(child);
+		}
+	}
 
-  const consts_nodes = const_tags.map(tag => new ConstTag(component, node, node.scope, tag));
-  const sorted_consts_nodes = sort_consts_nodes(consts_nodes, component);
-  sorted_consts_nodes.forEach(node => node.parse_expression());
+	const consts_nodes = const_tags.map(tag => new ConstTag(component, node, node.scope, tag));
+	const sorted_consts_nodes = sort_consts_nodes(consts_nodes, component);
+	sorted_consts_nodes.forEach(node => node.parse_expression());
 
-  const children_nodes = map_children(component, parent, node.scope, others);
+	const children_nodes = map_children(component, parent, node.scope, others);
 
-  return [sorted_consts_nodes, children_nodes as Array<Exclude<INode, ConstTag>>];
+	return [sorted_consts_nodes, children_nodes as Array<Exclude<INode, ConstTag>>];
 }
 
 function sort_consts_nodes(consts_nodes: ConstTag[], component: Component) {
-  type ConstNode = {
-    assignees: Set<string>;
-    dependencies: Set<string>;
-    node: ConstTag;
-  };
-  const sorted_consts_nodes: ConstNode[] = [];
-
-  const unsorted_consts_nodes: ConstNode[] = consts_nodes.map(node => {
-    return {
-      assignees: node.assignees,
-      dependencies: node.dependencies,
-      node
-    };
-  });
-
-  const lookup = new Map();
-
-  unsorted_consts_nodes.forEach(node => {
-    node.assignees.forEach(name => {
-      if (!lookup.has(name)) {
-        lookup.set(name, []);
-      }
-      lookup.get(name).push(node);
-    });
-  });
-
-  const cycle = check_graph_for_cycles(unsorted_consts_nodes.reduce((acc, node) => {
-    node.assignees.forEach(v => {
-      node.dependencies.forEach(w => {
-        if (!node.assignees.has(w)) {
-          acc.push([v, w]);
-        }
-      });
-    });
-    return acc;
-  }, []));
-
-  if (cycle && cycle.length) {
-    const nodeList = lookup.get(cycle[0]);
-    const node = nodeList[0];
-    component.error(node.node, compiler_errors.cyclical_const_tags(cycle));
-  }
-
-  const add_node = (node: ConstNode) => {
-    if (sorted_consts_nodes.includes(node)) return;
-
-    node.dependencies.forEach(name => {
-      if (node.assignees.has(name)) return;
-      const earlier_nodes = lookup.get(name);
-      if (earlier_nodes) {
-        earlier_nodes.forEach(add_node);
-      }
-    });
-
-    sorted_consts_nodes.push(node);
-  };
-
-  unsorted_consts_nodes.forEach(add_node);
-
-  return sorted_consts_nodes.map(node => node.node);
+	type ConstNode = {
+		assignees: Set<string>;
+		dependencies: Set<string>;
+		node: ConstTag;
+	};
+	const sorted_consts_nodes: ConstNode[] = [];
+
+	const unsorted_consts_nodes: ConstNode[] = consts_nodes.map(node => {
+		return {
+			assignees: node.assignees,
+			dependencies: node.dependencies,
+			node
+		};
+	});
+
+	const lookup = new Map();
+
+	unsorted_consts_nodes.forEach(node => {
+		node.assignees.forEach(name => {
+			if (!lookup.has(name)) {
+				lookup.set(name, []);
+			}
+			lookup.get(name).push(node);
+		});
+	});
+
+	const cycle = check_graph_for_cycles(unsorted_consts_nodes.reduce((acc, node) => {
+		node.assignees.forEach(v => {
+			node.dependencies.forEach(w => {
+				if (!node.assignees.has(w)) {
+					acc.push([v, w]);
+				}
+			});
+		});
+		return acc;
+	}, []));
+
+	if (cycle?.length) {
+		const nodeList = lookup.get(cycle[0]);
+		const node = nodeList[0];
+		component.error(node.node, compiler_errors.cyclical_const_tags(cycle));
+	}
+
+	const add_node = (node: ConstNode) => {
+		if (sorted_consts_nodes.includes(node)) return;
+
+		node.dependencies.forEach(name => {
+			if (node.assignees.has(name)) return;
+			const earlier_nodes = lookup.get(name);
+			if (earlier_nodes) {
+				earlier_nodes.forEach(add_node);
+			}
+		});
+
+		sorted_consts_nodes.push(node);
+	};
+
+	unsorted_consts_nodes.forEach(add_node);
+
+	return sorted_consts_nodes.map(node => node.node);
 }
diff --git a/src/compiler/compile/nodes/shared/is_contextual.ts b/src/compiler/compile/nodes/shared/is_contextual.ts
index b1ef398237..e2f093672e 100644
--- a/src/compiler/compile/nodes/shared/is_contextual.ts
+++ b/src/compiler/compile/nodes/shared/is_contextual.ts
@@ -3,10 +3,11 @@ import TemplateScope from './TemplateScope';
 import { is_reserved_keyword } from '../../utils/reserved_keywords';
 
 export default function is_contextual(component: Component, scope: TemplateScope, name: string) {
-	if (is_reserved_keyword(name)) return true;
+	if (is_reserved_keyword(name) ||
+		// if it's a name below root scope, it's contextual
+		!scope.is_top_level(name)
+	) return true;
 
-	// if it's a name below root scope, it's contextual
-	if (!scope.is_top_level(name)) return true;
 
 	const variable = component.var_lookup.get(name);