remove unnecessary TEMPLATE_EFFECT distinction

aa-coordination
Rich Harris 7 months ago
parent 5f61b08849
commit a405d477f7

@ -5,7 +5,6 @@ export const BLOCK_EFFECT = 1 << 4;
export const BRANCH_EFFECT = 1 << 5;
export const ROOT_EFFECT = 1 << 6;
export const BOUNDARY_EFFECT = 1 << 7;
export const TEMPLATE_EFFECT = 1 << 8;
export const UNOWNED = 1 << 9;
export const DISCONNECTED = 1 << 10;
export const CLEAN = 1 << 11;

@ -9,8 +9,7 @@ import {
EFFECT,
MAYBE_DIRTY,
RENDER_EFFECT,
ROOT_EFFECT,
TEMPLATE_EFFECT
ROOT_EFFECT
} from '../constants.js';
/**
@ -38,8 +37,6 @@ export function log_effect_tree(effect) {
label = 'root';
} else if ((flags & BOUNDARY_EFFECT) !== 0) {
label = 'boundary';
} else if ((flags & TEMPLATE_EFFECT) !== 0) {
label = 'template';
} else if ((flags & BLOCK_EFFECT) !== 0) {
label = 'block';
} else if ((flags & BRANCH_EFFECT) !== 0) {

@ -35,8 +35,7 @@ import {
HEAD_EFFECT,
MAYBE_DIRTY,
EFFECT_HAS_DERIVED,
BOUNDARY_EFFECT,
TEMPLATE_EFFECT
BOUNDARY_EFFECT
} from '../constants.js';
import { set } from './sources.js';
import * as e from '../errors.js';
@ -388,7 +387,7 @@ function create_template_effect(fn, deriveds) {
});
}
create_effect(RENDER_EFFECT | TEMPLATE_EFFECT, effect, true);
create_effect(RENDER_EFFECT, effect, true);
}
/**

@ -25,7 +25,6 @@ import {
DISCONNECTED,
BOUNDARY_EFFECT,
REACTION_IS_UPDATING,
TEMPLATE_EFFECT,
BOUNDARY_SUSPENDED
} from './constants.js';
import {
@ -823,10 +822,7 @@ function process_effects(effect, collected_effects, boundary) {
if (!is_skippable_branch && (flags & INERT) === 0) {
// Inside a boundary, defer everything except block/branch effects
var defer =
boundary !== undefined &&
!is_branch &&
((flags & BLOCK_EFFECT) === 0 || (flags & TEMPLATE_EFFECT) !== 0);
var defer = boundary !== undefined && !is_branch && (flags & BLOCK_EFFECT) === 0;
if (defer) {
add_boundary_effect(/** @type {Effect} */ (boundary), current_effect);

Loading…
Cancel
Save