Merge pull request #1160 from sveltejs/gh-1108

remove <noscript> elements in DOM mode (#1108)
8 years ago · a33dfe5bf3
parent 90f6f660e7 50d95e1642
commit a33dfe5bf3
3 changed files with 18 additions and 0 deletions
--- a/src/generators/nodes/Element.ts
+++ b/src/generators/nodes/Element.ts
@ -162,6 +162,8 @@ export default class Element extends Node {
 			this.generator.slots.add(slotName);
 		}

+		if (this.name === 'noscript') return;
+
 		const childState = {
 			parentNode: this.var,
 			parentNodes: parentNodes && block.getUniqueName(`${this.var}_nodes`) // if we're in unclaimable territory, i.e. <head>, parentNodes is null
@ -423,6 +425,8 @@ export default class Element extends Node {
 					: escapeHTML(node.data);
 			}

+			if (node.name === 'noscript') return '';
+
 			let open = `<${node.name}`;

 			if (node._needsCssAttribute) {
--- a/test/runtime/samples/noscript-removal/_config.js
+++ b/test/runtime/samples/noscript-removal/_config.js
@ -0,0 +1,9 @@
+export default {
+	'skip-ssr': true,
+
+	html: `
+	<div>foo</div>
+
+	<div>foo<div>foo</div></div>
+`,
+};
--- a/test/runtime/samples/noscript-removal/main.html
+++ b/test/runtime/samples/noscript-removal/main.html
@ -0,0 +1,5 @@
+<noscript>foo</noscript>
+
+<div>foo<noscript>foo</noscript></div>
+
+<div>foo<div>foo<noscript>foo</noscript></div></div>