From 99a3cc93b66bf2c6be551e23101bfdbdb2c6bf72 Mon Sep 17 00:00:00 2001
From: hackape <muse.vincent@gmail.com>
Date: Fri, 28 Jul 2023 18:14:34 +0800
Subject: [PATCH] fix: allow child element with slot attribute within
 svelte:element (#9038)

fix #9018
---
 .changeset/nine-houses-flow.md                             | 5 +++++
 packages/svelte/src/compiler/compile/nodes/Element.js      | 4 +++-
 .../runtime/samples/slot-in-dynamic-element/_config.js     | 7 +++++++
 .../runtime/samples/slot-in-dynamic-element/main.svelte    | 7 +++++++
 4 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/nine-houses-flow.md
 create mode 100644 packages/svelte/test/runtime/samples/slot-in-dynamic-element/_config.js
 create mode 100644 packages/svelte/test/runtime/samples/slot-in-dynamic-element/main.svelte

diff --git a/.changeset/nine-houses-flow.md b/.changeset/nine-houses-flow.md
new file mode 100644
index 0000000000..d3783c6c1c
--- /dev/null
+++ b/.changeset/nine-houses-flow.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: allow child element with slot attribute within svelte:element
diff --git a/packages/svelte/src/compiler/compile/nodes/Element.js b/packages/svelte/src/compiler/compile/nodes/Element.js
index f770cb190d..654c2c48f0 100644
--- a/packages/svelte/src/compiler/compile/nodes/Element.js
+++ b/packages/svelte/src/compiler/compile/nodes/Element.js
@@ -1413,7 +1413,9 @@ const regex_minus_sign = /-/;
 function within_custom_element(parent) {
 	while (parent) {
 		if (parent.type === 'InlineComponent') return false;
-		if (parent.type === 'Element' && regex_minus_sign.test(parent.name)) return true;
+		if (parent.type === 'Element') {
+			if (regex_minus_sign.test(parent.name) || parent.is_dynamic_element) return true;
+		}
 		parent = parent.parent;
 	}
 	return false;
diff --git a/packages/svelte/test/runtime/samples/slot-in-dynamic-element/_config.js b/packages/svelte/test/runtime/samples/slot-in-dynamic-element/_config.js
new file mode 100644
index 0000000000..589e57d78e
--- /dev/null
+++ b/packages/svelte/test/runtime/samples/slot-in-dynamic-element/_config.js
@@ -0,0 +1,7 @@
+export default {
+	html: `
+		<dynamic-element>
+			<header slot='header'>header header header</header>
+		</dynamic-element>
+	`
+};
diff --git a/packages/svelte/test/runtime/samples/slot-in-dynamic-element/main.svelte b/packages/svelte/test/runtime/samples/slot-in-dynamic-element/main.svelte
new file mode 100644
index 0000000000..38d7cd233e
--- /dev/null
+++ b/packages/svelte/test/runtime/samples/slot-in-dynamic-element/main.svelte
@@ -0,0 +1,7 @@
+<script>
+	export let tagName = 'dynamic-element'
+</script>
+
+<svelte:element this={tagName}>
+	<header slot='header'>header header header</header>
+</svelte:element>
\ No newline at end of file