diff --git a/src/generators/nodes/Element.ts b/src/generators/nodes/Element.ts index 48852c27ea..c70f22b447 100644 --- a/src/generators/nodes/Element.ts +++ b/src/generators/nodes/Element.ts @@ -415,7 +415,13 @@ export default class Element extends Node { } function toHTML(node: Element | Text) { - if (node.type === 'Text') return escapeHTML(node.data); + if (node.type === 'Text') { + return node.parent && + node.parent.type === 'Element' && + (node.parent.name === 'script' || node.parent.name === 'style') + ? node.data + : escapeHTML(node.data); + } let open = `<${node.name}`; @@ -433,10 +439,6 @@ export default class Element extends Node { if (isVoidElementName(node.name)) return open + '>'; - if (node.name === 'script' || node.name === 'style') { - return `${open}>${node.data}`; - } - return `${open}>${node.children.map(toHTML).join('')}`; } } diff --git a/src/generators/server-side-rendering/visitors/Element.ts b/src/generators/server-side-rendering/visitors/Element.ts index 486f0f01a3..21ec923e3d 100644 --- a/src/generators/server-side-rendering/visitors/Element.ts +++ b/src/generators/server-side-rendering/visitors/Element.ts @@ -68,8 +68,6 @@ export default function visitElement( if (node.name === 'textarea' && textareaContents !== undefined) { generator.append(textareaContents); - } else if (node.name === 'script' || node.name === 'style') { - generator.append(escape(node.data)); } else { node.children.forEach((child: Node) => { visit(generator, block, child); diff --git a/src/generators/server-side-rendering/visitors/Text.ts b/src/generators/server-side-rendering/visitors/Text.ts index 44b1665b2b..4d305f73da 100644 --- a/src/generators/server-side-rendering/visitors/Text.ts +++ b/src/generators/server-side-rendering/visitors/Text.ts @@ -8,5 +8,14 @@ export default function visitText( block: Block, node: Node ) { - generator.append(escapeHTML(escape(node.data).replace(/(\${|`|\\)/g, '\\$1'))); + let text = escape(node.data).replace(/(\${|`|\\)/g, '\\$1'); + if ( + !node.parent || + node.parent.type !== 'Element' || + (node.parent.name !== 'script' && node.parent.name !== 'style') + ) { + // unless this Text node is inside a ', true); + element.end = parser.index; + } else if (name === 'style') { + // special case + element.children = readSequence( + parser, + () => + parser.template.slice(parser.index, parser.index + 8) === '' + ); + parser.read(/<\/style>/); element.end = parser.index; } else { parser.stack.push(element); diff --git a/test/runtime/samples/non-root-style-interpolation/_config.js b/test/runtime/samples/non-root-style-interpolation/_config.js new file mode 100644 index 0000000000..3585e61f0b --- /dev/null +++ b/test/runtime/samples/non-root-style-interpolation/_config.js @@ -0,0 +1,49 @@ +export default { + data: { + color: 'red', + }, + + html: ` +
+ + foo +
+ +
+
+ + foo +
+
+ +
+ + foo +
+ +
+
+ + foo +
+
+ `, +}; diff --git a/test/runtime/samples/non-root-style-interpolation/main.html b/test/runtime/samples/non-root-style-interpolation/main.html new file mode 100644 index 0000000000..804d2a3ef2 --- /dev/null +++ b/test/runtime/samples/non-root-style-interpolation/main.html @@ -0,0 +1,41 @@ +
+ + foo +
+ +
+
+ + foo +
+
+ +
+ + foo +
+ +
+
+ + foo +
+
diff --git a/test/runtime/samples/script-style-non-top-level/_config.js b/test/runtime/samples/script-style-non-top-level/_config.js new file mode 100644 index 0000000000..1aade72239 --- /dev/null +++ b/test/runtime/samples/script-style-non-top-level/_config.js @@ -0,0 +1,8 @@ +export default { + html: ` +
+ + +
+ ` +}; \ No newline at end of file diff --git a/test/runtime/samples/script-style-non-top-level/main.html b/test/runtime/samples/script-style-non-top-level/main.html new file mode 100644 index 0000000000..94cf72e4bd --- /dev/null +++ b/test/runtime/samples/script-style-non-top-level/main.html @@ -0,0 +1,4 @@ +
+ + +
\ No newline at end of file