From 8dd5ae5372ffde7d31c466ff27352b4c650f5688 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Thu, 8 Dec 2016 15:34:28 -0500 Subject: [PATCH] =?UTF-8?q?implement=20Comment=20in=20SSR=20compiler=20?= =?UTF-8?q?=E2=80=93=20fixes=20#165?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/server-side-rendering/compile.js | 4 ++++ test/server-side-rendering/comment/_actual.html | 3 +++ test/server-side-rendering/comment/_expected.html | 2 ++ test/server-side-rendering/comment/main.html | 3 +++ 4 files changed, 12 insertions(+) create mode 100644 test/server-side-rendering/comment/_actual.html create mode 100644 test/server-side-rendering/comment/_expected.html create mode 100644 test/server-side-rendering/comment/main.html diff --git a/src/server-side-rendering/compile.js b/src/server-side-rendering/compile.js index e2c1432ba0..2bb7b6aa0c 100644 --- a/src/server-side-rendering/compile.js +++ b/src/server-side-rendering/compile.js @@ -113,6 +113,10 @@ export default function compile ( parsed, source, { filename }) { let elementDepth = 0; const stringifiers = { + Comment () { + return ''; + }, + Component ( node ) { const props = node.attributes.map( attribute => { let value; diff --git a/test/server-side-rendering/comment/_actual.html b/test/server-side-rendering/comment/_actual.html new file mode 100644 index 0000000000..bc1da94084 --- /dev/null +++ b/test/server-side-rendering/comment/_actual.html @@ -0,0 +1,3 @@ +

before

+ +

after

\ No newline at end of file diff --git a/test/server-side-rendering/comment/_expected.html b/test/server-side-rendering/comment/_expected.html new file mode 100644 index 0000000000..ba0d202ece --- /dev/null +++ b/test/server-side-rendering/comment/_expected.html @@ -0,0 +1,2 @@ +

before

+

after

diff --git a/test/server-side-rendering/comment/main.html b/test/server-side-rendering/comment/main.html new file mode 100644 index 0000000000..8ecd344816 --- /dev/null +++ b/test/server-side-rendering/comment/main.html @@ -0,0 +1,3 @@ +

before

+ +

after