From 8c50a443b061d37d3a7cb79fe1a6fda44020b417 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Fri, 22 Nov 2019 16:15:38 -0500 Subject: [PATCH] use bitwise comparison --- src/compiler/compile/render_dom/Renderer.ts | 2 +- test/runtime/samples/bitmask-overflow/_config.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/compile/render_dom/Renderer.ts b/src/compiler/compile/render_dom/Renderer.ts index 90c4aec234..058746d4e9 100644 --- a/src/compiler/compile/render_dom/Renderer.ts +++ b/src/compiler/compile/render_dom/Renderer.ts @@ -236,7 +236,7 @@ export default class Renderer { .map((bits, i) => ({ bits, i })) .filter(({ bits }) => bits) .map(({ bits, i }) => x`${dirty}[${i}] & ${bits}`) - .reduce((lhs, rhs) => x`${lhs} || ${rhs}`); + .reduce((lhs, rhs) => x`${lhs} | ${rhs}`); ({ operator, left, right } = expression); } else { diff --git a/test/runtime/samples/bitmask-overflow/_config.js b/test/runtime/samples/bitmask-overflow/_config.js index fdd7bff813..ada3195c81 100644 --- a/test/runtime/samples/bitmask-overflow/_config.js +++ b/test/runtime/samples/bitmask-overflow/_config.js @@ -109,12 +109,12 @@ export default { assert.deepEqual(component.reads, { _0: 1, - _5: 2, + _5: 3, _6: 3, _30: 1, _31: 1, _32: 1, - _36: 2, + _36: 3, _37: 3, _40: 1 });