From 8ba1b9ddd0bc65b9a790030aa8b7c73ae2990543 Mon Sep 17 00:00:00 2001
From: Dominic Gannaway <trueadm@users.noreply.github.com>
Date: Thu, 12 Dec 2024 10:42:10 +0000
Subject: [PATCH] fix: avoid mutation validation for invalidate_inner_signals
 (#14688)

* fix: avoid mutation validation for invalidate_inner_signals

* add test

* Update packages/svelte/src/internal/client/runtime.js

---------

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
---
 .changeset/strong-pandas-provide.md           |  5 +++++
 .../svelte/src/internal/client/runtime.js     |  7 ++++---
 .../binding-interop-derived/Comp.svelte       | 12 ++++++++++++
 .../binding-interop-derived/_config.js        |  5 +++++
 .../binding-interop-derived/main.svelte       | 19 +++++++++++++++++++
 5 files changed, 45 insertions(+), 3 deletions(-)
 create mode 100644 .changeset/strong-pandas-provide.md
 create mode 100644 packages/svelte/tests/runtime-runes/samples/binding-interop-derived/Comp.svelte
 create mode 100644 packages/svelte/tests/runtime-runes/samples/binding-interop-derived/_config.js
 create mode 100644 packages/svelte/tests/runtime-runes/samples/binding-interop-derived/main.svelte

diff --git a/.changeset/strong-pandas-provide.md b/.changeset/strong-pandas-provide.md
new file mode 100644
index 0000000000..0fe7e70c6d
--- /dev/null
+++ b/.changeset/strong-pandas-provide.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: avoid mutation validation for invalidate_inner_signals
diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js
index 4928419d16..5d53ca3360 100644
--- a/packages/svelte/src/internal/client/runtime.js
+++ b/packages/svelte/src/internal/client/runtime.js
@@ -29,7 +29,7 @@ import {
 } from './constants.js';
 import { flush_tasks } from './dom/task.js';
 import { add_owner } from './dev/ownership.js';
-import { mutate, set, source } from './reactivity/sources.js';
+import { internal_set, set, source } from './reactivity/sources.js';
 import { destroy_derived, execute_derived, update_derived } from './reactivity/deriveds.js';
 import * as e from './errors.js';
 import { lifecycle_outside_component } from '../shared/errors.js';
@@ -960,11 +960,12 @@ export function invalidate_inner_signals(fn) {
 		if ((signal.f & LEGACY_DERIVED_PROP) !== 0) {
 			for (const dep of /** @type {Derived} */ (signal).deps || []) {
 				if ((dep.f & DERIVED) === 0) {
-					mutate(dep, null /* doesnt matter */);
+					// Use internal_set instead of set here and below to avoid mutation validation
+					internal_set(dep, dep.v);
 				}
 			}
 		} else {
-			mutate(signal, null /* doesnt matter */);
+			internal_set(signal, signal.v);
 		}
 	}
 }
diff --git a/packages/svelte/tests/runtime-runes/samples/binding-interop-derived/Comp.svelte b/packages/svelte/tests/runtime-runes/samples/binding-interop-derived/Comp.svelte
new file mode 100644
index 0000000000..c309299748
--- /dev/null
+++ b/packages/svelte/tests/runtime-runes/samples/binding-interop-derived/Comp.svelte
@@ -0,0 +1,12 @@
+<script>
+
+	let { children } = $props()
+
+	const snippetProps = $derived.by(() => ({
+		id: '123',
+		name: 'my-select'
+	}))
+
+</script>
+
+{@render children({ props: snippetProps })}
diff --git a/packages/svelte/tests/runtime-runes/samples/binding-interop-derived/_config.js b/packages/svelte/tests/runtime-runes/samples/binding-interop-derived/_config.js
new file mode 100644
index 0000000000..e52264c793
--- /dev/null
+++ b/packages/svelte/tests/runtime-runes/samples/binding-interop-derived/_config.js
@@ -0,0 +1,5 @@
+import { test } from '../../test';
+
+export default test({
+	html: '<select id="123" name="my-select"><option>A</option><option>B</option><option>C</option></select>'
+});
diff --git a/packages/svelte/tests/runtime-runes/samples/binding-interop-derived/main.svelte b/packages/svelte/tests/runtime-runes/samples/binding-interop-derived/main.svelte
new file mode 100644
index 0000000000..5900ddc846
--- /dev/null
+++ b/packages/svelte/tests/runtime-runes/samples/binding-interop-derived/main.svelte
@@ -0,0 +1,19 @@
+<svelte:options runes={false} />
+
+<script>
+	import { writable } from 'svelte/store'
+	import Comp from './Comp.svelte'
+
+	const myStore = writable('')
+
+</script>
+
+<Comp>
+	{#snippet children({ props })}
+			<select {...props} bind:value={$myStore} >
+				<option>A</option>
+				<option>B</option>
+				<option>C</option>
+			</select>
+	{/snippet}
+</Comp>