From 871147260c116fcf0b70d8cfcbe97c399c97bad9 Mon Sep 17 00:00:00 2001 From: Richard Harris Date: Sun, 17 Feb 2019 12:35:17 -0500 Subject: [PATCH] always warn on empty block - fixes #2042 --- src/compile/nodes/shared/Node.ts | 1 - test/validator/samples/empty-block-dev/_config.js | 3 --- test/validator/samples/empty-block-prod/input.svelte | 5 ----- test/validator/samples/empty-block-prod/warnings.json | 1 - .../samples/{empty-block-dev => empty-block}/input.svelte | 0 .../samples/{empty-block-dev => empty-block}/warnings.json | 0 6 files changed, 10 deletions(-) delete mode 100644 test/validator/samples/empty-block-dev/_config.js delete mode 100644 test/validator/samples/empty-block-prod/input.svelte delete mode 100644 test/validator/samples/empty-block-prod/warnings.json rename test/validator/samples/{empty-block-dev => empty-block}/input.svelte (100%) rename test/validator/samples/{empty-block-dev => empty-block}/warnings.json (100%) diff --git a/src/compile/nodes/shared/Node.ts b/src/compile/nodes/shared/Node.ts index 330dac3e35..24848a4507 100644 --- a/src/compile/nodes/shared/Node.ts +++ b/src/compile/nodes/shared/Node.ts @@ -49,7 +49,6 @@ export default class Node { } warnIfEmptyBlock() { - if (!this.component.compileOptions.dev) return; if (!/Block$/.test(this.type) || !this.children) return; if (this.children.length > 1) return; diff --git a/test/validator/samples/empty-block-dev/_config.js b/test/validator/samples/empty-block-dev/_config.js deleted file mode 100644 index e26996239d..0000000000 --- a/test/validator/samples/empty-block-dev/_config.js +++ /dev/null @@ -1,3 +0,0 @@ -export default { - dev: true -}; \ No newline at end of file diff --git a/test/validator/samples/empty-block-prod/input.svelte b/test/validator/samples/empty-block-prod/input.svelte deleted file mode 100644 index 979ff837e9..0000000000 --- a/test/validator/samples/empty-block-prod/input.svelte +++ /dev/null @@ -1,5 +0,0 @@ -{#each things as thing} - -{/each} - -{#each things as thing}{/each} \ No newline at end of file diff --git a/test/validator/samples/empty-block-prod/warnings.json b/test/validator/samples/empty-block-prod/warnings.json deleted file mode 100644 index 0637a088a0..0000000000 --- a/test/validator/samples/empty-block-prod/warnings.json +++ /dev/null @@ -1 +0,0 @@ -[] \ No newline at end of file diff --git a/test/validator/samples/empty-block-dev/input.svelte b/test/validator/samples/empty-block/input.svelte similarity index 100% rename from test/validator/samples/empty-block-dev/input.svelte rename to test/validator/samples/empty-block/input.svelte diff --git a/test/validator/samples/empty-block-dev/warnings.json b/test/validator/samples/empty-block/warnings.json similarity index 100% rename from test/validator/samples/empty-block-dev/warnings.json rename to test/validator/samples/empty-block/warnings.json