From 868e3fa56ed2a6a2d9a2c3e7e6abc793a367114e Mon Sep 17 00:00:00 2001 From: paoloricciuti Date: Fri, 14 Feb 2025 11:58:34 +0100 Subject: [PATCH] chore: fix `$props.id` tests --- .../runtime-runes/samples/props-id/_config.js | 62 +++++-------------- .../samples/props-id/main.svelte | 2 +- 2 files changed, 15 insertions(+), 49 deletions(-) diff --git a/packages/svelte/tests/runtime-runes/samples/props-id/_config.js b/packages/svelte/tests/runtime-runes/samples/props-id/_config.js index 9d91b98e0f..b40d1ce299 100644 --- a/packages/svelte/tests/runtime-runes/samples/props-id/_config.js +++ b/packages/svelte/tests/runtime-runes/samples/props-id/_config.js @@ -3,59 +3,25 @@ import { test } from '../../test'; export default test({ test({ assert, target, variant }) { - if (variant === 'dom') { - assert.htmlEqual( - target.innerHTML, - ` - -

c1

-

c2

-

c3

-

c4

- ` - ); - } else { - assert.htmlEqual( - target.innerHTML, - ` - -

s1

-

s2

-

s3

-

s4

- ` - ); + const ps = [...target.querySelectorAll('p')].map((p) => p.innerHTML); + const unique = new Set(ps); + assert.equal(ps.length, unique.size); + + if (variant === 'hydrate') { + const start = ps.map((p) => p.substring(0, 1)); + assert.deepEqual(start, ['s', 's', 's', 's']); } let button = target.querySelector('button'); flushSync(() => button?.click()); - if (variant === 'dom') { - assert.htmlEqual( - target.innerHTML, - ` - -

c1

-

c2

-

c3

-

c4

-

c5

- ` - ); - } else { - // `c6` because this runs after the `dom` tests - // (slightly brittle but good enough for now) - assert.htmlEqual( - target.innerHTML, - ` - -

s1

-

s2

-

s3

-

s4

-

c6

- ` - ); + const ps_after = [...target.querySelectorAll('p')].map((p) => p.innerHTML); + const unique_after = new Set(ps_after); + assert.equal(ps_after.length, unique_after.size); + + if (variant === 'hydrate') { + const start = ps_after.map((p) => p.substring(0, 1)); + assert.deepEqual(start, ['s', 's', 's', 's', 'c']); } } }); diff --git a/packages/svelte/tests/runtime-runes/samples/props-id/main.svelte b/packages/svelte/tests/runtime-runes/samples/props-id/main.svelte index 646bb2ebde..a736ef60fa 100644 --- a/packages/svelte/tests/runtime-runes/samples/props-id/main.svelte +++ b/packages/svelte/tests/runtime-runes/samples/props-id/main.svelte @@ -8,7 +8,7 @@ -

{id}

+

{id}