From 864bdd90fd2578760a3b716b06acc2618ddb7edc Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Sun, 3 Sep 2017 18:23:09 -0400 Subject: [PATCH] no-distracting-elements --- src/validate/html/a11y.ts | 5 +++++ .../a11y-no-distracting-elements/input.html | 2 ++ .../warnings.json | 19 +++++++++++++++++++ 3 files changed, 26 insertions(+) create mode 100644 test/validator/samples/a11y-no-distracting-elements/input.html create mode 100644 test/validator/samples/a11y-no-distracting-elements/warnings.json diff --git a/src/validate/html/a11y.ts b/src/validate/html/a11y.ts index d06ba4ce7c..dd1755b0c7 100644 --- a/src/validate/html/a11y.ts +++ b/src/validate/html/a11y.ts @@ -130,6 +130,11 @@ export default function a11y( shouldHaveAttribute(['title']); } + // no-distracting-elements + if (node.name === 'marquee' || node.name === 'blink') { + validator.warn(`A11y: Avoid <${node.name}> elements`, node.start); + } + if (node.name === 'figcaption') { const parent = elementStack[elementStack.length - 1]; if (parent) { diff --git a/test/validator/samples/a11y-no-distracting-elements/input.html b/test/validator/samples/a11y-no-distracting-elements/input.html new file mode 100644 index 0000000000..cffd2e6412 --- /dev/null +++ b/test/validator/samples/a11y-no-distracting-elements/input.html @@ -0,0 +1,2 @@ + + \ No newline at end of file diff --git a/test/validator/samples/a11y-no-distracting-elements/warnings.json b/test/validator/samples/a11y-no-distracting-elements/warnings.json new file mode 100644 index 0000000000..3b54de094f --- /dev/null +++ b/test/validator/samples/a11y-no-distracting-elements/warnings.json @@ -0,0 +1,19 @@ +[ + { + "message": "A11y: Avoid elements", + "loc": { + "line": 1, + "column": 0 + }, + "pos": 0 + }, + + { + "message": "A11y: Avoid elements", + "loc": { + "line": 2, + "column": 0 + }, + "pos": 11 + } +]