diff --git a/src/compiler/compile/nodes/shared/Expression.ts b/src/compiler/compile/nodes/shared/Expression.ts index 1882c19267..d45bd0bb3b 100644 --- a/src/compiler/compile/nodes/shared/Expression.ts +++ b/src/compiler/compile/nodes/shared/Expression.ts @@ -114,16 +114,14 @@ export default class Expression { let names; let deep = false; - if (function_expression) { - if (node.type === 'AssignmentExpression') { - deep = node.left.type === 'MemberExpression'; - names = deep - ? [get_object(node.left).name] - : extract_names(node.left); - } else if (node.type === 'UpdateExpression') { - const { name } = get_object(node.argument); - names = [name]; - } + if (node.type === 'AssignmentExpression') { + deep = node.left.type === 'MemberExpression'; + names = deep + ? [get_object(node.left).name] + : extract_names(node.left); + } else if (node.type === 'UpdateExpression') { + const { name } = get_object(node.argument); + names = [name]; } if (names) { diff --git a/test/vars/samples/mutated-reassigned-in-expression/_config.js b/test/vars/samples/mutated-reassigned-in-expression/_config.js new file mode 100644 index 0000000000..7e0a49b016 --- /dev/null +++ b/test/vars/samples/mutated-reassigned-in-expression/_config.js @@ -0,0 +1,50 @@ +export default { + test(assert, vars) { + assert.deepEqual(vars, [ + { + name: "a", + export_name: null, + injected: false, + module: false, + mutated: false, + reassigned: true, + referenced: true, + referenced_from_script: false, + writable: true + }, + { + name: "b", + export_name: null, + injected: false, + module: false, + mutated: true, + reassigned: false, + referenced: true, + referenced_from_script: false, + writable: true + }, + { + name: "c", + export_name: null, + injected: false, + module: false, + mutated: false, + reassigned: true, + referenced: true, + referenced_from_script: false, + writable: true + }, + { + name: "d", + export_name: null, + injected: false, + module: false, + mutated: true, + reassigned: false, + referenced: true, + referenced_from_script: false, + writable: true + } + ]); + } +}; diff --git a/test/vars/samples/mutated-reassigned-in-expression/input.svelte b/test/vars/samples/mutated-reassigned-in-expression/input.svelte new file mode 100644 index 0000000000..9daad012db --- /dev/null +++ b/test/vars/samples/mutated-reassigned-in-expression/input.svelte @@ -0,0 +1,10 @@ + +{() => a = 1} +{() => b.a = 1} +{c = 1} +{d.a = 1} \ No newline at end of file