From 82e431fb771e098fcf1242a8d09f2e9ea00f42f8 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Tue, 22 Jul 2025 20:33:53 -0400 Subject: [PATCH] =?UTF-8?q?update=20comment=20=E2=80=94=20it=20=5Fdoes=5F?= =?UTF-8?q?=20feel=20slightly=20wrong,=20but=20no=20wronger=20than=20the?= =?UTF-8?q?=20rest=20of=20this=20cursed=20function?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/svelte/src/internal/client/reactivity/batch.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/svelte/src/internal/client/reactivity/batch.js b/packages/svelte/src/internal/client/reactivity/batch.js index ddcf64d1a8..ce413fa1e1 100644 --- a/packages/svelte/src/internal/client/reactivity/batch.js +++ b/packages/svelte/src/internal/client/reactivity/batch.js @@ -461,7 +461,7 @@ export function flushSync(fn) { if (queued_root_effects.length === 0) { current_batch?.flush(); - // TODO this feels wrong + // we need to check again, in case we just updated an `$effect.pending()` if (queued_root_effects.length === 0) { // this would be reset in `flush_effects()` but since we are early returning here, // we need to reset it here as well in case the first time there's 0 queued root effects