From 823e13886622bd35d01171d0d96e9706fea317d5 Mon Sep 17 00:00:00 2001 From: Andreas Ehrencrona Date: Tue, 8 Dec 2020 12:57:30 +0200 Subject: [PATCH] broke tests --- src/compiler/compile/nodes/Binding.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/compiler/compile/nodes/Binding.ts b/src/compiler/compile/nodes/Binding.ts index ca41439d70..3a9aa943e9 100644 --- a/src/compiler/compile/nodes/Binding.ts +++ b/src/compiler/compile/nodes/Binding.ts @@ -72,7 +72,7 @@ export default class Binding extends Node { const variable = component.var_lookup.get(name); if (!variable || variable.global) { - component.error(this, { + component.error(this.expression.node as any, { code: 'binding-undeclared', message: `${name} is not declared` }); @@ -81,7 +81,7 @@ export default class Binding extends Node { variable[this.expression.node.type === 'MemberExpression' ? 'mutated' : 'reassigned'] = true; if (info.expression.type === 'Identifier' && !variable.writable) { - component.error(this, { + component.error(this.expression.node as any, { code: 'invalid-binding', message: 'Cannot bind to a variable which is not writable' }); @@ -90,10 +90,6 @@ export default class Binding extends Node { const type = parent.get_static_attribute_value('type'); - function isElement(node: Node): node is Element { - return !!(node as any).is_media_node; - } - this.is_readonly = dimensions.test(this.name) || (isElement(parent) && @@ -105,3 +101,7 @@ export default class Binding extends Node { return read_only_media_attributes.has(this.name); } } + +function isElement(node: Node): node is Element { + return !!(node as any).is_media_node; +}