From 7fb397e78f3c07908cb88ef894658d7433eb3938 Mon Sep 17 00:00:00 2001 From: "svelte-triage-bot[bot]" <316883489+svelte-triage-bot[bot]@users.noreply.github.com> Date: Mon, 28 Sep 2026 14:32:59 +0200 Subject: [PATCH] fix: handle deferred transitions aborted before initialization (#18776) - make deferred transition facade methods safe before the inner animation initializes - report the transition's initial position from the facade until initialization - add a runtime regression test for an out-only `crossfade` branch restored in the same update Fixes https://github.com/sveltejs/svelte/issues/18773 --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> --- .changeset/tidy-ducks-reset.md | 5 ++++ .../client/dom/elements/transitions.js | 6 ++--- .../deferred-outro-restored/_config.js | 13 ++++++++++ .../deferred-outro-restored/main.svelte | 24 +++++++++++++++++++ 4 files changed, 45 insertions(+), 3 deletions(-) create mode 100644 .changeset/tidy-ducks-reset.md create mode 100644 packages/svelte/tests/runtime-runes/samples/deferred-outro-restored/_config.js create mode 100644 packages/svelte/tests/runtime-runes/samples/deferred-outro-restored/main.svelte diff --git a/.changeset/tidy-ducks-reset.md b/.changeset/tidy-ducks-reset.md new file mode 100644 index 0000000000..41a00cf649 --- /dev/null +++ b/.changeset/tidy-ducks-reset.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: handle deferred transitions aborted before initialization diff --git a/packages/svelte/src/internal/client/dom/elements/transitions.js b/packages/svelte/src/internal/client/dom/elements/transitions.js index 67b177841a..f6d36d86de 100644 --- a/packages/svelte/src/internal/client/dom/elements/transitions.js +++ b/packages/svelte/src/internal/client/dom/elements/transitions.js @@ -359,9 +359,9 @@ function animate(element, options, counterpart, t2, on_begin, on_finish) { aborted = true; a?.abort(); }, - deactivate: () => a.deactivate(), - reset: () => a.reset(), - t: () => a.t() + deactivate: () => a?.deactivate(), + reset: () => a?.reset(), + t: () => a?.t() ?? 1 - t2 }; } diff --git a/packages/svelte/tests/runtime-runes/samples/deferred-outro-restored/_config.js b/packages/svelte/tests/runtime-runes/samples/deferred-outro-restored/_config.js new file mode 100644 index 0000000000..367da37815 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/deferred-outro-restored/_config.js @@ -0,0 +1,13 @@ +import { flushSync } from 'svelte'; +import { test } from '../../test'; + +export default test({ + async test({ assert, target }) { + const [button] = target.querySelectorAll('button'); + + button.click(); + flushSync(); + + assert.htmlEqual(target.innerHTML, '

Deferred outro

'); + } +}); diff --git a/packages/svelte/tests/runtime-runes/samples/deferred-outro-restored/main.svelte b/packages/svelte/tests/runtime-runes/samples/deferred-outro-restored/main.svelte new file mode 100644 index 0000000000..396a8b2528 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/deferred-outro-restored/main.svelte @@ -0,0 +1,24 @@ + + + + +{#if visible} +

Deferred outro

+{/if}