From 7eb14e7e79cd5dee21401ec7cc83361e6004231e Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Mon, 27 Nov 2023 09:43:21 -0500 Subject: [PATCH] continue not break --- .../svelte/src/compiler/phases/2-analyze/index.js | 2 +- .../samples/runes-referenced-nonstate/input.svelte | 4 +++- .../samples/runes-referenced-nonstate/warnings.json | 12 ++++++++++++ 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/packages/svelte/src/compiler/phases/2-analyze/index.js b/packages/svelte/src/compiler/phases/2-analyze/index.js index 540a1b9912..a278c89272 100644 --- a/packages/svelte/src/compiler/phases/2-analyze/index.js +++ b/packages/svelte/src/compiler/phases/2-analyze/index.js @@ -432,7 +432,7 @@ export function analyze_component(root, options) { } warn(warnings, binding.node, [], 'non-state-reference', name); - break outer; + continue outer; } } } diff --git a/packages/svelte/tests/validator/samples/runes-referenced-nonstate/input.svelte b/packages/svelte/tests/validator/samples/runes-referenced-nonstate/input.svelte index 279cce7109..fd9d6c3173 100644 --- a/packages/svelte/tests/validator/samples/runes-referenced-nonstate/input.svelte +++ b/packages/svelte/tests/validator/samples/runes-referenced-nonstate/input.svelte @@ -1,8 +1,10 @@ -

{a} + {b} = {a + b}

+ +

{a} + {b} + {c} = {a + b + c}

diff --git a/packages/svelte/tests/validator/samples/runes-referenced-nonstate/warnings.json b/packages/svelte/tests/validator/samples/runes-referenced-nonstate/warnings.json index e42a8d8782..7e251a4e70 100644 --- a/packages/svelte/tests/validator/samples/runes-referenced-nonstate/warnings.json +++ b/packages/svelte/tests/validator/samples/runes-referenced-nonstate/warnings.json @@ -10,5 +10,17 @@ "column": 6, "line": 3 } + }, + { + "code": "non-state-reference", + "message": "c is updated, but is not declared with $state(...). Changing its value will not correctly trigger updates.", + "start": { + "column": 5, + "line": 4 + }, + "end": { + "column": 6, + "line": 4 + } } ]