From 7d8d3c033d3cc9b2c406ae735571e83eb2d8fd33 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Tue, 17 Sep 2024 22:11:36 -0400 Subject: [PATCH] remove EFFECT_HAS_DIRTY_CHILDREN --- packages/svelte/src/internal/client/constants.js | 1 - packages/svelte/src/internal/client/runtime.js | 8 +++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/svelte/src/internal/client/constants.js b/packages/svelte/src/internal/client/constants.js index 588e3ef30f..04d59b98da 100644 --- a/packages/svelte/src/internal/client/constants.js +++ b/packages/svelte/src/internal/client/constants.js @@ -9,7 +9,6 @@ export const DISCONNECTED = 1 << 8; export const CLEAN = 1 << 9; export const DIRTY = 1 << 10; export const MAYBE_DIRTY = 1 << 11; -export const EFFECT_HAS_DIRTY_CHILDREN = 1 << 12; export const INERT = 1 << 13; export const DESTROYED = 1 << 14; export const EFFECT_RAN = 1 << 15; diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js index 645378486c..fbd3df8e5e 100644 --- a/packages/svelte/src/internal/client/runtime.js +++ b/packages/svelte/src/internal/client/runtime.js @@ -22,8 +22,7 @@ import { BLOCK_EFFECT, ROOT_EFFECT, LEGACY_DERIVED_PROP, - DISCONNECTED, - EFFECT_HAS_DIRTY_CHILDREN + DISCONNECTED } from './constants.js'; import { flush_tasks } from './dom/task.js'; import { add_owner } from './dev/ownership.js'; @@ -589,7 +588,7 @@ export function schedule_effect(signal) { if ((flags & BRANCH_EFFECT) !== 0) { if ((flags & CLEAN) === 0) return; - set_signal_status(effect, EFFECT_HAS_DIRTY_CHILDREN); + effect.f ^= CLEAN; } } @@ -621,7 +620,6 @@ function process_effects(effect, collected_effects) { // Skip this branch if it's clean if (is_active && (!is_branch || !is_clean)) { if (is_branch) { - // Can only be a branch effect with EFFECT_HAS_DIRTY_CHILDREN set_signal_status(current_effect, CLEAN); } @@ -845,7 +843,7 @@ export function untrack(fn) { } } -const STATUS_MASK = ~(DIRTY | MAYBE_DIRTY | CLEAN | EFFECT_HAS_DIRTY_CHILDREN); +const STATUS_MASK = ~(DIRTY | MAYBE_DIRTY | CLEAN); /** * @param {Signal} signal