From 7bea867c91b719fbd1877e7e1d204714876383c7 Mon Sep 17 00:00:00 2001 From: fivemru Date: Thu, 22 Oct 2020 20:12:02 +0300 Subject: [PATCH] Revert "tutorial: remove unnecessary call performance.now() inside raf" This reverts commit 159cf86df6027af66a75ac3d3b470cf607de0d90. --- .../tutorial/06-bindings/12-bind-this/app-a/App.svelte | 8 +++++--- .../tutorial/06-bindings/12-bind-this/app-b/App.svelte | 8 +++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/site/content/tutorial/06-bindings/12-bind-this/app-a/App.svelte b/site/content/tutorial/06-bindings/12-bind-this/app-a/App.svelte index f8f93edc2b..d40c45ef6c 100644 --- a/site/content/tutorial/06-bindings/12-bind-this/app-a/App.svelte +++ b/site/content/tutorial/06-bindings/12-bind-this/app-a/App.svelte @@ -5,9 +5,9 @@ onMount(() => { const ctx = canvas.getContext('2d'); - let frame = requestAnimationFrame(loop); + let frame; - function loop(t) { + (function loop() { frame = requestAnimationFrame(loop); const imageData = ctx.getImageData(0, 0, canvas.width, canvas.height); @@ -17,6 +17,8 @@ const x = i % canvas.width; const y = i / canvas.height >>> 0; + const t = window.performance.now(); + const r = 64 + (128 * x / canvas.width) + (64 * Math.sin(t / 1000)); const g = 64 + (128 * y / canvas.height) + (64 * Math.cos(t / 1000)); const b = 128; @@ -28,7 +30,7 @@ } ctx.putImageData(imageData, 0, 0); - } + }()); return () => { cancelAnimationFrame(frame); diff --git a/site/content/tutorial/06-bindings/12-bind-this/app-b/App.svelte b/site/content/tutorial/06-bindings/12-bind-this/app-b/App.svelte index 17005e273a..8e4b3c5bef 100644 --- a/site/content/tutorial/06-bindings/12-bind-this/app-b/App.svelte +++ b/site/content/tutorial/06-bindings/12-bind-this/app-b/App.svelte @@ -5,9 +5,9 @@ onMount(() => { const ctx = canvas.getContext('2d'); - let frame = requestAnimationFrame(loop); + let frame; - function loop(t) { + (function loop() { frame = requestAnimationFrame(loop); const imageData = ctx.getImageData(0, 0, canvas.width, canvas.height); @@ -17,6 +17,8 @@ const x = i % canvas.width; const y = i / canvas.height >>> 0; + const t = window.performance.now(); + const r = 64 + (128 * x / canvas.width) + (64 * Math.sin(t / 1000)); const g = 64 + (128 * y / canvas.height) + (64 * Math.cos(t / 1000)); const b = 128; @@ -28,7 +30,7 @@ } ctx.putImageData(imageData, 0, 0); - } + }()); return () => { cancelAnimationFrame(frame);