From 7b2279d84ca83f438efb05d11b2bbb51a398c761 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Tue, 23 Jul 2024 07:50:57 -0400 Subject: [PATCH] chore: tidy up dynamic event handler generated code (#12553) * chore: tidy up dynamic event handler generated code * actually we need a proper function --- .changeset/calm-cameras-hide.md | 5 +++++ .../phases/3-transform/client/visitors/template.js | 7 +++++-- 2 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 .changeset/calm-cameras-hide.md diff --git a/.changeset/calm-cameras-hide.md b/.changeset/calm-cameras-hide.md new file mode 100644 index 0000000000..63bf6a896b --- /dev/null +++ b/.changeset/calm-cameras-hide.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +chore: tidy up dynamic event handler generated code diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js index 170e426ca9..af10f0a4cd 100644 --- a/packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js +++ b/packages/svelte/src/compiler/phases/3-transform/client/visitors/template.js @@ -1137,9 +1137,12 @@ function serialize_event_handler(node, { state, visit }) { null, [b.rest(b.id('$$args'))], b.block([ - b.const('$$callback', /** @type {Expression} */ (visit(handler))), b.return( - b.call(b.member(b.id('$$callback'), b.id('apply'), false, true), b.this, b.id('$$args')) + b.call( + b.member(/** @type {Expression} */ (visit(handler)), b.id('apply'), false, true), + b.this, + b.id('$$args') + ) ) ]) );