From 79d3763e9299b0a844f3be430c8b8f45fa5da465 Mon Sep 17 00:00:00 2001 From: Mattias Buelens Date: Fri, 15 Nov 2019 01:26:09 +0100 Subject: [PATCH] Rename internal resize event for dimension bindings --- src/compiler/compile/render_dom/wrappers/Element/index.ts | 6 +++--- test/js/samples/bind-width-height/expected.js | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/compiler/compile/render_dom/wrappers/Element/index.ts b/src/compiler/compile/render_dom/wrappers/Element/index.ts index e3eec5d600..4b55237822 100644 --- a/src/compiler/compile/render_dom/wrappers/Element/index.ts +++ b/src/compiler/compile/render_dom/wrappers/Element/index.ts @@ -52,7 +52,7 @@ const events = [ }, { - event_names: ['resize'], + event_names: ['elementresize'], filter: (_node: Element, name: string) => dimensions.test(name) }, @@ -536,7 +536,7 @@ export default class ElementWrapper extends Wrapper { `); group.events.forEach(name => { - if (name === 'resize') { + if (name === 'elementresize') { // special case const resize_listener = block.get_unique_name(`${this.var.name}_resize_listener`); block.add_variable(resize_listener); @@ -578,7 +578,7 @@ export default class ElementWrapper extends Wrapper { ); } - if (group.events[0] === 'resize') { + if (group.events[0] === 'elementresize') { block.chunks.hydrate.push( b`@add_render_callback(() => ${callee}.call(${this.var}));` ); diff --git a/test/js/samples/bind-width-height/expected.js b/test/js/samples/bind-width-height/expected.js index ce20bc4aa7..18efcfdc08 100644 --- a/test/js/samples/bind-width-height/expected.js +++ b/test/js/samples/bind-width-height/expected.js @@ -19,11 +19,11 @@ function create_fragment(ctx) { c() { div = element("div"); div.textContent = "some content"; - add_render_callback(() => ctx.div_resize_handler.call(div)); + add_render_callback(() => ctx.div_elementresize_handler.call(div)); }, m(target, anchor) { insert(target, div, anchor); - div_resize_listener = add_resize_listener(div, ctx.div_resize_handler.bind(div)); + div_resize_listener = add_resize_listener(div, ctx.div_elementresize_handler.bind(div)); }, p: noop, i: noop, @@ -39,7 +39,7 @@ function instance($$self, $$props, $$invalidate) { let { w } = $$props; let { h } = $$props; - function div_resize_handler() { + function div_elementresize_handler() { w = this.offsetWidth; h = this.offsetHeight; $$invalidate("w", w); @@ -51,7 +51,7 @@ function instance($$self, $$props, $$invalidate) { if ("h" in $$props) $$invalidate("h", h = $$props.h); }; - return { w, h, div_resize_handler }; + return { w, h, div_elementresize_handler }; } class Component extends SvelteComponent {