From 7624833ac1a54ca6a9c1d56666c301532e4bb672 Mon Sep 17 00:00:00 2001 From: himynameisdave Date: Sat, 24 Apr 2021 17:45:57 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=91=A9=E2=80=8D=F0=9F=94=AC=20Add=20missi?= =?UTF-8?q?ng=20test=20files?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit They are still failing and need resolution. --- .../_config.js | 40 +++++++++++++++++++ .../main.svelte | 8 ++++ .../errors.json | 2 +- 3 files changed, 49 insertions(+), 1 deletion(-) create mode 100644 test/runtime/samples/binding-contenteditable-innertext/_config.js create mode 100644 test/runtime/samples/binding-contenteditable-innertext/main.svelte diff --git a/test/runtime/samples/binding-contenteditable-innertext/_config.js b/test/runtime/samples/binding-contenteditable-innertext/_config.js new file mode 100644 index 0000000000..4c30a3231a --- /dev/null +++ b/test/runtime/samples/binding-contenteditable-innertext/_config.js @@ -0,0 +1,40 @@ +export default { + html: ` + world +

hello world

+ `, + + ssrHtml: ` + world +

hello undefined

+ `, + + async test({ assert, component, target, window }) { + assert.equal(component.name, 'world'); + + const el = target.querySelector('editor'); + + el.innerHTML = 'everybody'; + + // No updates to data yet + assert.htmlEqual(target.innerHTML, ` + everybody +

hello world

+ `); + + // Handle user input + const event = new window.Event('input'); + await el.dispatchEvent(event); + assert.htmlEqual(target.innerHTML, ` + everybody +

hello everybody

+ `); + + component.name = 'goodbye'; + assert.equal(el.innerHTML, 'goodbye'); + assert.htmlEqual(target.innerHTML, ` + goodbye +

hello goodbye

+ `); + } +}; diff --git a/test/runtime/samples/binding-contenteditable-innertext/main.svelte b/test/runtime/samples/binding-contenteditable-innertext/main.svelte new file mode 100644 index 0000000000..4a65dba05f --- /dev/null +++ b/test/runtime/samples/binding-contenteditable-innertext/main.svelte @@ -0,0 +1,8 @@ + + + + world + +

hello {@html name}

diff --git a/test/validator/samples/a11y-contenteditable-element-without-child/errors.json b/test/validator/samples/a11y-contenteditable-element-without-child/errors.json index dd2a915b9d..311f20e17d 100644 --- a/test/validator/samples/a11y-contenteditable-element-without-child/errors.json +++ b/test/validator/samples/a11y-contenteditable-element-without-child/errors.json @@ -1,7 +1,7 @@ [ { "code": "missing-contenteditable-attribute", - "message": "'contenteditable' attribute is required for textContent and innerHTML two-way bindings", + "message": "'contenteditable' attribute is required for textContent/innerHTML/innerText two-way bindings", "start": { "line": 6, "column": 3,