From 7412307221bacf39ef4c976b5494030bf1c7437d Mon Sep 17 00:00:00 2001 From: Richard Harris Date: Thu, 10 Jan 2019 20:53:40 -0500 Subject: [PATCH] fix some stuff --- src/compile/render-dom/Block.ts | 1 - src/compile/render-dom/wrappers/Element/index.ts | 2 +- src/compile/render-dom/wrappers/IfBlock.ts | 1 - src/internal/transitions.js | 8 -------- .../transition-js-dynamic-if-block-bidi/_config.js | 4 ---- 5 files changed, 1 insertion(+), 15 deletions(-) diff --git a/src/compile/render-dom/Block.ts b/src/compile/render-dom/Block.ts index 524fda9c65..88f0bab5b4 100644 --- a/src/compile/render-dom/Block.ts +++ b/src/compile/render-dom/Block.ts @@ -363,7 +363,6 @@ export default class Block { } else { properties.addBlock(deindent` ${dev ? 'o: function outro' : 'o'}() { - if (#current === false) return; ${this.builders.outro} }, `); diff --git a/src/compile/render-dom/wrappers/Element/index.ts b/src/compile/render-dom/wrappers/Element/index.ts index e2008509c3..be8d355fa4 100644 --- a/src/compile/render-dom/wrappers/Element/index.ts +++ b/src/compile/render-dom/wrappers/Element/index.ts @@ -604,7 +604,7 @@ export default class ElementWrapper extends Wrapper { ${name}.run(0); `); - block.builders.destroy.addConditional('detach', `if (${name}) console.log('detaching'), ${name}.end();`); + block.builders.destroy.addConditional('detach', `if (${name}) ${name}.end();`); } else { diff --git a/src/compile/render-dom/wrappers/IfBlock.ts b/src/compile/render-dom/wrappers/IfBlock.ts index f5cb58ae28..f51ae396e7 100644 --- a/src/compile/render-dom/wrappers/IfBlock.ts +++ b/src/compile/render-dom/wrappers/IfBlock.ts @@ -431,7 +431,6 @@ export default class IfBlockWrapper extends Wrapper { ? deindent` @group_outros(); @on_outro(() => { - console.log('outros completed'); ${name}.d(1); ${name} = null; }); diff --git a/src/internal/transitions.js b/src/internal/transitions.js index 75e8741a30..3366153dda 100644 --- a/src/internal/transitions.js +++ b/src/internal/transitions.js @@ -18,7 +18,6 @@ function wait() { let outros; export function group_outros() { - console.log('grouping'); outros = { remaining: 0, callbacks: [] @@ -26,15 +25,12 @@ export function group_outros() { } export function check_outros() { - console.trace(`${outros.remaining} outros remaining`); if (!outros.remaining) { - console.log(outros.callbacks.map(c => c.toString())) run_all(outros.callbacks); } } export function on_outro(callback) { - console.log('adding', callback.toString()); outros.callbacks.push(callback); } @@ -251,7 +247,6 @@ export function create_bidirectional_transition(node, fn, params, intro) { node.dispatchEvent(new window.CustomEvent(`${running_program.b ? 'intro' : 'outro'}start`)); loop(now => { - console.log({ now, pending_program, running_program }); if (pending_program && now > pending_program.start) { running_program = init(pending_program, duration); pending_program = null; @@ -282,7 +277,6 @@ export function create_bidirectional_transition(node, fn, params, intro) { } } - console.log('running program ended'); running_program = null; } @@ -300,7 +294,6 @@ export function create_bidirectional_transition(node, fn, params, intro) { return { run(b) { - console.log(`run`, b); if (typeof config === 'function') { wait().then(() => { config = config(); @@ -312,7 +305,6 @@ export function create_bidirectional_transition(node, fn, params, intro) { }, end() { - console.log('end'); clear_animation(); running_program = pending_program = null; } diff --git a/test/runtime/samples/transition-js-dynamic-if-block-bidi/_config.js b/test/runtime/samples/transition-js-dynamic-if-block-bidi/_config.js index dae7613029..aa0bd9e1aa 100644 --- a/test/runtime/samples/transition-js-dynamic-if-block-bidi/_config.js +++ b/test/runtime/samples/transition-js-dynamic-if-block-bidi/_config.js @@ -16,15 +16,11 @@ export default { assert.equal(div.foo, 0.75); assert.htmlEqual(div.innerHTML, 'hello everybody!'); - console.group('set visible false'); component.visible = false; - console.groupEnd(); component.name = 'again'; assert.htmlEqual(div.innerHTML, 'hello everybody!'); - console.group('tick 125'); raf.tick(125); - console.groupEnd(); assert.equal(div.foo, 0.25); component.visible = true;