From d122a6f89362e33ff7e28627dcfaf23536557d84 Mon Sep 17 00:00:00 2001 From: Conduitry Date: Wed, 1 May 2019 01:43:44 -0400 Subject: [PATCH 1/2] fix determining which variables are initialised (#2635) --- src/compile/utils/scope.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/compile/utils/scope.ts b/src/compile/utils/scope.ts index 20cca46cba..6488986d83 100644 --- a/src/compile/utils/scope.ts +++ b/src/compile/utils/scope.ts @@ -75,12 +75,10 @@ export class Scope { if (node.kind === 'var' && this.block && this.parent) { this.parent.add_declaration(node); } else if (node.type === 'VariableDeclaration') { - const initialised = !!node.init; - node.declarations.forEach((declarator: Node) => { extract_names(declarator.id).forEach(name => { this.declarations.set(name, node); - if (initialised) this.initialised_declarations.add(name); + if (declarator.init) this.initialised_declarations.add(name); }); }); } else { From 8bfb5b7f332224bd091be1be574e7eeb6d1901d9 Mon Sep 17 00:00:00 2001 From: Conduitry Date: Wed, 1 May 2019 08:12:33 -0400 Subject: [PATCH 2/2] update tests --- .../runtime/samples/dev-warning-missing-data-binding/main.svelte | 1 + .../samples/dev-warning-missing-data-component/Foo.svelte | 1 + 2 files changed, 2 insertions(+) diff --git a/test/runtime/samples/dev-warning-missing-data-binding/main.svelte b/test/runtime/samples/dev-warning-missing-data-binding/main.svelte index 3714351783..cfc7830c90 100644 --- a/test/runtime/samples/dev-warning-missing-data-binding/main.svelte +++ b/test/runtime/samples/dev-warning-missing-data-binding/main.svelte @@ -1,5 +1,6 @@ \ No newline at end of file diff --git a/test/runtime/samples/dev-warning-missing-data-component/Foo.svelte b/test/runtime/samples/dev-warning-missing-data-component/Foo.svelte index 95422444cc..99e26245ae 100644 --- a/test/runtime/samples/dev-warning-missing-data-component/Foo.svelte +++ b/test/runtime/samples/dev-warning-missing-data-component/Foo.svelte @@ -1,6 +1,7 @@
{x} {y}
\ No newline at end of file