diff --git a/.changeset/fuzzy-urls-rest.md b/.changeset/fuzzy-urls-rest.md new file mode 100644 index 0000000000..c49215278e --- /dev/null +++ b/.changeset/fuzzy-urls-rest.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: avoid tracking SvelteURLSearchParams during URL updates diff --git a/packages/svelte/src/reactivity/url-search-params.js b/packages/svelte/src/reactivity/url-search-params.js index d745bb6b08..0b87820bfc 100644 --- a/packages/svelte/src/reactivity/url-search-params.js +++ b/packages/svelte/src/reactivity/url-search-params.js @@ -42,7 +42,7 @@ export class SvelteURLSearchParams extends URLSearchParams { if (!this.#url || this.#updating) return; this.#updating = true; - const search = this.toString(); + const search = super.toString(); this.#url.search = search && `?${search}`; this.#updating = false; diff --git a/packages/svelte/src/reactivity/url.test.ts b/packages/svelte/src/reactivity/url.test.ts index 72518d730a..4f597526be 100644 --- a/packages/svelte/src/reactivity/url.test.ts +++ b/packages/svelte/src/reactivity/url.test.ts @@ -115,6 +115,24 @@ test('url.searchParams', () => { cleanup(); }); +test('url.searchParams writes do not create a reactive dependency', () => { + const url = new SvelteURL('https://svelte.dev'); + let runs = 0; + + const cleanup = effect_root(() => { + render_effect(() => { + runs += 1; + url.searchParams.set('foo', 'bar'); + }); + }); + + flushSync(); + + assert.equal(runs, 1); + + cleanup(); +}); + test('url.searchParams.set updates url when duplicate values collapse to the same joined string', () => { const url = new SvelteURL('https://svelte.dev?a=ab&a=c'); const log: any = [];