From 684cdba2538bd7cfc695fcd8516ecbd21b3c08b5 Mon Sep 17 00:00:00 2001
From: Artyom Alekseevich <47069814+FrankFMY@users.noreply.github.com>
Date: Wed, 11 Feb 2026 21:53:23 +0100
Subject: [PATCH] fix: resolve effect_update_depth_exceeded with select
 bind:value in legacy mode (#17645)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## Summary

Fixes #13768

`<select bind:value={derived.prop}>` in legacy (non-runes) components
throws `effect_update_depth_exceeded` when the bound value comes from a
`$:` reactive statement.

**Root cause:** `setup_select_synchronization` created a
`template_effect` that called `invalidate_inner_signals`, which reads
and writes the same signals on every change — creating an infinite
update loop when those signals feed back into derived state.

**Fix:** Remove the effect-based synchronization entirely. Instead,
populate `legacy_indirect_bindings` during the analyze phase for
`<select bind:value>` elements, and call `invalidate_inner_signals`
inline at the mutation point in `AssignmentExpression` — only when the
binding is actually mutated, avoiding the read-write cycle.

Based on the approach outlined in #16200.

## Changes

- **`scope.js`**: Add `legacy_indirect_bindings` field to `Binding`
class
- **`RegularElement.js` (analyze)**: For `<select bind:value={foo}>`,
collect scope references as indirect bindings on the bound variable
- **`RegularElement.js` (transform)**: Remove
`setup_select_synchronization` function and its call site
- **`AssignmentExpression.js` (transform)**: When mutating a binding
with indirect bindings, append `invalidate_inner_signals` call after the
mutation

## Test plan

- Added `binding-select-reactive-derived` test that reproduces the exact
scenario from #13768
- All 3291 runtime-legacy tests pass (0 regressions)
- All 2312 runtime-runes tests pass
- All snapshot and compiler tests pass

---------

Co-authored-by: Rich Harris <rich.harris@vercel.com>
---
 .changeset/fix-select-bind-legacy-sync.md     |  5 ++
 .../2-analyze/visitors/RegularElement.js      | 30 ++++++++++
 .../client/visitors/AssignmentExpression.js   | 23 ++++++-
 .../client/visitors/RegularElement.js         | 60 -------------------
 packages/svelte/src/compiler/phases/scope.js  |  6 ++
 .../_config.js                                | 37 ++++++++++++
 .../main.svelte                               | 21 +++++++
 7 files changed, 120 insertions(+), 62 deletions(-)
 create mode 100644 .changeset/fix-select-bind-legacy-sync.md
 create mode 100644 packages/svelte/tests/runtime-legacy/samples/binding-select-reactive-derived/_config.js
 create mode 100644 packages/svelte/tests/runtime-legacy/samples/binding-select-reactive-derived/main.svelte

diff --git a/.changeset/fix-select-bind-legacy-sync.md b/.changeset/fix-select-bind-legacy-sync.md
new file mode 100644
index 0000000000..bf363f0fc4
--- /dev/null
+++ b/.changeset/fix-select-bind-legacy-sync.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: resolve `effect_update_depth_exceeded` when using `bind:value` on `<select>` with derived state in legacy mode
diff --git a/packages/svelte/src/compiler/phases/2-analyze/visitors/RegularElement.js b/packages/svelte/src/compiler/phases/2-analyze/visitors/RegularElement.js
index c7b40109a3..bc65bd65db 100644
--- a/packages/svelte/src/compiler/phases/2-analyze/visitors/RegularElement.js
+++ b/packages/svelte/src/compiler/phases/2-analyze/visitors/RegularElement.js
@@ -16,6 +16,8 @@ import { regex_starts_with_newline } from '../../patterns.js';
 import { check_element } from './shared/a11y/index.js';
 import { validate_element } from './shared/element.js';
 import { mark_subtree_dynamic } from './shared/fragment.js';
+import { object } from '../../../utils/ast.js';
+import { runes } from '../../../state.js';
 
 /**
  * @param {AST.RegularElement} node
@@ -64,6 +66,34 @@ export function RegularElement(node, context) {
 		}
 	}
 
+	// Special case: `<select bind:value={foo}><option>{bar}</option>`
+	// means we need to invalidate `bar` whenever `foo` is mutated
+	if (node.name === 'select' && !runes) {
+		for (const attribute of node.attributes) {
+			if (
+				attribute.type === 'BindDirective' &&
+				attribute.name === 'value' &&
+				attribute.expression.type !== 'SequenceExpression'
+			) {
+				const identifier = object(attribute.expression);
+				const binding = identifier && context.state.scope.get(identifier.name);
+
+				if (binding) {
+					for (const name of context.state.scope.references.keys()) {
+						if (name === binding.node.name) continue;
+						const indirect = context.state.scope.get(name);
+
+						if (indirect) {
+							binding.legacy_indirect_bindings.add(indirect);
+						}
+					}
+				}
+
+				break;
+			}
+		}
+	}
+
 	// Special case: single expression tag child of option element -> add "fake" attribute
 	// to ensure that value types are the same (else for example numbers would be strings)
 	if (
diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/AssignmentExpression.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/AssignmentExpression.js
index 0f6a619357..1379669e77 100644
--- a/packages/svelte/src/compiler/phases/3-transform/client/visitors/AssignmentExpression.js
+++ b/packages/svelte/src/compiler/phases/3-transform/client/visitors/AssignmentExpression.js
@@ -8,7 +8,7 @@ import {
 	is_event_attribute
 } from '../../../../utils/ast.js';
 import { dev, locate_node } from '../../../../state.js';
-import { should_proxy } from '../utils.js';
+import { build_getter, should_proxy } from '../utils.js';
 import { visit_assignment_expression } from '../../shared/assignments.js';
 import { validate_mutation } from './shared/utils.js';
 import { get_rune } from '../../../scope.js';
@@ -147,7 +147,7 @@ function build_assignment(operator, left, right, context) {
 
 	// mutation
 	if (transform?.mutate) {
-		return transform.mutate(
+		let mutation = transform.mutate(
 			object,
 			b.assignment(
 				operator,
@@ -155,6 +155,25 @@ function build_assignment(operator, left, right, context) {
 				/** @type {Expression} */ (context.visit(right))
 			)
 		);
+
+		if (binding.legacy_indirect_bindings.size > 0) {
+			mutation = b.sequence([
+				mutation,
+				b.call(
+					'$.invalidate_inner_signals',
+					b.arrow(
+						[],
+						b.block(
+							Array.from(binding.legacy_indirect_bindings).map((binding) =>
+								b.stmt(build_getter({ ...binding.node }, context.state))
+							)
+						)
+					)
+				)
+			]);
+		}
+
+		return mutation;
 	}
 
 	// in cases like `(object.items ??= []).push(value)`, we may need to warn
diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/RegularElement.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/RegularElement.js
index f651586dd8..7469dcda5b 100644
--- a/packages/svelte/src/compiler/phases/3-transform/client/visitors/RegularElement.js
+++ b/packages/svelte/src/compiler/phases/3-transform/client/visitors/RegularElement.js
@@ -199,10 +199,6 @@ export function RegularElement(node, context) {
 		}
 	}
 
-	if (node.name === 'select' && bindings.has('value')) {
-		setup_select_synchronization(/** @type {AST.BindDirective} */ (bindings.get('value')), context);
-	}
-
 	// Let bindings first, they can be used on attributes
 	context.state.init.push(...lets);
 
@@ -501,62 +497,6 @@ export function RegularElement(node, context) {
 	context.state.template.pop_element();
 }
 
-/**
- * Special case: if we have a value binding on a select element, we need to set up synchronization
- * between the value binding and inner signals, for indirect updates
- * @param {AST.BindDirective} value_binding
- * @param {ComponentContext} context
- */
-function setup_select_synchronization(value_binding, context) {
-	if (context.state.analysis.runes) return;
-
-	let bound = value_binding.expression;
-
-	if (bound.type === 'SequenceExpression') {
-		return;
-	}
-
-	while (bound.type === 'MemberExpression') {
-		bound = /** @type {Identifier | MemberExpression} */ (bound.object);
-	}
-
-	/** @type {string[]} */
-	const names = [];
-
-	for (const [name, refs] of context.state.scope.references) {
-		if (
-			refs.length > 0 &&
-			// prevent infinite loop
-			name !== bound.name
-		) {
-			names.push(name);
-		}
-	}
-
-	const invalidator = b.call(
-		'$.invalidate_inner_signals',
-		b.thunk(
-			b.block(
-				names.map((name) => {
-					const serialized = build_getter(b.id(name), context.state);
-					return b.stmt(serialized);
-				})
-			)
-		)
-	);
-
-	context.state.init.push(
-		b.stmt(
-			b.call(
-				'$.template_effect',
-				b.thunk(
-					b.block([b.stmt(/** @type {Expression} */ (context.visit(bound))), b.stmt(invalidator)])
-				)
-			)
-		)
-	);
-}
-
 /**
  * @param {AST.ClassDirective[]} class_directives
  * @param {ComponentContext} context
diff --git a/packages/svelte/src/compiler/phases/scope.js b/packages/svelte/src/compiler/phases/scope.js
index 52efd93210..a320718f58 100644
--- a/packages/svelte/src/compiler/phases/scope.js
+++ b/packages/svelte/src/compiler/phases/scope.js
@@ -120,6 +120,12 @@ export class Binding {
 	 */
 	legacy_dependencies = [];
 
+	/**
+	 * Bindings that should be invalidated when this binding is invalidated
+	 * @type {Set<Binding>}
+	 */
+	legacy_indirect_bindings = new Set();
+
 	/**
 	 * Legacy props: the `class` in `{ export klass as class}`. $props(): The `class` in { class: klass } = $props()
 	 * @type {string | null}
diff --git a/packages/svelte/tests/runtime-legacy/samples/binding-select-reactive-derived/_config.js b/packages/svelte/tests/runtime-legacy/samples/binding-select-reactive-derived/_config.js
new file mode 100644
index 0000000000..54f1fea7d0
--- /dev/null
+++ b/packages/svelte/tests/runtime-legacy/samples/binding-select-reactive-derived/_config.js
@@ -0,0 +1,37 @@
+import { test } from '../../test';
+
+export default test({
+	ssrHtml: `
+		<select>
+			<option selected="" value="">Select</option>
+			<option value="us">US</option>
+			<option value="uk">UK</option>
+		</select>
+	`,
+
+	async test({ assert, target, window, variant }) {
+		assert.htmlEqual(
+			target.innerHTML,
+			`
+			<select>
+				<option${variant === 'hydrate' ? ' selected=""' : ''} value="">Select</option>
+				<option value="us">US</option>
+				<option value="uk">UK</option>
+			</select>
+		`
+		);
+
+		const [select] = target.querySelectorAll('select');
+		const options = target.querySelectorAll('option');
+
+		assert.equal(select.value, '');
+
+		const change = new window.Event('change');
+
+		// Select "UK"
+		options[2].selected = true;
+		await select.dispatchEvent(change);
+
+		assert.equal(select.value, 'uk');
+	}
+});
diff --git a/packages/svelte/tests/runtime-legacy/samples/binding-select-reactive-derived/main.svelte b/packages/svelte/tests/runtime-legacy/samples/binding-select-reactive-derived/main.svelte
new file mode 100644
index 0000000000..57342347f5
--- /dev/null
+++ b/packages/svelte/tests/runtime-legacy/samples/binding-select-reactive-derived/main.svelte
@@ -0,0 +1,21 @@
+<script>
+	const default_details = {
+		country: '',
+	}
+
+	$: data = {
+		locked: false,
+		details: null,
+	}
+
+	$: details = data.details ?? default_details
+</script>
+
+<select
+	bind:value={details.country}
+	disabled={data.locked}
+>
+	<option value="">Select</option>
+	<option value="us">US</option>
+	<option value="uk">UK</option>
+</select>