From 6742c8c5e9a28558257b1a230f4cf8be7b66186c Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Tue, 1 May 2018 22:31:43 -0400 Subject: [PATCH] on second thoughts, cycles is a better name still --- store.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/store.js b/store.js index 7d43127251..ddb7941527 100644 --- a/store.js +++ b/store.js @@ -50,7 +50,7 @@ assign(Store.prototype, { var computed = this._computed; var sorted = this._sortedComputedProperties = []; var visited = blankObject(); - var lookup = blankObject(); + var cycles = blankObject(); function visit(key) { if (visited[key]) return; @@ -59,12 +59,12 @@ assign(Store.prototype, { var c = computed[key]; if (c) { - if (!lookup[key]) lookup[key] = blankObject(); + if (!cycles[key]) cycles[key] = blankObject(); c.deps.forEach(dep => { - if (lookup[dep] && lookup[dep][key]) { + if (cycles[dep] && cycles[dep][key]) { throw new Error(`Cyclical dependency detected between ${dep} <-> ${key}`); } - lookup[key][dep] = true; + cycles[key][dep] = true; visit(dep); }); sorted.push(c);