From c62f77a5d2874570f92ca6936df7d64eee7f4ae1 Mon Sep 17 00:00:00 2001
From: Christopher Pfohl <Christopher.Pfohl@gmail.com>
Date: Wed, 7 Feb 2018 05:46:32 -0500
Subject: [PATCH 1/2] Empty Each Blocks should have consistent behavior.

Here the `error-each-blocks-empty` behaves as expected. It throws a ParseError.
I can't get the whitespace errors to repro in the tests. They're easily seen
here: https://svelte.technology/repl?version=1.51.0&gist=e1596f9631619a689e85c80e46506692

If you uncomment each section in sequence it demonstrates the behavior. I can't
quite figure out why my examples don't work.
---
 test/parser/samples/error-comment-unclosed/error.json     | 8 ++++++++
 test/parser/samples/error-comment-unclosed/input.html     | 1 +
 test/parser/samples/error-each-blocks-empty/error.json    | 8 ++++++++
 test/parser/samples/error-each-blocks-empty/input.html    | 1 +
 .../samples/error-each-blocks-keyed-whitespace/error.json | 8 ++++++++
 .../samples/error-each-blocks-keyed-whitespace/input.html | 8 ++++++++
 .../samples/error-each-blocks-whitespace/error.json       | 8 ++++++++
 .../samples/error-each-blocks-whitespace/input.html       | 2 ++
 8 files changed, 44 insertions(+)
 create mode 100644 test/parser/samples/error-comment-unclosed/error.json
 create mode 100644 test/parser/samples/error-comment-unclosed/input.html
 create mode 100644 test/parser/samples/error-each-blocks-empty/error.json
 create mode 100644 test/parser/samples/error-each-blocks-empty/input.html
 create mode 100644 test/parser/samples/error-each-blocks-keyed-whitespace/error.json
 create mode 100644 test/parser/samples/error-each-blocks-keyed-whitespace/input.html
 create mode 100644 test/parser/samples/error-each-blocks-whitespace/error.json
 create mode 100644 test/parser/samples/error-each-blocks-whitespace/input.html

diff --git a/test/parser/samples/error-comment-unclosed/error.json b/test/parser/samples/error-comment-unclosed/error.json
new file mode 100644
index 0000000000..2502a32735
--- /dev/null
+++ b/test/parser/samples/error-comment-unclosed/error.json
@@ -0,0 +1,8 @@
+{
+	"message": "comment was left open",
+	"loc": {
+		"line": 1,
+		"column": 0
+	},
+	"pos": 0
+}
diff --git a/test/parser/samples/error-comment-unclosed/input.html b/test/parser/samples/error-comment-unclosed/input.html
new file mode 100644
index 0000000000..725cf9be60
--- /dev/null
+++ b/test/parser/samples/error-comment-unclosed/input.html
@@ -0,0 +1 @@
+<!-- an unclosed comment
diff --git a/test/parser/samples/error-each-blocks-empty/error.json b/test/parser/samples/error-each-blocks-empty/error.json
new file mode 100644
index 0000000000..6ecdc198bd
--- /dev/null
+++ b/test/parser/samples/error-each-blocks-empty/error.json
@@ -0,0 +1,8 @@
+{
+	"message": "Empty block",
+	"loc": {
+		"line": 1,
+		"column": 0
+	},
+	"pos": 0
+}
diff --git a/test/parser/samples/error-each-blocks-empty/input.html b/test/parser/samples/error-each-blocks-empty/input.html
new file mode 100644
index 0000000000..00b4b07d5a
--- /dev/null
+++ b/test/parser/samples/error-each-blocks-empty/input.html
@@ -0,0 +1 @@
+{{#each foos as foo}}{{/each}}
diff --git a/test/parser/samples/error-each-blocks-keyed-whitespace/error.json b/test/parser/samples/error-each-blocks-keyed-whitespace/error.json
new file mode 100644
index 0000000000..6ecdc198bd
--- /dev/null
+++ b/test/parser/samples/error-each-blocks-keyed-whitespace/error.json
@@ -0,0 +1,8 @@
+{
+	"message": "Empty block",
+	"loc": {
+		"line": 1,
+		"column": 0
+	},
+	"pos": 0
+}
diff --git a/test/parser/samples/error-each-blocks-keyed-whitespace/input.html b/test/parser/samples/error-each-blocks-keyed-whitespace/input.html
new file mode 100644
index 0000000000..eeb9a6e06b
--- /dev/null
+++ b/test/parser/samples/error-each-blocks-keyed-whitespace/input.html
@@ -0,0 +1,8 @@
+{{#each foos as foo @id}}
+{{/each}}
+
+<script>
+	export default {
+		data: () => ({ foos: [] })
+	}
+</script>
diff --git a/test/parser/samples/error-each-blocks-whitespace/error.json b/test/parser/samples/error-each-blocks-whitespace/error.json
new file mode 100644
index 0000000000..6ecdc198bd
--- /dev/null
+++ b/test/parser/samples/error-each-blocks-whitespace/error.json
@@ -0,0 +1,8 @@
+{
+	"message": "Empty block",
+	"loc": {
+		"line": 1,
+		"column": 0
+	},
+	"pos": 0
+}
diff --git a/test/parser/samples/error-each-blocks-whitespace/input.html b/test/parser/samples/error-each-blocks-whitespace/input.html
new file mode 100644
index 0000000000..30e29859b8
--- /dev/null
+++ b/test/parser/samples/error-each-blocks-whitespace/input.html
@@ -0,0 +1,2 @@
+{{#each foos as foo}}
+{{/each}}

From b55ccc6d9fc7b754d88d121717e5025965f9d509 Mon Sep 17 00:00:00 2001
From: Christopher Pfohl <Christopher.Pfohl@gmail.com>
Date: Wed, 7 Feb 2018 06:53:32 -0500
Subject: [PATCH 2/2] Make sure scripts are passing good data so it's only the
 parse that can go wrong

---
 .../error-each-blocks-keyed-whitespace/input.html     | 11 +++++++----
 .../samples/error-each-blocks-whitespace/input.html   |  9 +++++++++
 2 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/test/parser/samples/error-each-blocks-keyed-whitespace/input.html b/test/parser/samples/error-each-blocks-keyed-whitespace/input.html
index eeb9a6e06b..c801984a56 100644
--- a/test/parser/samples/error-each-blocks-keyed-whitespace/input.html
+++ b/test/parser/samples/error-each-blocks-keyed-whitespace/input.html
@@ -1,8 +1,11 @@
 {{#each foos as foo @id}}
 {{/each}}
-
 <script>
-	export default {
-		data: () => ({ foos: [] })
-	}
+  export default {
+    data: () => ({
+      foos: [
+        { "id": 5 }
+      ]
+    })
+  };
 </script>
diff --git a/test/parser/samples/error-each-blocks-whitespace/input.html b/test/parser/samples/error-each-blocks-whitespace/input.html
index 30e29859b8..2b4af0cac6 100644
--- a/test/parser/samples/error-each-blocks-whitespace/input.html
+++ b/test/parser/samples/error-each-blocks-whitespace/input.html
@@ -1,2 +1,11 @@
 {{#each foos as foo}}
 {{/each}}
+<script>
+  export default {
+    data: () => ({
+      foos: [
+        "id": 5
+      ]
+    })
+  };
+</script>