From 5fb0678175732c2d35cd7e92ce87ef89e08c0d22 Mon Sep 17 00:00:00 2001
From: Tan Li Hau <lhtan93@gmail.com>
Date: Sat, 11 Jan 2020 19:11:14 +0800
Subject: [PATCH] only render one <title>

---
 src/compiler/compile/render_ssr/handlers/Title.ts      |  6 ++++++
 src/runtime/internal/ssr.ts                            |  5 +++--
 .../samples/head-multiple-title/A.svelte               |  3 +++
 .../samples/head-multiple-title/B.svelte               |  3 +++
 .../samples/head-multiple-title/_expected-head.html    |  1 +
 .../samples/head-multiple-title/_expected.html         |  0
 .../samples/head-multiple-title/data.json              |  3 +++
 .../samples/head-multiple-title/main.svelte            | 10 ++++++++++
 8 files changed, 29 insertions(+), 2 deletions(-)
 create mode 100644 test/server-side-rendering/samples/head-multiple-title/A.svelte
 create mode 100644 test/server-side-rendering/samples/head-multiple-title/B.svelte
 create mode 100644 test/server-side-rendering/samples/head-multiple-title/_expected-head.html
 create mode 100644 test/server-side-rendering/samples/head-multiple-title/_expected.html
 create mode 100644 test/server-side-rendering/samples/head-multiple-title/data.json
 create mode 100644 test/server-side-rendering/samples/head-multiple-title/main.svelte

diff --git a/src/compiler/compile/render_ssr/handlers/Title.ts b/src/compiler/compile/render_ssr/handlers/Title.ts
index 62d49d461a..f1f458ed5b 100644
--- a/src/compiler/compile/render_ssr/handlers/Title.ts
+++ b/src/compiler/compile/render_ssr/handlers/Title.ts
@@ -1,10 +1,16 @@
 import Renderer, { RenderOptions } from '../Renderer';
 import Title from '../../nodes/Title';
+import { x } from 'code-red';
 
 export default function(node: Title, renderer: Renderer, options: RenderOptions) {
+	renderer.push();
+
 	renderer.add_string(`<title>`);
 
 	renderer.render(node.children, options);
 
 	renderer.add_string(`</title>`);
+	const result = renderer.pop();
+
+	renderer.add_expression(x`($$result.title = ${result}, "")`);
 }
diff --git a/src/runtime/internal/ssr.ts b/src/runtime/internal/ssr.ts
index 274006f243..b032284d52 100644
--- a/src/runtime/internal/ssr.ts
+++ b/src/runtime/internal/ssr.ts
@@ -103,12 +103,13 @@ export function create_ssr_component(fn) {
 			on_destroy = [];
 
 			const result: {
+				title: string;
 				head: string;
 				css: Set<{
 					map: null;
 					code: string;
 				}>;
-			} = { head: '', css: new Set() };
+			} = { title: '', head: '', css: new Set() };
 
 			const html = $$render(result, props, {}, options);
 
@@ -120,7 +121,7 @@ export function create_ssr_component(fn) {
 					code: Array.from(result.css).map(css => css.code).join('\n'),
 					map: null // TODO
 				},
-				head: result.head
+				head: result.title + result.head
 			};
 		},
 
diff --git a/test/server-side-rendering/samples/head-multiple-title/A.svelte b/test/server-side-rendering/samples/head-multiple-title/A.svelte
new file mode 100644
index 0000000000..b139b4ff77
--- /dev/null
+++ b/test/server-side-rendering/samples/head-multiple-title/A.svelte
@@ -0,0 +1,3 @@
+<svelte:head>
+	<title>A</title>
+</svelte:head>
diff --git a/test/server-side-rendering/samples/head-multiple-title/B.svelte b/test/server-side-rendering/samples/head-multiple-title/B.svelte
new file mode 100644
index 0000000000..4a29ecb04c
--- /dev/null
+++ b/test/server-side-rendering/samples/head-multiple-title/B.svelte
@@ -0,0 +1,3 @@
+<svelte:head>
+	<title>B</title>
+</svelte:head>
diff --git a/test/server-side-rendering/samples/head-multiple-title/_expected-head.html b/test/server-side-rendering/samples/head-multiple-title/_expected-head.html
new file mode 100644
index 0000000000..af5c5feba4
--- /dev/null
+++ b/test/server-side-rendering/samples/head-multiple-title/_expected-head.html
@@ -0,0 +1 @@
+<title>B</title>
\ No newline at end of file
diff --git a/test/server-side-rendering/samples/head-multiple-title/_expected.html b/test/server-side-rendering/samples/head-multiple-title/_expected.html
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/test/server-side-rendering/samples/head-multiple-title/data.json b/test/server-side-rendering/samples/head-multiple-title/data.json
new file mode 100644
index 0000000000..eab238e816
--- /dev/null
+++ b/test/server-side-rendering/samples/head-multiple-title/data.json
@@ -0,0 +1,3 @@
+{
+	"adjective": "custom"
+}
\ No newline at end of file
diff --git a/test/server-side-rendering/samples/head-multiple-title/main.svelte b/test/server-side-rendering/samples/head-multiple-title/main.svelte
new file mode 100644
index 0000000000..fb9a70b923
--- /dev/null
+++ b/test/server-side-rendering/samples/head-multiple-title/main.svelte
@@ -0,0 +1,10 @@
+<script>
+	import A from './A.svelte';
+	import B from './B.svelte';
+</script>
+
+<svelte:head>
+	<title>Main</title>
+</svelte:head>
+<A />
+<B />