From 5ebd9e0b45afe070199900a6a98b03681a7cd038 Mon Sep 17 00:00:00 2001
From: Rich Harris <richard.a.harris@gmail.com>
Date: Mon, 29 Jan 2024 14:36:57 -0500
Subject: [PATCH] fix: disallow TODO errors (#10326)

* disallow TODO errors

* replace TODO errors

* changeset

---------

Co-authored-by: Rich Harris <rich.harris@vercel.com>
---
 .changeset/lemon-geese-call.md                           | 5 +++++
 packages/svelte/src/compiler/errors.js                   | 6 ++++--
 packages/svelte/src/compiler/phases/1-parse/state/tag.js | 4 ++--
 3 files changed, 11 insertions(+), 4 deletions(-)
 create mode 100644 .changeset/lemon-geese-call.md

diff --git a/.changeset/lemon-geese-call.md b/.changeset/lemon-geese-call.md
new file mode 100644
index 0000000000..8090d4512d
--- /dev/null
+++ b/.changeset/lemon-geese-call.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: replace TODO errors
diff --git a/packages/svelte/src/compiler/errors.js b/packages/svelte/src/compiler/errors.js
index 910f5fd651..98741e29f4 100644
--- a/packages/svelte/src/compiler/errors.js
+++ b/packages/svelte/src/compiler/errors.js
@@ -88,7 +88,9 @@ const parse = {
 	'illegal-subscription': () => `Cannot reference store value inside <script context="module">`,
 	'duplicate-style-element': () => `A component can have a single top-level <style> element`,
 	'duplicate-script-element': () =>
-		`A component can have a single top-level <script> element and/or a single top-level <script context="module"> element`
+		`A component can have a single top-level <script> element and/or a single top-level <script context="module"> element`,
+	'invalid-render-expression': () => 'expected an identifier followed by (...)',
+	'invalid-render-arguments': () => 'expected at most one argument'
 };
 
 /** @satisfies {Errors} */
@@ -508,7 +510,7 @@ export class CompileError extends Error {
 }
 
 /**
- * @template {keyof typeof errors} T
+ * @template {Exclude<keyof typeof errors, 'TODO'>} T
  * @param {NodeLike | number | null} node
  * @param {T} code
  * @param  {Parameters<typeof errors[T]>} args
diff --git a/packages/svelte/src/compiler/phases/1-parse/state/tag.js b/packages/svelte/src/compiler/phases/1-parse/state/tag.js
index ebfebb73b1..88a444a1f9 100644
--- a/packages/svelte/src/compiler/phases/1-parse/state/tag.js
+++ b/packages/svelte/src/compiler/phases/1-parse/state/tag.js
@@ -586,11 +586,11 @@ function special(parser) {
 		const expression = read_expression(parser);
 
 		if (expression.type !== 'CallExpression' || expression.callee.type !== 'Identifier') {
-			error(expression, 'TODO', 'expected an identifier followed by (...)');
+			error(expression, 'invalid-render-expression');
 		}
 
 		if (expression.arguments.length > 1) {
-			error(expression.arguments[1], 'TODO', 'expected at most one argument');
+			error(expression.arguments[1], 'invalid-render-arguments');
 		}
 
 		parser.allow_whitespace();