fix: delete transformers shadowed by unreassigned state (#13316)

fixes #13314
pull/13322/head
Rich Harris 12 months ago committed by GitHub
parent b3842d7982
commit 5d56c592ff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -0,0 +1,5 @@
---
'svelte': patch
---
fix: delete transformers shadowed by unreassigned state

@ -4,7 +4,7 @@
/** @import { Visitors, ComponentClientTransformState, ClientTransformState } from './types' */
import { walk } from 'zimmerframe';
import * as b from '../../../utils/builders.js';
import { build_getter } from './utils.js';
import { build_getter, is_state_source } from './utils.js';
import { render_stylesheet } from '../css/index.js';
import { dev, filename } from '../../../state.js';
import { AnimateDirective } from './visitors/AnimateDirective.js';
@ -66,7 +66,12 @@ const visitors = {
const transform = { ...state.transform };
for (const [name, binding] of scope.declarations) {
if (binding.kind === 'normal') {
if (
binding.kind === 'normal' ||
// Reads of `$state(...)` declarations are not
// transformed if they are never reassigned
(binding.kind === 'state' && !is_state_source(binding, state.analysis))
) {
delete transform[name];
}
}

@ -0,0 +1,5 @@
import { test } from '../../test';
export default test({
html: `<div>0</div>`
});

@ -0,0 +1,8 @@
<script>
let value = $derived.by(() => {
const value = $state(0);
return value;
});
</script>
<div>{value}</div>
Loading…
Cancel
Save