msb-public
/
svelte
mirror of https://github.com/sveltejs/svelte
1
0
Code Issues Projects Releases Wiki Activity

rename loc to start, include character info in locations

Browse Source
pull/1348/head
Rich Harris 7 years ago
parent 07bad96719
commit 5a457bfb87
151 changed files with 787 additions and 489 deletions
Show Stats Download Patch File Download Diff File

2
package.json
Unescape View File

@ -58,7 +58,7 @@
"glob": "^7.1.1",
"is-reference": "^1.1.0",
"jsdom": "^11.6.1",
"locate-character": "^2.0.0",
"locate-character": "^2.0.5",
"magic-string": "^0.22.3",
"mocha": "^3.2.0",
"nightmare": "^2.10.0",

12
src/css/Stylesheet.ts
Unescape View File

@ -392,20 +392,22 @@ export default class Stylesheet {
const handler = (selector: Selector) => {
const pos = selector.node.start;
if (!locator) locator = getLocator(this.source);
const { line, column } = locator(pos);
if (!locator) locator = getLocator(this.source, { offsetLine: 1 });
const start = locator(pos);
const end = locator(selector.node.end);
const frame = getCodeFrame(this.source, line, column);
const frame = getCodeFrame(this.source, start.line - 1, start.column);
const message = `Unused CSS selector`;
onwarn({
code: `css-unused-selector`,
message,
frame,
loc: { line: line + 1, column },
start,
end,
pos,
filename: this.filename,
toString: () => `${message} (${line + 1}:${column})\n${frame}`,
toString: () => `${message} (${start.line}:${start.column})\n${frame}`,
});
};

1
src/generators/Generator.ts
Unescape View File

@ -5,7 +5,6 @@ import { getLocator } from 'locate-character';
import Stats from '../Stats';
import deindent from '../utils/deindent';
import CodeBuilder from '../utils/CodeBuilder';
import getCodeFrame from '../utils/getCodeFrame';
import flattenReference from '../utils/flattenReference';
import reservedNames from '../utils/reservedNames';
import namespaces from '../utils/namespaces';

4
src/index.ts
Unescape View File

@ -23,9 +23,9 @@ function normalizeOptions(options: CompileOptions): CompileOptions {
}
function defaultOnwarn(warning: Warning) {
if (warning.loc) {
if (warning.start) {
console.warn(
`(${warning.loc.line}:${warning.loc.column}) – ${warning.message}`
`(${warning.start.line}:${warning.start.column}) – ${warning.message}`
); // eslint-disable-line no-console
} else {
console.warn(warning.message); // eslint-disable-line no-console

2
src/interfaces.ts
Unescape View File

@ -28,7 +28,7 @@ export interface Parsed {
}
export interface Warning {
loc?: { line: number; column: number; pos?: number };
start?: { line: number; column: number; pos?: number };
end?: { line: number; column: number; };
pos?: number;
code: string;

1
src/parse/index.ts
Unescape View File

@ -3,7 +3,6 @@ import { locate, Location } from 'locate-character';
import fragment from './state/fragment';
import { whitespace } from '../utils/patterns';
import { trimStart, trimEnd } from '../utils/trim';
import getCodeFrame from '../utils/getCodeFrame';
import reservedNames from '../utils/reservedNames';
import fullCharCodeAt from '../utils/fullCharCodeAt';
import hash from '../utils/hash';

14
src/utils/error.ts
Unescape View File

@ -3,14 +3,14 @@ import getCodeFrame from '../utils/getCodeFrame';
class CompileError extends Error {
code: string;
loc: { line: number, column: number };
start: { line: number, column: number };
end: { line: number, column: number };
pos: number;
filename: string;
frame: string;
toString() {
return `${this.message} (${this.loc.line}:${this.loc.column})\n${this.frame}`;
return `${this.message} (${this.start.line}:${this.start.column})\n${this.frame}`;
}
}
@ -25,16 +25,16 @@ export default function error(message: string, props: {
const error = new CompileError(message);
error.name = props.name;
const start = locate(props.source, props.start);
const end = locate(props.source, props.end || props.start);
const start = locate(props.source, props.start, { offsetLine: 1 });
const end = locate(props.source, props.end || props.start, { offsetLine: 1 });
error.code = props.code;
error.loc = { line: start.line + 1, column: start.column };
error.end = { line: end.line + 1, column: end.column };
error.start = start;
error.end = end;
error.pos = props.start;
error.filename = props.filename;
error.frame = getCodeFrame(props.source, start.line, start.column);
error.frame = getCodeFrame(props.source, start.line - 1, start.column);
throw error;
}

8
src/validate/index.ts
Unescape View File

@ -73,18 +73,18 @@ export class Validator {
}
warn(pos: { start: number, end: number }, { code, message }: { code: string, message: string }) {
if (!this.locator) this.locator = getLocator(this.source);
if (!this.locator) this.locator = getLocator(this.source, { offsetLine: 1 });
const start = this.locator(pos.start);
const end = this.locator(pos.end);
const frame = getCodeFrame(this.source, start.line, start.column);
const frame = getCodeFrame(this.source, start.line - 1, start.column);
this.stats.warn({
code,
message,
frame,
loc: { line: start.line + 1, column: start.column },
end: { line: end.line + 1, column: end.column },
start,
end,
pos: pos.start,
filename: this.filename,
toString: () => `${message} (${start.line + 1}:${start.column})\n${frame}`,

10
test/css/samples/empty-class/_config.js
Unescape View File

@ -3,9 +3,15 @@ export default {
filename: "SvelteComponent.html",
code: `css-unused-selector`,
message: "Unused CSS selector",
loc: {
start: {
line: 4,
column: 1
column: 1,
character: 31
},
end: {
line: 4,
column: 3,
character: 33
},
pos: 31,
frame: `

10
test/css/samples/omit-scoping-attribute-descendant/_config.js
Unescape View File

@ -2,9 +2,15 @@ export default {
warnings: [{
code: `css-unused-selector`,
message: 'Unused CSS selector',
loc: {
start: {
line: 8,
column: 1
column: 1,
character: 74
},
end: {
line: 8,
column: 8,
character: 81
},
pos: 74,
frame: `

10
test/css/samples/refs-qualified/_config.js
Unescape View File

@ -6,9 +6,15 @@ export default {
warnings: [{
code: `css-unused-selector`,
message: 'Unused CSS selector',
loc: {
start: {
column: 1,
line: 12
line: 12,
character: 169
},
end: {
column: 20,
line: 12,
character: 188
},
pos: 169,
frame: `

10
test/css/samples/refs/_config.js
Unescape View File

@ -2,9 +2,15 @@ export default {
warnings: [{
code: `css-unused-selector`,
message: 'Unused CSS selector',
loc: {
start: {
column: 1,
line: 14
line: 14,
character: 120
},
end: {
column: 6,
line: 14,
character: 125
},
pos: 120,
frame: `

20
test/css/samples/unused-selector-leading/_config.js
Unescape View File

@ -4,9 +4,15 @@ export default {
filename: "SvelteComponent.html",
code: `css-unused-selector`,
message: "Unused CSS selector",
loc: {
start: {
line: 4,
column: 1
column: 1,
character: 34
},
end: {
line: 4,
column: 5,
character: 38
},
pos: 34,
frame: `
@ -22,9 +28,15 @@ export default {
filename: "SvelteComponent.html",
code: `css-unused-selector`,
message: "Unused CSS selector",
loc: {
start: {
line: 4,
column: 13,
character: 46
},
end: {
line: 4,
column: 13
column: 17,
character: 50
},
pos: 46,
frame: `

10
test/css/samples/unused-selector-ternary/_config.js
Unescape View File

@ -7,9 +7,15 @@ export default {
filename: "SvelteComponent.html",
code: `css-unused-selector`,
message: "Unused CSS selector",
loc: {
start: {
line: 12,
column: 1
column: 1,
character: 123
},
end: {
line: 12,
column: 13,
character: 135
},
pos: 123,
frame: `

10
test/css/samples/unused-selector/_config.js
Unescape View File

@ -3,9 +3,15 @@ export default {
filename: "SvelteComponent.html",
code: `css-unused-selector`,
message: "Unused CSS selector",
loc: {
start: {
line: 8,
column: 1
column: 1,
character: 60
},
end: {
line: 8,
column: 5,
character: 64
},
pos: 60,
frame: `

2
test/js/index.js
Unescape View File

@ -71,7 +71,7 @@ describe("js", () => {
expectedBundle.trim().replace(/^[ \t]+$/gm, "")
);
}).catch(err => {
if (err.loc) console.error(err.loc);
if (err.start) console.error(err.start);
throw err;
});
});

4
test/parser/index.js
Unescape View File

@ -37,9 +37,9 @@ describe('parse', () => {
try {
assert.equal(err.code, expectedError.code);
assert.equal(err.message, expectedError.message);
assert.deepEqual(err.loc, expectedError.loc);
assert.deepEqual(err.start, expectedError.start);
assert.equal(err.pos, expectedError.pos);
assert.equal(err.toString().split('\n')[0], `${expectedError.message} (${expectedError.loc.line}:${expectedError.loc.column})`);
assert.equal(err.toString().split('\n')[0], `${expectedError.message} (${expectedError.start.line}:${expectedError.start.column})`);
} catch (err2) {
const e = err2.code === 'MODULE_NOT_FOUND' ? err : err2;
throw e;

5
test/parser/samples/attribute-unique-error/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "duplicate-attribute",
"message": "Attributes need to be unique",
"loc": {
"start": {
"line": 1,
"column": 17
"column": 17,
"character": 17
},
"pos": 17
}

5
test/parser/samples/error-binding-disabled/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "binding-disabled",
"message": "Two-way binding is disabled",
"loc": {
"start": {
"line": 1,
"column": 7
"column": 7,
"character": 7
},
"pos": 7
}

5
test/parser/samples/error-binding-mustaches/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "invalid-directive-value",
"message": "directive values should not be wrapped — use 'foo', not '{foo}'",
"loc": {
"start": {
"line": 1,
"column": 19
"column": 19,
"character": 19
},
"pos": 19
}

5
test/parser/samples/error-binding-rvalue/error.json
Unescape View File

@ -2,8 +2,9 @@
"code": "invalid-directive-value",
"message": "Can only bind to an identifier (e.g. `foo`) or a member expression (e.g. `foo.bar` or `foo[baz]`)",
"pos": 19,
"loc": {
"start": {
"line": 1,
"column": 19
"column": 19,
"character": 19
}
}

5
test/parser/samples/error-comment-unclosed/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "unexpected-eof",
"message": "comment was left open, expected -->",
"loc": {
"start": {
"line": 1,
"column": 24
"column": 24,
"character": 24
},
"pos": 24
}

5
test/parser/samples/error-css/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "css-syntax-error",
"message": "LeftCurlyBracket is expected",
"loc": {
"start": {
"line": 2,
"column": 16
"column": 16,
"character": 24
},
"pos": 24
}

5
test/parser/samples/error-event-handler/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "invalid-directive-value",
"message": "Expected a method call",
"loc": {
"start": {
"line": 1,
"column": 15
"column": 15,
"character": 15
},
"pos": 15
}

5
test/parser/samples/error-illegal-expression/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "parse-error",
"message": "Assigning to rvalue",
"loc": {
"start": {
"line": 1,
"column": 1
"column": 1,
"character": 1
},
"pos": 1
}

5
test/parser/samples/error-multiple-styles/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "duplicate-style",
"message": "You can only have one top-level <style> tag per component",
"loc": {
"start": {
"line": 9,
"column": 0
"column": 0,
"character": 58
},
"pos": 58
}

5
test/parser/samples/error-ref-value/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "invalid-directive-value",
"message": "ref directives cannot have a value",
"loc": {
"start": {
"line": 1,
"column": 14
"column": 14,
"character": 14
},
"pos": 14
}

5
test/parser/samples/error-script-unclosed/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "unclosed-script",
"message": "<script> must have a closing tag",
"loc": {
"start": {
"line": 3,
"column": 8
"column": 8,
"character": 32
},
"pos": 32
}

5
test/parser/samples/error-self-reference/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "invalid-self-placement",
"message": "<svelte:self> components can only exist inside if-blocks or each-blocks",
"loc": {
"start": {
"line": 1,
"column": 1
"column": 1,
"character": 1
},
"pos": 1
}

5
test/parser/samples/error-unexpected-end-of-input-b/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "unexpected-eof",
"message": "Unexpected end of input",
"loc": {
"start": {
"line": 1,
"column": 2
"column": 2,
"character": 2
},
"pos": 2
}

5
test/parser/samples/error-unexpected-end-of-input-c/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "unexpected-eof",
"message": "Unexpected end of input",
"loc": {
"start": {
"line": 1,
"column": 1
"column": 1,
"character": 1
},
"pos": 1
}

5
test/parser/samples/error-unexpected-end-of-input-d/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "unclosed-block",
"message": "Block was left open",
"loc": {
"start": {
"line": 1,
"column": 0
"column": 0,
"character": 0
},
"pos": 0
}

5
test/parser/samples/error-unexpected-end-of-input/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "unclosed-element",
"message": "<div> was left open",
"loc": {
"start": {
"line": 1,
"column": 0
"column": 0,
"character": 0
},
"pos": 0
}

5
test/parser/samples/error-unmatched-closing-tag/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "invalid-closing-tag",
"message": "</div> attempted to close an element that was not open",
"loc": {
"start": {
"line": 1,
"column": 0
"column": 0,
"character": 0
},
"pos": 0
}

5
test/parser/samples/error-void-closing/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "invalid-void-content",
"message": "<input> is a void element and cannot have children, or a closing tag",
"loc": {
"start": {
"line": 1,
"column": 23
"column": 23,
"character": 23
},
"pos": 23
}

5
test/parser/samples/error-window-children/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "invalid-window-content",
"message": "<svelte:window> cannot have children",
"loc": {
"start": {
"line": 1,
"column": 15
"column": 15,
"character": 15
},
"pos": 15
}

5
test/parser/samples/error-window-duplicate/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "duplicate-window",
"message": "A component can only have one <svelte:window> tag",
"loc": {
"start": {
"line": 2,
"column": 0
"column": 0,
"character": 17
},
"pos": 17
}

5
test/parser/samples/error-window-inside-block/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "invalid-window-placement",
"message": "<svelte:window> tags cannot be inside elements or blocks",
"loc": {
"start": {
"line": 2,
"column": 1
"column": 1,
"character": 11
},
"pos": 11
}

5
test/parser/samples/error-window-inside-element/error.json
Unescape View File

@ -1,9 +1,10 @@
{
"code": "invalid-window-placement",
"message": "<svelte:window> tags cannot be inside elements or blocks",
"loc": {
"start": {
"line": 2,
"column": 1
"column": 1,
"character": 7
},
"pos": 7
}

14
test/sourcemaps/samples/basic/test.js
Unescape View File

@ -1,14 +1,14 @@
export function test ({ assert, smc, locateInSource, locateInGenerated }) {
const expected = locateInSource( 'foo.bar.baz' );
let loc;
let start;
let actual;
loc = locateInGenerated( 'foo.bar.baz' );
start = locateInGenerated( 'foo.bar.baz' );
actual = smc.originalPositionFor({
line: loc.line + 1,
column: loc.column
line: start.line + 1,
column: start.column
});
assert.deepEqual( actual, {
@ -18,11 +18,11 @@ export function test ({ assert, smc, locateInSource, locateInGenerated }) {
column: expected.column
});
loc = locateInGenerated( 'foo.bar.baz', loc.character + 1 );
start = locateInGenerated( 'foo.bar.baz', start.character + 1 );
actual = smc.originalPositionFor({
line: loc.line + 1,
column: loc.column
line: start.line + 1,
column: start.column
});
assert.deepEqual( actual, {

12
test/sourcemaps/samples/binding-shorthand/test.js
Unescape View File

@ -1,15 +1,15 @@
export function test ({ assert, smc, locateInSource, locateInGenerated }) {
const expected = locateInSource( 'potato' );
let loc;
let start;
loc = locateInGenerated( 'potato' );
loc = locateInGenerated( 'potato', loc.character + 1 );
loc = locateInGenerated( 'potato', loc.character + 1 ); // we need the third instance of 'potato'
start = locateInGenerated( 'potato' );
start = locateInGenerated( 'potato', start.character + 1 );
start = locateInGenerated( 'potato', start.character + 1 ); // we need the third instance of 'potato'
const actual = smc.originalPositionFor({
line: loc.line + 1,
column: loc.column
line: start.line + 1,
column: start.column
});
assert.deepEqual( actual, {

14
test/sourcemaps/samples/binding/test.js
Unescape View File

@ -1,14 +1,14 @@
export function test ({ assert, smc, locateInSource, locateInGenerated }) {
const expected = locateInSource( 'bar.baz' );
let loc;
let start;
let actual;
loc = locateInGenerated( 'bar.baz' );
start = locateInGenerated( 'bar.baz' );
actual = smc.originalPositionFor({
line: loc.line + 1,
column: loc.column
line: start.line + 1,
column: start.column
});
assert.deepEqual( actual, {
@ -18,11 +18,11 @@ export function test ({ assert, smc, locateInSource, locateInGenerated }) {
column: expected.column
});
loc = locateInGenerated( 'bar.baz', loc.character + 1 );
start = locateInGenerated( 'bar.baz', start.character + 1 );
actual = smc.originalPositionFor({
line: loc.line + 1,
column: loc.column
line: start.line + 1,
column: start.column
});
assert.deepEqual( actual, {

6
test/sourcemaps/samples/css/test.js
Unescape View File

@ -1,11 +1,11 @@
export function test ({ assert, smcCss, locateInSource, locateInGeneratedCss }) {
const expected = locateInSource( '.foo' );
const loc = locateInGeneratedCss( '.foo' );
const start = locateInGeneratedCss( '.foo' );
const actual = smcCss.originalPositionFor({
line: loc.line + 1,
column: loc.column
line: start.line + 1,
column: start.column
});
assert.deepEqual( actual, {

6
test/sourcemaps/samples/each-block/test.js
Unescape View File

@ -2,11 +2,11 @@ export function test({ assert, code, smc, locateInSource, locateInGenerated }) {
const startIndex = code.indexOf('create_main_fragment');
const expected = locateInSource('each');
const loc = locateInGenerated('length', startIndex );
const start = locateInGenerated('length', startIndex );
const actual = smc.originalPositionFor({
line: loc.line + 1,
column: loc.column
line: start.line + 1,
column: start.column
});
assert.deepEqual( actual, {

6
test/sourcemaps/samples/script/test.js
Unescape View File

@ -1,10 +1,10 @@
export function test ({ assert, smc, locateInSource, locateInGenerated }) {
const expected = locateInSource( '42' );
const loc = locateInGenerated( '42' );
const start = locateInGenerated( '42' );
const actual = smc.originalPositionFor({
line: loc.line + 1,
column: loc.column
line: start.line + 1,
column: start.column
});
assert.deepEqual( actual, {

2
test/stats/index.js
Unescape View File

@ -50,7 +50,7 @@ describe('stats', () => {
}
assert.equal(error.message, expectedError.message);
assert.deepEqual(error.loc, expectedError.loc);
assert.deepEqual(error.start, expectedError.start);
assert.deepEqual(error.end, expectedError.end);
assert.equal(error.pos, expectedError.pos);
}

14
test/validator/index.js
Unescape View File

@ -28,8 +28,8 @@ describe("validate", () => {
const { stats } = svelte.compile(input, {
onwarn(warning) {
const { code, message, pos, loc, end } = warning;
warnings.push({ code, message, pos, loc, end });
const { code, message, pos, start, end } = warning;
warnings.push({ code, message, pos, start, end });
},
dev: config.dev,
generate: false
@ -42,7 +42,7 @@ describe("validate", () => {
code: full.code,
message: full.message,
pos: full.pos,
loc: full.loc,
start: full.start,
end: full.end
}, lite);
});
@ -65,7 +65,7 @@ describe("validate", () => {
assert.equal(error.code, expected.code);
assert.equal(error.message, expected.message);
assert.deepEqual(error.loc, expected.loc);
assert.deepEqual(error.start, expected.start);
assert.deepEqual(error.end, expected.end);
assert.equal(error.pos, expected.pos);
}
@ -90,7 +90,7 @@ describe("validate", () => {
code: warning.code,
message: warning.message,
pos: warning.pos,
loc: warning.loc
start: warning.start
});
},
generate: false
@ -100,7 +100,7 @@ describe("validate", () => {
code: `options-lowercase-name`,
message: "options.name should be capitalised",
pos: undefined,
loc: undefined
start: undefined
}
]);
});
@ -114,7 +114,7 @@ describe("validate", () => {
code: warning.code,
message: warning.message,
pos: warning.pos,
loc: warning.loc
start: warning.start
});
},
generate: false

32
test/validator/samples/a11y-alt-text/warnings.json
Unescape View File

@ -2,13 +2,15 @@
{
"code": "a11y-missing-attribute",
"message": "A11y: <img> element should have an alt attribute",
"loc": {
"start": {
"line": 1,
"column": 0
"column": 0,
"character": 0
},
"end": {
"line": 1,
"column": 19
"column": 19,
"character": 19
},
"pos": 0
},
@ -16,13 +18,15 @@
{
"code": "a11y-missing-attribute",
"message": "A11y: <area> element should have an alt, aria-label or aria-labelledby attribute",
"loc": {
"start": {
"line": 4,
"column": 1
"column": 1,
"character": 28
},
"end": {
"line": 4,
"column": 7
"column": 7,
"character": 34
},
"pos": 28
},
@ -30,13 +34,15 @@
{
"code": "a11y-missing-attribute",
"message": "A11y: <object> element should have a title, aria-label or aria-labelledby attribute",
"loc": {
"start": {
"line": 7,
"column": 0
"column": 0,
"character": 43
},
"end": {
"line": 7,
"column": 17
"column": 17,
"character": 60
},
"pos": 43
},
@ -44,13 +50,15 @@
{
"code": "a11y-missing-attribute",
"message": "A11y: <input type=\"image\"> element should have an alt, aria-label or aria-labelledby attribute",
"loc": {
"start": {
"line": 9,
"column": 0
"column": 0,
"character": 62
},
"end": {
"line": 9,
"column": 20
"column": 20,
"character": 82
},
"pos": 62
}

8
test/validator/samples/a11y-anchor-has-content/warnings.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "a11y-missing-content",
"message": "A11y: <a> element should have child content",
"loc": {
"start": {
"line": 1,
"column": 0
"column": 0,
"character": 0
},
"end": {
"line": 1,
"column": 19
"column": 19,
"character": 19
},
"pos": 0
}]

66
test/validator/samples/a11y-anchor-in-svg-is-valid/warnings.json
Unescape View File

@ -1,41 +1,47 @@
[
{
"code": "a11y-missing-attribute",
"message": "A11y: <a> element should have an href attribute",
"loc": {
"line": 1,
"column": 11
},
{
"code": "a11y-missing-attribute",
"message": "A11y: <a> element should have an href attribute",
"start": {
"line": 1,
"column": 11,
"character": 11
},
"end": {
"line": 1,
"column": 37
"column": 37,
"character": 37
},
"pos": 11
},
{
"code": "a11y-invalid-attribute",
"message": "A11y: '' is not a valid xlink:href attribute",
"start": {
"line": 2,
"column": 14,
"character": 65
},
"pos": 11
},
{
"code": "a11y-invalid-attribute",
"message": "A11y: '' is not a valid xlink:href attribute",
"loc": {
"line": 2,
"column": 14
},
"end": {
"line": 2,
"column": 27
"column": 27,
"character": 78
},
"pos": 65
},
{
"code": "a11y-invalid-attribute",
"message": "A11y: '#' is not a valid xlink:href attribute",
"start": {
"line": 3,
"column": 14,
"character": 130
},
"pos": 65
},
{
"code": "a11y-invalid-attribute",
"message": "A11y: '#' is not a valid xlink:href attribute",
"loc": {
"line": 3,
"column": 14
},
"end": {
"line": 3,
"column": 28
"column": 28,
"character": 144
},
"pos": 130
}
"pos": 130
}
]

24
test/validator/samples/a11y-anchor-is-valid/warnings.json
Unescape View File

@ -2,39 +2,45 @@
{
"code": "a11y-missing-attribute",
"message": "A11y: <a> element should have an href attribute",
"loc": {
"start": {
"line": 1,
"column": 0
"column": 0,
"character": 0
},
"end": {
"line": 1,
"column": 26
"column": 26,
"character": 26
},
"pos": 0
},
{
"code": "a11y-invalid-attribute",
"message": "A11y: '' is not a valid href attribute",
"loc": {
"start": {
"line": 2,
"column": 3
"column": 3,
"character": 30
},
"end": {
"line": 2,
"column": 10
"column": 10,
"character": 37
},
"pos": 30
},
{
"code": "a11y-invalid-attribute",
"message": "A11y: '#' is not a valid href attribute",
"loc": {
"start": {
"line": 3,
"column": 3
"column": 3,
"character": 53
},
"end": {
"line": 3,
"column": 11
"column": 11,
"character": 61
},
"pos": 53
}

16
test/validator/samples/a11y-aria-props/warnings.json
Unescape View File

@ -2,13 +2,15 @@
{
"code": "a11y-unknown-aria-attribute",
"message": "A11y: Unknown aria attribute 'aria-labeledby' (did you mean 'labelledby'?)",
"loc": {
"start": {
"line": 1,
"column": 20
"column": 20,
"character": 20
},
"end": {
"line": 1,
"column": 40
"column": 40,
"character": 40
},
"pos": 20
},
@ -16,13 +18,15 @@
{
"code": "a11y-missing-attribute",
"message": "A11y: <input type=\"image\"> element should have an alt, aria-label or aria-labelledby attribute",
"loc": {
"start": {
"column": 0,
"line": 1
"line": 1,
"character": 0
},
"end": {
"line": 1,
"column": 41
"column": 41,
"character": 41
},
"pos": 0
}

8
test/validator/samples/a11y-aria-role/warnings.json
Unescape View File

@ -2,13 +2,15 @@
{
"code": "a11y-unknown-role",
"message": "A11y: Unknown role 'toooltip' (did you mean 'tooltip'?)",
"loc": {
"start": {
"line": 1,
"column": 5
"column": 5,
"character": 5
},
"end": {
"line": 1,
"column": 20
"column": 20,
"character": 20
},
"pos": 5
}

16
test/validator/samples/a11y-aria-unsupported-element/warnings.json
Unescape View File

@ -2,13 +2,15 @@
{
"code": "a11y-aria-attributes",
"message": "A11y: <meta> should not have aria-* attributes",
"loc": {
"start": {
"line": 1,
"column": 6
"column": 6,
"character": 6
},
"end": {
"line": 1,
"column": 25
"column": 25,
"character": 25
},
"pos": 6
},
@ -16,13 +18,15 @@
{
"code": "a11y-misplaced-role",
"message": "A11y: <meta> should not have role attribute",
"loc": {
"start": {
"line": 2,
"column": 6
"column": 6,
"character": 33
},
"end": {
"line": 2,
"column": 20
"column": 20,
"character": 47
},
"pos": 33
}

16
test/validator/samples/a11y-figcaption-wrong-place/warnings.json
Unescape View File

@ -2,26 +2,30 @@
{
"code": "a11y-structure",
"message": "A11y: <figcaption> must be first or last child of <figure>",
"loc": {
"start": {
"line": 4,
"column": 1
"column": 1,
"character": 57
},
"end": {
"line": 6,
"column": 14
"column": 14,
"character": 115
},
"pos": 57
},
{
"code": "a11y-structure",
"message": "A11y: <figcaption> must be an immediate child of <figure>",
"loc": {
"start": {
"line": 15,
"column": 2
"column": 2,
"character": 252
},
"end": {
"line": 17,
"column": 15
"column": 15,
"character": 328
},
"pos": 252
}

16
test/validator/samples/a11y-heading-has-content/warnings.json
Unescape View File

@ -2,13 +2,15 @@
{
"code": "a11y-missing-content",
"message": "A11y: <h1> element should have child content",
"loc": {
"start": {
"line": 1,
"column": 0
"column": 0,
"character": 0
},
"end": {
"line": 1,
"column": 9
"column": 9,
"character": 9
},
"pos": 0
},
@ -16,13 +18,15 @@
{
"code": "a11y-hidden",
"message": "A11y: <h2> element should not be hidden",
"loc": {
"start": {
"line": 2,
"column": 4
"column": 4,
"character": 14
},
"end": {
"line": 2,
"column": 15
"column": 15,
"character": 25
},
"pos": 14
}

8
test/validator/samples/a11y-html-has-lang/warnings.json
Unescape View File

@ -2,13 +2,15 @@
{
"code": "a11y-missing-attribute",
"message": "A11y: <html> element should have a lang attribute",
"loc": {
"start": {
"column": 0,
"line": 5
"line": 5,
"character": 82
},
"end": {
"line": 5,
"column": 13
"column": 13,
"character": 95
},
"pos": 82
}

8
test/validator/samples/a11y-iframe-has-title/warnings.json
Unescape View File

@ -2,13 +2,15 @@
{
"code": "a11y-missing-attribute",
"message": "A11y: <iframe> element should have a title attribute",
"loc": {
"start": {
"line": 1,
"column": 0
"column": 0,
"character": 0
},
"end": {
"line": 1,
"column": 29
"column": 29,
"character": 29
},
"pos": 0
}

8
test/validator/samples/a11y-no-access-key/warnings.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "a11y-accesskey",
"message": "A11y: Avoid using accesskey",
"loc": {
"start": {
"line": 1,
"column": 5
"column": 5,
"character": 5
},
"end": {
"line": 1,
"column": 18
"column": 18,
"character": 18
},
"pos": 5
}]

8
test/validator/samples/a11y-no-autofocus/warnings.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "a11y-autofocus",
"message": "A11y: Avoid using autofocus",
"loc": {
"start": {
"line": 1,
"column": 5
"column": 5,
"character": 5
},
"end": {
"line": 1,
"column": 14
"column": 14,
"character": 14
},
"pos": 5
}]

16
test/validator/samples/a11y-no-distracting-elements/warnings.json
Unescape View File

@ -2,13 +2,15 @@
{
"code": "a11y-distracting-elements",
"message": "A11y: Avoid <marquee> elements",
"loc": {
"start": {
"line": 1,
"column": 0
"column": 0,
"character": 0
},
"end": {
"line": 1,
"column": 10
"column": 10,
"character": 10
},
"pos": 0
},
@ -16,13 +18,15 @@
{
"code": "a11y-distracting-elements",
"message": "A11y: Avoid <blink> elements",
"loc": {
"start": {
"line": 2,
"column": 0
"column": 0,
"character": 11
},
"end": {
"line": 2,
"column": 8
"column": 8,
"character": 19
},
"pos": 11
}

8
test/validator/samples/a11y-not-on-components/warnings.json
Unescape View File

@ -2,13 +2,15 @@
{
"code": "a11y-autofocus",
"message": "A11y: Avoid using autofocus",
"loc": {
"start": {
"column": 8,
"line": 2
"line": 2,
"character": 29
},
"end": {
"line": 2,
"column": 17
"column": 17,
"character": 38
},
"pos": 29
}

8
test/validator/samples/a11y-scope/warnings.json
Unescape View File

@ -2,13 +2,15 @@
{
"code": "a11y-misplaced-scope",
"message": "A11y: The scope attribute should only be used with <th> elements",
"loc": {
"start": {
"line": 1,
"column": 5
"column": 5,
"character": 5
},
"end": {
"line": 1,
"column": 10
"column": 10,
"character": 10
},
"pos": 5
}

8
test/validator/samples/a11y-tabindex-no-positive/warnings.json
Unescape View File

@ -2,13 +2,15 @@
{
"code": "a11y-positive-tabindex",
"message": "A11y: avoid tabindex values above zero",
"loc": {
"start": {
"line": 3,
"column": 5
"column": 5,
"character": 46
},
"end": {
"line": 3,
"column": 17
"column": 17,
"character": 58
},
"pos": 46
}

8
test/validator/samples/action-invalid/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "missing-action",
"message": "Missing action 'whatever'",
"pos": 5,
"loc": {
"start": {
"line": 1,
"column": 5
"column": 5,
"character": 5
},
"end": {
"line": 1,
"column": 17
"column": 17,
"character": 17
}
}]

8
test/validator/samples/action-on-component/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "invalid-action",
"message": "Actions can only be applied to DOM elements, not components",
"pos": 8,
"loc": {
"start": {
"line": 1,
"column": 8
"column": 8,
"character": 8
},
"end": {
"line": 1,
"column": 15
"column": 15,
"character": 15
}
}]

8
test/validator/samples/binding-input-checked/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "invalid-binding",
"message": "'checked' binding can only be used with <input type=\"checkbox\">",
"loc": {
"start": {
"line": 1,
"column": 7
"column": 7,
"character": 7
},
"end": {
"line": 1,
"column": 25
"column": 25,
"character": 25
},
"pos": 7
}]

8
test/validator/samples/binding-input-type-boolean/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "missing-type",
"message": "'type' attribute must be specified",
"loc": {
"start": {
"line": 1,
"column": 24
"column": 24,
"character": 24
},
"end": {
"line": 1,
"column": 28
"column": 28,
"character": 28
},
"pos": 24
}]

8
test/validator/samples/binding-input-type-dynamic/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "invalid-type",
"message": "'type' attribute cannot be dynamic if input uses two-way binding",
"loc": {
"start": {
"line": 1,
"column": 24
"column": 24,
"character": 24
},
"end": {
"line": 1,
"column": 42
"column": 42,
"character": 42
},
"pos": 24
}]

8
test/validator/samples/binding-invalid-on-element/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "invalid-binding",
"message": "'value' is not a valid binding on <div> elements",
"pos": 5,
"loc": {
"start": {
"line": 1,
"column": 5
"column": 5,
"character": 5
},
"end": {
"line": 1,
"column": 15
"column": 15,
"character": 15
}
}]

8
test/validator/samples/binding-invalid/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "invalid-binding",
"message": "'whatever' is not a valid binding",
"pos": 5,
"loc": {
"start": {
"line": 1,
"column": 5
"column": 5,
"character": 5
},
"end": {
"line": 1,
"column": 18
"column": 18,
"character": 18
}
}]

8
test/validator/samples/binding-select-multiple-dynamic/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "dynamic-multiple-attribute",
"message": "'multiple' attribute cannot be dynamic if select uses two-way binding",
"loc": {
"start": {
"line": 1,
"column": 19
"column": 19,
"character": 19
},
"end": {
"line": 1,
"column": 29
"column": 29,
"character": 29
},
"pos": 19
}]

8
test/validator/samples/component-cannot-be-called-state/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "invalid-name",
"message": "Component constructors cannot be called 'state' due to technical limitations",
"pos": 73,
"loc": {
"start": {
"line": 6,
"column": 3
"column": 3,
"character": 73
},
"end": {
"line": 6,
"column": 8
"column": 8,
"character": 78
}
}]

2
test/validator/samples/component-slot-default-duplicate.skip/errors.json
Unescape View File

@ -1,6 +1,6 @@
[{
"message": "duplicate default <slot> element",
"loc": {
"start": {
"line": 2,
"column": 0
},

8
test/validator/samples/component-slot-default-reserved/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "invalid-slot-name",
"message": "default is a reserved word — it cannot be used as a slot name",
"loc": {
"start": {
"line": 1,
"column": 6
"column": 6,
"character": 6
},
"end": {
"line": 1,
"column": 20
"column": 20,
"character": 20
},
"pos": 6
}]

8
test/validator/samples/component-slot-dynamic-attribute/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "invalid-slot-attribute",
"message": "slot attribute cannot have a dynamic value",
"loc": {
"start": {
"line": 2,
"column": 9
"column": 9,
"character": 18
},
"end": {
"line": 2,
"column": 21
"column": 21,
"character": 30
},
"pos": 18
}]

8
test/validator/samples/component-slot-dynamic/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "dynamic-slot-name",
"message": "<slot> name cannot be dynamic",
"loc": {
"start": {
"line": 1,
"column": 6
"column": 6,
"character": 6
},
"end": {
"line": 1,
"column": 18
"column": 18,
"character": 18
},
"pos": 6
}]

8
test/validator/samples/component-slot-each-block/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "invalid-slot-placement",
"message": "<slot> cannot be a child of an each-block",
"loc": {
"start": {
"line": 2,
"column": 1
"column": 1,
"character": 25
},
"end": {
"line": 2,
"column": 1
"column": 1,
"character": 25
},
"pos": 25
}]

2
test/validator/samples/component-slot-named-duplicate.skip/errors.json
Unescape View File

@ -1,6 +1,6 @@
[{
"message": "duplicate 'foo' <slot> element",
"loc": {
"start": {
"line": 2,
"column": 6
},

8
test/validator/samples/component-slotted-each-block/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "invalid-slotted-content",
"message": "Cannot place slotted elements inside an each-block",
"loc": {
"start": {
"line": 3,
"column": 7
"column": 7,
"character": 41
},
"end": {
"line": 3,
"column": 17
"column": 17,
"character": 51
},
"pos": 41
}]

8
test/validator/samples/component-slotted-if-block/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "invalid-slotted-content",
"message": "Cannot place slotted elements inside an if-block",
"loc": {
"start": {
"line": 3,
"column": 7
"column": 7,
"character": 29
},
"end": {
"line": 3,
"column": 17
"column": 17,
"character": 39
},
"pos": 29
}]

8
test/validator/samples/computed-purity-check-no-this/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "impure-computed",
"message": "Computed properties should be pure functions — they do not have access to the component instance and cannot use 'this'. Did you mean to put this in 'methods'?",
"pos": 81,
"loc": {
"start": {
"line": 7,
"column": 4
"column": 4,
"character": 81
},
"end": {
"line": 7,
"column": 8
"column": 8,
"character": 85
}
}]

8
test/validator/samples/computed-purity-check-this-get/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "impure-computed",
"message": "Cannot use this.get(...) — values must be passed into the function as arguments",
"pos": 71,
"loc": {
"start": {
"line": 7,
"column": 11
"column": 11,
"character": 71
},
"end": {
"line": 7,
"column": 28
"column": 28,
"character": 88
}
}]

8
test/validator/samples/css-invalid-global-placement/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "css-invalid-global",
"message": ":global(...) can be at the start or end of a selector sequence, but not in the middle",
"loc": {
"start": {
"line": 2,
"column": 6
"column": 6,
"character": 14
},
"end": {
"line": 2,
"column": 19
"column": 19,
"character": 27
},
"pos": 14
}]

8
test/validator/samples/css-invalid-global/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "css-invalid-global",
"message": ":global(...) must be the first element in a compound selector",
"loc": {
"start": {
"line": 2,
"column": 5
"column": 5,
"character": 13
},
"end": {
"line": 2,
"column": 18
"column": 18,
"character": 26
},
"pos": 13
}]

8
test/validator/samples/each-block-invalid-context-destructured/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "unexpected-reserved-word",
"message": "'case' is a reserved word in JavaScript and cannot be used here",
"loc": {
"start": {
"line": 1,
"column": 17
"column": 17,
"character": 17
},
"end": {
"line": 1,
"column": 17
"column": 17,
"character": 17
},
"pos": 17
}]

8
test/validator/samples/each-block-invalid-context/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "unexpected-reserved-word",
"message": "'case' is a reserved word in JavaScript and cannot be used here",
"loc": {
"start": {
"line": 1,
"column": 16
"column": 16,
"character": 16
},
"end": {
"line": 1,
"column": 16
"column": 16,
"character": 16
},
"pos": 16
}]

16
test/validator/samples/empty-block-dev/warnings.json
Unescape View File

@ -2,26 +2,30 @@
{
"code": "empty-block",
"message": "Empty block",
"loc": {
"start": {
"line": 1,
"column": 0
"column": 0,
"character": 0
},
"end": {
"line": 3,
"column": 7
"column": 7,
"character": 32
},
"pos": 0
},
{
"code": "empty-block",
"message": "Empty block",
"loc": {
"start": {
"line": 5,
"column": 0
"column": 0,
"character": 34
},
"end": {
"line": 5,
"column": 30
"column": 30,
"character": 64
},
"pos": 34
}

8
test/validator/samples/event-handler-ref-invalid/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "missing-ref",
"message": "'refs.inputx' does not exist (did you mean 'refs.input'?)",
"pos": 36,
"loc": {
"start": {
"line": 2,
"column": 18
"column": 18,
"character": 36
},
"end": {
"line": 2,
"column": 35
"column": 35,
"character": 53
}
}]

8
test/validator/samples/export-default-duplicated/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "parse-error",
"message": "Duplicate export 'default'",
"pos": 37,
"loc": {
"start": {
"line": 3,
"column": 8
"column": 8,
"character": 37
},
"end": {
"line": 3,
"column": 8
"column": 8,
"character": 37
}
}]

8
test/validator/samples/export-default-must-be-object/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "invalid-default-export",
"message": "Default export must be an object literal",
"pos": 25,
"loc": {
"start": {
"line": 2,
"column": 16
"column": 16,
"character": 25
},
"end": {
"line": 2,
"column": 22
"column": 22,
"character": 31
}
}]

8
test/validator/samples/helper-clash-context/warnings.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "each-context-clash",
"message": "Context clashes with a helper. Rename one or the other to eliminate any ambiguity",
"loc": {
"start": {
"line": 1,
"column": 17
"column": 17,
"character": 17
},
"end": {
"line": 1,
"column": 22
"column": 22,
"character": 22
},
"pos": 17
}]

8
test/validator/samples/helper-purity-check-needs-arguments/warnings.json
Unescape View File

@ -2,12 +2,14 @@
"code": "impure-helper",
"message": "Helpers should be pure functions, with at least one argument",
"pos": 52,
"loc": {
"start": {
"line": 6,
"column": 3
"column": 3,
"character": 52
},
"end": {
"line": 8,
"column": 4
"column": 4,
"character": 91
}
}]

8
test/validator/samples/helper-purity-check-no-this/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "impure-helper",
"message": "Helpers should be pure functions — they do not have access to the component instance and cannot use 'this'. Did you mean to put this in 'methods'?",
"pos": 95,
"loc": {
"start": {
"line": 7,
"column": 4
"column": 4,
"character": 95
},
"end": {
"line": 7,
"column": 8
"column": 8,
"character": 99
}
}]

8
test/validator/samples/helper-purity-check-this-get/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "impure-helper",
"message": "Cannot use this.get(...) — values must be passed into the helper function as arguments",
"pos": 72,
"loc": {
"start": {
"line": 7,
"column": 11
"column": 11,
"character": 72
},
"end": {
"line": 7,
"column": 28
"column": 28,
"character": 89
}
}]

8
test/validator/samples/method-arrow-this/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "invalid-method-value",
"message": "Method 'foo' should be a function expression, not an arrow function expression",
"pos": 79,
"loc": {
"start": {
"line": 6,
"column": 3
"column": 3,
"character": 79
},
"end": {
"line": 8,
"column": 4
"column": 4,
"character": 120
}
}]

8
test/validator/samples/method-nonexistent-helper/warnings.json
Unescape View File

@ -2,12 +2,14 @@
"code": "invalid-callee",
"message": "'foo' is an invalid callee (should be one of this.*, event.*, options.*, console.*, store.*, set, fire, destroy or bar). 'foo' exists on 'helpers', did you put it in the wrong place?",
"pos": 18,
"loc": {
"start": {
"line": 1,
"column": 18
"column": 18,
"character": 18
},
"end": {
"line": 1,
"column": 23
"column": 23,
"character": 23
}
}]

8
test/validator/samples/method-nonexistent/warnings.json
Unescape View File

@ -2,12 +2,14 @@
"code": "invalid-callee",
"message": "'foo' is an invalid callee (should be one of this.*, event.*, options.*, console.*, store.*, set, fire, destroy or bar)",
"pos": 18,
"loc": {
"start": {
"line": 1,
"column": 18
"column": 18,
"character": 18
},
"end": {
"line": 1,
"column": 23
"column": 23,
"character": 23
}
}]

8
test/validator/samples/missing-component/errors.json
Unescape View File

@ -1,13 +1,15 @@
[{
"code": "missing-component",
"message": "Widget component is not defined",
"loc": {
"start": {
"line": 2,
"column": 1
"column": 1,
"character": 7
},
"end": {
"line": 2,
"column": 10
"column": 10,
"character": 16
},
"pos": 7
}]

8
test/validator/samples/named-export/errors.json
Unescape View File

@ -2,12 +2,14 @@
"code": "named-export",
"message": "A component can only have a default export",
"pos": 10,
"loc": {
"start": {
"line": 2,
"column": 1
"column": 1,
"character": 10
},
"end": {
"line": 2,
"column": 21
"column": 21,
"character": 30
}
}]

Some files were not shown because too many files have changed in this diff Show More

Write Preview
Loading…
Cancel
Save