From c73b9a00ea64bcf2565bc224fd6e3afc760cc0fc Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Thu, 22 Dec 2022 13:08:06 +0100
Subject: [PATCH 01/61] [fix] add submitter property to submit event

---
 elements/index.d.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/elements/index.d.ts b/elements/index.d.ts
index 2534bfaf40..4668d190f9 100644
--- a/elements/index.d.ts
+++ b/elements/index.d.ts
@@ -84,7 +84,7 @@ export interface DOMAttributes<T extends EventTarget> {
 	'on:beforeinput'?: EventHandler<InputEvent, T> | undefined | null;
 	'on:input'?: FormEventHandler<T> | undefined | null;
 	'on:reset'?: FormEventHandler<T> | undefined | null;
-	'on:submit'?: EventHandler<Event, T> | undefined | null; // TODO make this SubmitEvent once we require TS>=4.4
+	'on:submit'?: EventHandler<Event & { readonly submitter: HTMLElement | null; }, T> | undefined | null; // TODO make this SubmitEvent once we require TS>=4.4
 	'on:invalid'?: EventHandler<Event, T> | undefined | null;
 	'on:formdata'?: EventHandler<Event & { readonly formData: FormData; }, T> | undefined | null; // TODO make this FormDataEvent once we require TS>=4.4
 

From 786505d6bc52ce9ad072f1c44cacfeb4f3bd58ab Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Thu, 22 Dec 2022 13:13:31 +0100
Subject: [PATCH 02/61] update changelog

---
 CHANGELOG.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 190caaf6e1..fd4ff5f7ac 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Svelte changelog
 
+## 3.55.1 (unreleased)
+
+* add missing `submitter` property to `on:submit` event type
+
 ## 3.55.0
 
 * Add `svelte/elements` for HTML/Svelte typings ([#7649](https://github.com/sveltejs/svelte/pull/7649))

From b8f32c0b1a295fd56c7c04683402968f32f01597 Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Thu, 22 Dec 2022 17:47:52 +0100
Subject: [PATCH 03/61] [docs] clear timeout on destroy

backported from https://github.com/sveltejs/learn.svelte.dev/pull/166
---
 .../02-adding-parameters-to-actions/app-a/longpress.js           | 1 +
 .../02-adding-parameters-to-actions/app-b/longpress.js           | 1 +
 2 files changed, 2 insertions(+)

diff --git a/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-a/longpress.js b/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-a/longpress.js
index 00bb9d05c8..07235f21dc 100644
--- a/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-a/longpress.js
+++ b/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-a/longpress.js
@@ -18,6 +18,7 @@ export function longpress(node, duration) {
 
 	return {
 		destroy() {
+			clearTimeout(timer);
 			node.removeEventListener('mousedown', handleMousedown);
 			node.removeEventListener('mouseup', handleMouseup);
 		}
diff --git a/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-b/longpress.js b/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-b/longpress.js
index 9d807cb13a..4ce0dfe05b 100644
--- a/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-b/longpress.js
+++ b/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-b/longpress.js
@@ -21,6 +21,7 @@ export function longpress(node, duration) {
 			duration = newDuration;
 		},
 		destroy() {
+			clearTimeout(timer);
 			node.removeEventListener('mousedown', handleMousedown);
 			node.removeEventListener('mouseup', handleMouseup);
 		}

From de6821a1de6574b1aa987944fe9a5f0b5f7724bb Mon Sep 17 00:00:00 2001
From: Yuichiro Yamashita <xydybaseball@gmail.com>
Date: Sat, 31 Dec 2022 10:13:52 +0900
Subject: [PATCH 04/61] [ chore] disable puppeteer on Linux for Node8 and 10
 (#8155)

---
 .github/workflows/ci.yml        | 10 ++++++++++
 test/custom-elements/index.ts   |  3 +++
 test/runtime-puppeteer/index.ts |  3 +++
 3 files changed, 16 insertions(+)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index bd826cafca..e24f106477 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -59,6 +59,16 @@ jobs:
         id: download-artifact
         with:
           name: build-assets
+      - name: Get Node version ${{ runner.os }}
+        run: echo "NODE_VERSION=`node --version`" >> $GITHUB_ENV
+        if: runner.os != 'Windows'
+      - name: Get Node version ${{ runner.os }}
+        run: |
+          chcp 65001
+          echo ("NODE_VERSION=$(node --version)") >> $env:GITHUB_ENV
+        if: runner.os == 'Windows'
+      - run: npm install --save-dev puppeteer@13
+        if: ${{ runner.os == 'Linux' && (!startsWith(env.NODE_VERSION, 'v8.') && !startsWith(env.NODE_VERSION, 'v10.')) }}
       - run: npm install
         env:
           SKIP_PREPARE: true
diff --git a/test/custom-elements/index.ts b/test/custom-elements/index.ts
index 42b27eebd3..534199d035 100644
--- a/test/custom-elements/index.ts
+++ b/test/custom-elements/index.ts
@@ -64,6 +64,9 @@ describe('custom-elements', function() {
 
 	fs.readdirSync(`${__dirname}/samples`).forEach(dir => {
 		if (dir[0] === '.') return;
+		// MEMO: puppeteer can not execute Chromium properly with Node8,10 on Linux at GitHub actions.
+		const { version } = process;
+		if ((version.startsWith('v8.') || version.startsWith('v10.')) && process.platform === 'linux') return;
 
 		const solo = /\.solo$/.test(dir);
 		const skip = /\.skip$/.test(dir);
diff --git a/test/runtime-puppeteer/index.ts b/test/runtime-puppeteer/index.ts
index 62952ad9f7..eba60544f6 100644
--- a/test/runtime-puppeteer/index.ts
+++ b/test/runtime-puppeteer/index.ts
@@ -77,6 +77,9 @@ describe('runtime (puppeteer)', function() {
 
 	function runTest(dir, hydrate) {
 		if (dir[0] === '.') return;
+		// MEMO: puppeteer can not execute Chromium properly with Node8,10 on Linux at GitHub actions.
+		const { version } = process;
+		if ((version.startsWith('v8.') || version.startsWith('v10.')) && process.platform === 'linux') return;
 
 		const config = loadConfig(`${__dirname}/samples/${dir}/_config.js`);
 		const solo = config.solo || /\.solo/.test(dir);

From f84c00edb9aab75c939963332da57af0e82894f3 Mon Sep 17 00:00:00 2001
From: Ramon Snir <r@mon.dev>
Date: Sun, 1 Jan 2023 03:41:00 -0500
Subject: [PATCH 05/61] [fix] static svelte:element not replaced with tag in
 production mode (#7938)

* [fix] static svelte:element not replaced with tag in production mode

* [fix] static svelte:element not replaced with tag in production mode

* add optimization of static <svelte:element> and fix a bug

Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
---
 src/compiler/compile/nodes/Element.ts         |  1 +
 .../render_dom/wrappers/Element/index.ts      | 11 +++++----
 .../js/samples/svelte-element-svg/expected.js | 23 +++++++++++--------
 .../samples/svelte-element-svg/input.svelte   | 10 +++++---
 .../samples/static-svelte-element/_config.js  | 13 +++++++++++
 .../samples/static-svelte-element/main.svelte |  3 +++
 .../samples/static-svelte-element2/_config.js | 13 +++++++++++
 .../static-svelte-element2/main.svelte        |  7 ++++++
 8 files changed, 65 insertions(+), 16 deletions(-)
 create mode 100644 test/runtime/samples/static-svelte-element/_config.js
 create mode 100644 test/runtime/samples/static-svelte-element/main.svelte
 create mode 100644 test/runtime/samples/static-svelte-element2/_config.js
 create mode 100644 test/runtime/samples/static-svelte-element2/main.svelte

diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts
index a499d013e3..06ef1ba9c1 100644
--- a/src/compiler/compile/nodes/Element.ts
+++ b/src/compiler/compile/nodes/Element.ts
@@ -239,6 +239,7 @@ export default class Element extends Node {
 				this.tag_expr = new Expression(component, this, scope, info.tag);
 			} else {
 				this.tag_expr = new Expression(component, this, scope, string_literal(info.tag) as Literal);
+				this.name = info.tag;
 			}
 		} else {
 			this.tag_expr = new Expression(component, this, scope, string_literal(this.name) as Literal);
diff --git a/src/compiler/compile/render_dom/wrappers/Element/index.ts b/src/compiler/compile/render_dom/wrappers/Element/index.ts
index 8d0429879e..cef758b89e 100644
--- a/src/compiler/compile/render_dom/wrappers/Element/index.ts
+++ b/src/compiler/compile/render_dom/wrappers/Element/index.ts
@@ -255,6 +255,7 @@ export default class ElementWrapper extends Wrapper {
 				node.styles.length > 0 ||
 				this.node.name === 'option' ||
 				node.tag_expr.dynamic_dependencies().length ||
+				node.is_dynamic_element ||
 				renderer.options.dev
 			) {
 				this.parent.cannot_use_innerhtml(); // need to use add_location
@@ -1176,10 +1177,12 @@ function to_html(wrappers: Array<ElementWrapper | TextWrapper | MustacheTagWrapp
 		} else if (wrapper.node.name === 'noscript') {
 			// do nothing
 		} else {
+			const nodeName = wrapper.node.name;
+
 			// element
-			state.quasi.value.raw += `<${wrapper.node.name}`;
+			state.quasi.value.raw += `<${nodeName}`;
 
-			const is_empty_textarea = wrapper.node.name === 'textarea' && wrapper.fragment.nodes.length === 0;
+			const is_empty_textarea = nodeName === 'textarea' && wrapper.fragment.nodes.length === 0;
 
 			(wrapper as ElementWrapper).attributes.forEach((attr: AttributeWrapper) => {
 				if (is_empty_textarea && attr.node.name === 'value') {
@@ -1196,7 +1199,7 @@ function to_html(wrappers: Array<ElementWrapper | TextWrapper | MustacheTagWrapp
 			if (!wrapper.void) {
 				state.quasi.value.raw += '>';
 
-				if (wrapper.node.name === 'pre') {
+				if (nodeName === 'pre') {
 					// Two or more leading newlines are required to restore the leading newline immediately after `<pre>`.
 					// see https://html.spec.whatwg.org/multipage/grouping-content.html#the-pre-element
 					const first = wrapper.fragment.nodes[0];
@@ -1221,7 +1224,7 @@ function to_html(wrappers: Array<ElementWrapper | TextWrapper | MustacheTagWrapp
 
 				to_html(wrapper.fragment.nodes as Array<ElementWrapper | TextWrapper>, block, literal, state);
 
-				state.quasi.value.raw += `</${wrapper.node.name}>`;
+				state.quasi.value.raw += `</${nodeName}>`;
 			} else {
 				state.quasi.value.raw += '/>';
 			}
diff --git a/test/js/samples/svelte-element-svg/expected.js b/test/js/samples/svelte-element-svg/expected.js
index 36ce583ef1..263f6c842b 100644
--- a/test/js/samples/svelte-element-svg/expected.js
+++ b/test/js/samples/svelte-element-svg/expected.js
@@ -18,7 +18,7 @@ function create_dynamic_element_1(ctx) {
 	return { c: noop, m: noop, p: noop, d: noop };
 }
 
-// (1:0) <svelte:element this="svg" xmlns="http://www.w3.org/2000/svg">
+// (5:0) <svelte:element this={tag.svg} xmlns="http://www.w3.org/2000/svg">
 function create_dynamic_element(ctx) {
 	let svelte_element1;
 	let svelte_element0;
@@ -38,8 +38,8 @@ function create_dynamic_element(ctx) {
 
 	return {
 		c() {
-			svelte_element1 = svg_element("svg");
-			svelte_element0 = svg_element("path");
+			svelte_element1 = svg_element(/*tag*/ ctx[0].svg);
+			svelte_element0 = svg_element(/*tag*/ ctx[0].path);
 			set_svg_attributes(svelte_element0, svelte_element0_data);
 			set_svg_attributes(svelte_element1, svelte_element1_data);
 		},
@@ -60,9 +60,9 @@ function create_dynamic_element(ctx) {
 }
 
 function create_fragment(ctx) {
-	let previous_tag = "svg";
+	let previous_tag = /*tag*/ ctx[0].svg;
 	let svelte_element1_anchor;
-	let svelte_element1 = "svg" && create_dynamic_element(ctx);
+	let svelte_element1 = /*tag*/ ctx[0].svg && create_dynamic_element(ctx);
 
 	return {
 		c() {
@@ -74,12 +74,12 @@ function create_fragment(ctx) {
 			insert(target, svelte_element1_anchor, anchor);
 		},
 		p(ctx, [dirty]) {
-			if ("svg") {
+			if (/*tag*/ ctx[0].svg) {
 				if (!previous_tag) {
 					svelte_element1 = create_dynamic_element(ctx);
 					svelte_element1.c();
 					svelte_element1.m(svelte_element1_anchor.parentNode, svelte_element1_anchor);
-				} else if (safe_not_equal(previous_tag, "svg")) {
+				} else if (safe_not_equal(previous_tag, /*tag*/ ctx[0].svg)) {
 					svelte_element1.d(1);
 					svelte_element1 = create_dynamic_element(ctx);
 					svelte_element1.c();
@@ -92,7 +92,7 @@ function create_fragment(ctx) {
 				svelte_element1 = null;
 			}
 
-			previous_tag = "svg";
+			previous_tag = /*tag*/ ctx[0].svg;
 		},
 		i: noop,
 		o: noop,
@@ -103,10 +103,15 @@ function create_fragment(ctx) {
 	};
 }
 
+function instance($$self) {
+	const tag = { svg: 'svg', path: 'path' };
+	return [tag];
+}
+
 class Component extends SvelteComponent {
 	constructor(options) {
 		super();
-		init(this, options, null, create_fragment, safe_not_equal, {});
+		init(this, options, instance, create_fragment, safe_not_equal, {});
 	}
 }
 
diff --git a/test/js/samples/svelte-element-svg/input.svelte b/test/js/samples/svelte-element-svg/input.svelte
index 2dc4d54814..111c0183c6 100644
--- a/test/js/samples/svelte-element-svg/input.svelte
+++ b/test/js/samples/svelte-element-svg/input.svelte
@@ -1,3 +1,7 @@
-<svelte:element this="svg" xmlns="http://www.w3.org/2000/svg">
-    <svelte:element this="path" xmlns="http://www.w3.org/2000/svg"></svelte:element>
-</svelte:element>
\ No newline at end of file
+<script>
+	const tag = { svg: 'svg', path: 'path' };
+</script>
+
+<svelte:element this={tag.svg} xmlns="http://www.w3.org/2000/svg">
+	<svelte:element this={tag.path} xmlns="http://www.w3.org/2000/svg" />
+</svelte:element>
diff --git a/test/runtime/samples/static-svelte-element/_config.js b/test/runtime/samples/static-svelte-element/_config.js
new file mode 100644
index 0000000000..a26de61338
--- /dev/null
+++ b/test/runtime/samples/static-svelte-element/_config.js
@@ -0,0 +1,13 @@
+export default {
+	html: `
+		<div>
+			<p></p>
+		</div>
+	`,
+
+	test({ assert, target }) {
+		const p = target.querySelector('p');
+
+		assert.notEqual(p, undefined);
+	}
+};
diff --git a/test/runtime/samples/static-svelte-element/main.svelte b/test/runtime/samples/static-svelte-element/main.svelte
new file mode 100644
index 0000000000..3bdf853a5a
--- /dev/null
+++ b/test/runtime/samples/static-svelte-element/main.svelte
@@ -0,0 +1,3 @@
+<div>
+	<svelte:element this="p" />
+</div>
diff --git a/test/runtime/samples/static-svelte-element2/_config.js b/test/runtime/samples/static-svelte-element2/_config.js
new file mode 100644
index 0000000000..a26de61338
--- /dev/null
+++ b/test/runtime/samples/static-svelte-element2/_config.js
@@ -0,0 +1,13 @@
+export default {
+	html: `
+		<div>
+			<p></p>
+		</div>
+	`,
+
+	test({ assert, target }) {
+		const p = target.querySelector('p');
+
+		assert.notEqual(p, undefined);
+	}
+};
diff --git a/test/runtime/samples/static-svelte-element2/main.svelte b/test/runtime/samples/static-svelte-element2/main.svelte
new file mode 100644
index 0000000000..a723b955d4
--- /dev/null
+++ b/test/runtime/samples/static-svelte-element2/main.svelte
@@ -0,0 +1,7 @@
+<script>
+	const p = 'p';
+</script>
+
+<div>
+	<svelte:element this={p} />
+</div>

From 06648d1f65ff9a9fc8392dd5c49ab5753b20abce Mon Sep 17 00:00:00 2001
From: Tan Li Hau <tanhauhau@users.noreply.github.com>
Date: Sun, 1 Jan 2023 16:43:46 +0800
Subject: [PATCH 06/61] Update CHANGELOG.md

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index fd4ff5f7ac..aa0a2d4c52 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 3.55.1 (unreleased)
 
 * add missing `submitter` property to `on:submit` event type
+* Fix static `<svelte:element>` optimization in production mode ([#7938](https://github.com/sveltejs/svelte/pull/7938))
 
 ## 3.55.0
 

From 094483b397829d2c7633f7f6bc278e5ecfd0868a Mon Sep 17 00:00:00 2001
From: wackbyte <wackbyte@pm.me>
Date: Mon, 2 Jan 2023 01:39:55 +0000
Subject: [PATCH 07/61] [fix] say "nonnegative" instead of "positive" tabIndex
 for `a11y-no-noninteractive-tabindex` (#8126)

---
 site/content/docs/06-accessibility-warnings.md            | 2 +-
 src/compiler/compile/compiler_warnings.ts                 | 2 +-
 .../samples/a11y-no-nointeractive-tabindex/warnings.json  | 8 ++++----
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/site/content/docs/06-accessibility-warnings.md b/site/content/docs/06-accessibility-warnings.md
index 8be8eb888c..8d3d44a94e 100644
--- a/site/content/docs/06-accessibility-warnings.md
+++ b/site/content/docs/06-accessibility-warnings.md
@@ -268,7 +268,7 @@ Some HTML elements have default ARIA roles. Giving these elements an ARIA role t
 Tab key navigation should be limited to elements on the page that can be interacted with.
 
 ```sv
-<!-- A11y: noninteractive element cannot have positive tabIndex value -->
+<!-- A11y: noninteractive element cannot have nonnegative tabIndex value -->
 <div tabindex='0' />
 ```
 
diff --git a/src/compiler/compile/compiler_warnings.ts b/src/compiler/compile/compiler_warnings.ts
index bbc12617e9..3f552eb8b8 100644
--- a/src/compiler/compile/compiler_warnings.ts
+++ b/src/compiler/compile/compiler_warnings.ts
@@ -185,7 +185,7 @@ export default {
 	}),
 	a11y_no_noninteractive_tabindex: {
 		code: 'a11y-no-noninteractive-tabindex',
-		message: 'A11y: noninteractive element cannot have positive tabIndex value'
+		message: 'A11y: noninteractive element cannot have nonnegative tabIndex value'
 	},
 	redundant_event_modifier_for_touch: {
 		code: 'redundant-event-modifier',
diff --git a/test/validator/samples/a11y-no-nointeractive-tabindex/warnings.json b/test/validator/samples/a11y-no-nointeractive-tabindex/warnings.json
index b2c3ec4168..1c643c896b 100644
--- a/test/validator/samples/a11y-no-nointeractive-tabindex/warnings.json
+++ b/test/validator/samples/a11y-no-nointeractive-tabindex/warnings.json
@@ -6,7 +6,7 @@
 			"column": 20,
 			"line": 12
 		},
-		"message": "A11y: noninteractive element cannot have positive tabIndex value",
+		"message": "A11y: noninteractive element cannot have nonnegative tabIndex value",
 		"pos": 258,
 		"start": {
 			"character": 258,
@@ -21,7 +21,7 @@
 			"column": 35,
 			"line": 13
 		},
-		"message": "A11y: noninteractive element cannot have positive tabIndex value",
+		"message": "A11y: noninteractive element cannot have nonnegative tabIndex value",
 		"pos": 279,
 		"start": {
 			"character": 279,
@@ -36,7 +36,7 @@
 			"column": 24,
 			"line": 14
 		},
-		"message": "A11y: noninteractive element cannot have positive tabIndex value",
+		"message": "A11y: noninteractive element cannot have nonnegative tabIndex value",
 		"pos": 315,
 		"start": {
 			"character": 315,
@@ -51,7 +51,7 @@
 			"column": 26,
 			"line": 15
 		},
-		"message": "A11y: noninteractive element cannot have positive tabIndex value",
+		"message": "A11y: noninteractive element cannot have nonnegative tabIndex value",
 		"pos": 340,
 		"start": {
 			"character": 340,

From a5d6713c8edff97bdcc01b4dda13c16579294acf Mon Sep 17 00:00:00 2001
From: Gus Wezerek <gwezerek@gmail.com>
Date: Sun, 1 Jan 2023 19:18:52 -0700
Subject: [PATCH 08/61] Fix bug with transition draw when delay is passed
 (#8094)

Signed-off-by: Gus Wezerek <gustav.wezerek@nytimes.com>

Signed-off-by: Gus Wezerek <gustav.wezerek@nytimes.com>
Co-authored-by: Gus Wezerek <gustav.wezerek@nytimes.com>
---
 src/runtime/transition/index.ts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/runtime/transition/index.ts b/src/runtime/transition/index.ts
index 9315cd77d5..5940d054d3 100644
--- a/src/runtime/transition/index.ts
+++ b/src/runtime/transition/index.ts
@@ -198,7 +198,10 @@ export function draw(node: SVGElement & { getTotalLength(): number }, {
 		delay,
 		duration,
 		easing,
-		css: (t, u) => `stroke-dasharray: ${t * len} ${u * len}`
+		css: (t, u) => `
+			stroke-dasharray: ${len};
+			stroke-dashoffset: ${u * len};
+		`
 	};
 }
 

From 4f365f017174c3f9356c9987204e7f760aafcb13 Mon Sep 17 00:00:00 2001
From: Tan Li Hau <tanhauhau@users.noreply.github.com>
Date: Mon, 2 Jan 2023 10:20:38 +0800
Subject: [PATCH 09/61] Update CHANGELOG.md

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index aa0a2d4c52..30eef65b74 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 * add missing `submitter` property to `on:submit` event type
 * Fix static `<svelte:element>` optimization in production mode ([#7938](https://github.com/sveltejs/svelte/pull/7938))
+* Fix `draw` transition with delay showing a dot at the beginning of transition ([#6816](https://github.com/sveltejs/svelte/issues/6816))
 
 ## 3.55.0
 

From 1f021226c5df92e0685cce806918b8953e521a2a Mon Sep 17 00:00:00 2001
From: Ming07 <q502489978@live.com>
Date: Mon, 2 Jan 2023 10:23:35 +0800
Subject: [PATCH 10/61] [fix] named slots breaks svelte-ignore comments (#8105)

* [fix] Named slots breaks svelte-ignore comments

Fixes #8075

* test: add tests

* refactor

* refactor test

Co-authored-by: mojinming <mojinming@cmcm.com>
Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
---
 src/compiler/compile/nodes/InlineComponent.ts   |  2 ++
 .../samples/slot-warning-ignore/input.svelte    |  8 ++++++++
 .../samples/slot-warning-ignore/warnings.json   |  1 +
 .../validator/samples/slot-warning/input.svelte |  7 +++++++
 .../samples/slot-warning/warnings.json          | 17 +++++++++++++++++
 .../samples/slot-warning2/input.svelte          |  8 ++++++++
 .../samples/slot-warning2/warnings.json         | 17 +++++++++++++++++
 7 files changed, 60 insertions(+)
 create mode 100644 test/validator/samples/slot-warning-ignore/input.svelte
 create mode 100644 test/validator/samples/slot-warning-ignore/warnings.json
 create mode 100644 test/validator/samples/slot-warning/input.svelte
 create mode 100644 test/validator/samples/slot-warning/warnings.json
 create mode 100644 test/validator/samples/slot-warning2/input.svelte
 create mode 100644 test/validator/samples/slot-warning2/warnings.json

diff --git a/src/compiler/compile/nodes/InlineComponent.ts b/src/compiler/compile/nodes/InlineComponent.ts
index 26cfeb7ef9..e9ac86a55c 100644
--- a/src/compiler/compile/nodes/InlineComponent.ts
+++ b/src/compiler/compile/nodes/InlineComponent.ts
@@ -143,6 +143,8 @@ export default class InlineComponent extends Node {
 
 				children.push(slot_template);
 				info.children.splice(i, 1);
+			} else if (child.type === 'Comment' && children.length > 0) {
+				children[children.length - 1].children.unshift(child);
 			}
 		}
 
diff --git a/test/validator/samples/slot-warning-ignore/input.svelte b/test/validator/samples/slot-warning-ignore/input.svelte
new file mode 100644
index 0000000000..003b5bde63
--- /dev/null
+++ b/test/validator/samples/slot-warning-ignore/input.svelte
@@ -0,0 +1,8 @@
+<script>
+	import Component from './Component.svelte';
+</script>
+
+<Component>
+	<!-- svelte-ignore a11y-click-events-have-key-events -->
+	<div slot='foo' on:click>hi!</div>
+</Component>
diff --git a/test/validator/samples/slot-warning-ignore/warnings.json b/test/validator/samples/slot-warning-ignore/warnings.json
new file mode 100644
index 0000000000..fe51488c70
--- /dev/null
+++ b/test/validator/samples/slot-warning-ignore/warnings.json
@@ -0,0 +1 @@
+[]
diff --git a/test/validator/samples/slot-warning/input.svelte b/test/validator/samples/slot-warning/input.svelte
new file mode 100644
index 0000000000..3d60236edc
--- /dev/null
+++ b/test/validator/samples/slot-warning/input.svelte
@@ -0,0 +1,7 @@
+<script>
+	import Component from './Component.svelte';
+</script>
+
+<Component>
+	<div slot='foo' on:click>hi!</div>
+</Component>
diff --git a/test/validator/samples/slot-warning/warnings.json b/test/validator/samples/slot-warning/warnings.json
new file mode 100644
index 0000000000..14691b4231
--- /dev/null
+++ b/test/validator/samples/slot-warning/warnings.json
@@ -0,0 +1,17 @@
+[
+	{
+		"code": "a11y-click-events-have-key-events",
+		"message": "A11y: visible, non-interactive elements with an on:click event must be accompanied by an on:keydown, on:keyup, or on:keypress event.",
+		"start": {
+			"character": 78,
+			"column": 1,
+			"line": 6
+		},
+		"end": {
+			"character": 112,
+			"column": 35,
+			"line": 6
+		},
+		"pos": 78
+	}
+]
diff --git a/test/validator/samples/slot-warning2/input.svelte b/test/validator/samples/slot-warning2/input.svelte
new file mode 100644
index 0000000000..ab3c52d35d
--- /dev/null
+++ b/test/validator/samples/slot-warning2/input.svelte
@@ -0,0 +1,8 @@
+<script>
+	import Component from './Component.svelte';
+</script>
+
+<Component>
+	<!-- svelte-ignore unrelated-warning -->
+	<div slot='foo' on:click>hi!</div>
+</Component>
diff --git a/test/validator/samples/slot-warning2/warnings.json b/test/validator/samples/slot-warning2/warnings.json
new file mode 100644
index 0000000000..5554c3f764
--- /dev/null
+++ b/test/validator/samples/slot-warning2/warnings.json
@@ -0,0 +1,17 @@
+[
+	{
+		"code": "a11y-click-events-have-key-events",
+		"message": "A11y: visible, non-interactive elements with an on:click event must be accompanied by an on:keydown, on:keyup, or on:keypress event.",
+		"start": {
+			"character": 120,
+			"column": 1,
+			"line": 7
+		},
+		"end": {
+			"character": 154,
+			"column": 35,
+			"line": 7
+		},
+		"pos": 120
+	}
+]

From 14d09a085036858de93148d283e4096d3cd39e53 Mon Sep 17 00:00:00 2001
From: Tan Li Hau <tanhauhau@users.noreply.github.com>
Date: Mon, 2 Jan 2023 10:26:58 +0800
Subject: [PATCH 11/61] Update CHANGELOG.md

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 30eef65b74..f1e7b6b5b1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,7 @@
 * add missing `submitter` property to `on:submit` event type
 * Fix static `<svelte:element>` optimization in production mode ([#7938](https://github.com/sveltejs/svelte/pull/7938))
 * Fix `draw` transition with delay showing a dot at the beginning of transition ([#6816](https://github.com/sveltejs/svelte/issues/6816))
+* Fix `svelte-ignore` comment breaks named slot ([#8075](https://github.com/sveltejs/svelte/issues/8075))
 
 ## 3.55.0
 

From c9e98e6bbaed9b33df8087567235de9a54fdc537 Mon Sep 17 00:00:00 2001
From: Mathias Picker <48158184+MathiasWP@users.noreply.github.com>
Date: Mon, 2 Jan 2023 03:48:34 +0100
Subject: [PATCH 12/61] [fix]: remove double up initialization on
 svelte:element (#8142)

* fixed double up initialization on svelte:element elements

* updated test and fixed bug

* update other svelte:element test

* removed whitespace

* refactor

* correctly update expected ouput resulting from #7938

* remove .solo

Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
---
 .../render_dom/wrappers/Element/index.ts      |  39 ++--
 .../svelte-element-event-handlers/expected.js | 168 ++++++++++++++++++
 .../input.svelte                              |   3 +
 .../js/samples/svelte-element-svg/expected.js |  43 ++---
 4 files changed, 212 insertions(+), 41 deletions(-)
 create mode 100644 test/js/samples/svelte-element-event-handlers/expected.js
 create mode 100644 test/js/samples/svelte-element-event-handlers/input.svelte

diff --git a/src/compiler/compile/render_dom/wrappers/Element/index.ts b/src/compiler/compile/render_dom/wrappers/Element/index.ts
index cef758b89e..8a8f59810b 100644
--- a/src/compiler/compile/render_dom/wrappers/Element/index.ts
+++ b/src/compiler/compile/render_dom/wrappers/Element/index.ts
@@ -170,6 +170,15 @@ export default class ElementWrapper extends Wrapper {
 	) {
 		super(renderer, block, parent, node);
 
+		this.var = {
+			type: 'Identifier',
+			name: node.name.replace(regex_invalid_variable_identifier_characters, '_')
+		};
+
+		this.void = is_void(node.name);
+
+		this.class_dependencies = [];
+
 		if (node.is_dynamic_element && block.type !== CHILD_DYNAMIC_ELEMENT_BLOCK) {
 			this.child_dynamic_element_block = block.child({
 				comment: create_debugging_comment(node, renderer.component),
@@ -185,16 +194,13 @@ export default class ElementWrapper extends Wrapper {
 				strip_whitespace,
 				next_sibling
 			);
-		}
 
-		this.var = {
-			type: 'Identifier',
-			name: node.name.replace(regex_invalid_variable_identifier_characters, '_')
-		};
-
-		this.void = is_void(node.name);
-
-		this.class_dependencies = [];
+			// the original svelte:element is never used for rendering, because
+			// it gets assigned a child_dynamic_element which is used in all rendering logic.
+			// so doing all of this on the original svelte:element will just cause double
+			// code, because it will be done again on the child_dynamic_element.
+			return;
+		}
 
 		if (this.node.children.length) {
 			this.node.lets.forEach(l => {
@@ -327,20 +333,19 @@ export default class ElementWrapper extends Wrapper {
 					${this.var}.p(#ctx, #dirty);
 				}
 			} else if (${previous_tag}) {
-				${
-					has_transitions
-						? b`
+				${has_transitions
+				? b`
 							@group_outros();
 							@transition_out(${this.var}, 1, 1, () => {
 								${this.var} = null;
 							});
 							@check_outros();
 						`
-						: b`
+				: b`
 							${this.var}.d(1);
 							${this.var} = null;
 						`
-				}
+			}
 			}
 			${previous_tag} = ${tag};
 		`);
@@ -682,9 +687,9 @@ export default class ElementWrapper extends Wrapper {
 			function ${handler}(${params}) {
 				${binding_group.bindings.map(b => b.handler.mutation)}
 				${Array.from(dependencies)
-					.filter(dep => dep[0] !== '$')
-					.filter(dep => !contextual_dependencies.has(dep))
-					.map(dep => b`${this.renderer.invalidate(dep)};`)}
+				.filter(dep => dep[0] !== '$')
+				.filter(dep => !contextual_dependencies.has(dep))
+				.map(dep => b`${this.renderer.invalidate(dep)};`)}
 			}
 		`);
 
diff --git a/test/js/samples/svelte-element-event-handlers/expected.js b/test/js/samples/svelte-element-event-handlers/expected.js
new file mode 100644
index 0000000000..b9e648aadc
--- /dev/null
+++ b/test/js/samples/svelte-element-event-handlers/expected.js
@@ -0,0 +1,168 @@
+/* generated by Svelte vX.Y.Z */
+import {
+	SvelteComponent,
+	append,
+	assign,
+	bubble,
+	detach,
+	element,
+	empty,
+	get_spread_update,
+	init,
+	insert,
+	listen,
+	noop,
+	run_all,
+	safe_not_equal,
+	set_attributes,
+	set_custom_element_data_map
+} from "svelte/internal";
+
+function create_dynamic_element(ctx) {
+	let svelte_element1;
+	let svelte_element0;
+	let mounted;
+	let dispose;
+	let svelte_element0_levels = [{ class: "inner" }];
+	let svelte_element0_data = {};
+
+	for (let i = 0; i < svelte_element0_levels.length; i += 1) {
+		svelte_element0_data = assign(svelte_element0_data, svelte_element0_levels[i]);
+	}
+
+	let svelte_element1_levels = [{ class: "outer" }];
+	let svelte_element1_data = {};
+
+	for (let i = 0; i < svelte_element1_levels.length; i += 1) {
+		svelte_element1_data = assign(svelte_element1_data, svelte_element1_levels[i]);
+	}
+
+	return {
+		c() {
+			svelte_element1 = element("a");
+			svelte_element0 = element("span");
+
+			if ((/-/).test("span")) {
+				set_custom_element_data_map(svelte_element0, svelte_element0_data);
+			} else {
+				set_attributes(svelte_element0, svelte_element0_data);
+			}
+
+			if ((/-/).test("a")) {
+				set_custom_element_data_map(svelte_element1, svelte_element1_data);
+			} else {
+				set_attributes(svelte_element1, svelte_element1_data);
+			}
+		},
+		m(target, anchor) {
+			insert(target, svelte_element1, anchor);
+			append(svelte_element1, svelte_element0);
+
+			if (!mounted) {
+				dispose = [
+					listen(svelte_element0, "keydown", /*keydown_handler_1*/ ctx[2]),
+					listen(svelte_element0, "keyup", /*keyup_handler_1*/ ctx[3]),
+					listen(svelte_element1, "keydown", /*keydown_handler*/ ctx[0]),
+					listen(svelte_element1, "keyup", /*keyup_handler*/ ctx[1])
+				];
+
+				mounted = true;
+			}
+		},
+		p(ctx, dirty) {
+			svelte_element0_data = get_spread_update(svelte_element0_levels, [{ class: "inner" }]);
+
+			if ((/-/).test("span")) {
+				set_custom_element_data_map(svelte_element0, svelte_element0_data);
+			} else {
+				set_attributes(svelte_element0, svelte_element0_data);
+			}
+
+			svelte_element1_data = get_spread_update(svelte_element1_levels, [{ class: "outer" }]);
+
+			if ((/-/).test("a")) {
+				set_custom_element_data_map(svelte_element1, svelte_element1_data);
+			} else {
+				set_attributes(svelte_element1, svelte_element1_data);
+			}
+		},
+		d(detaching) {
+			if (detaching) detach(svelte_element1);
+			mounted = false;
+			run_all(dispose);
+		}
+	};
+}
+
+function create_fragment(ctx) {
+	let previous_tag = "a";
+	let svelte_element_anchor;
+	let svelte_element = "a" && create_dynamic_element(ctx);
+
+	return {
+		c() {
+			if (svelte_element) svelte_element.c();
+			svelte_element_anchor = empty();
+		},
+		m(target, anchor) {
+			if (svelte_element) svelte_element.m(target, anchor);
+			insert(target, svelte_element_anchor, anchor);
+		},
+		p(ctx, [dirty]) {
+			if ("a") {
+				if (!previous_tag) {
+					svelte_element = create_dynamic_element(ctx);
+					svelte_element.c();
+					svelte_element.m(svelte_element_anchor.parentNode, svelte_element_anchor);
+				} else if (safe_not_equal(previous_tag, "a")) {
+					svelte_element.d(1);
+					svelte_element = create_dynamic_element(ctx);
+					svelte_element.c();
+					svelte_element.m(svelte_element_anchor.parentNode, svelte_element_anchor);
+				} else {
+					svelte_element.p(ctx, dirty);
+				}
+			} else if (previous_tag) {
+				svelte_element.d(1);
+				svelte_element = null;
+			}
+
+			previous_tag = "a";
+		},
+		i: noop,
+		o: noop,
+		d(detaching) {
+			if (detaching) detach(svelte_element_anchor);
+			if (svelte_element) svelte_element.d(detaching);
+		}
+	};
+}
+
+function instance($$self) {
+	function keydown_handler(event) {
+		bubble.call(this, $$self, event);
+	}
+
+	function keyup_handler(event) {
+		bubble.call(this, $$self, event);
+	}
+
+	function keydown_handler_1(event) {
+		bubble.call(this, $$self, event);
+	}
+
+	function keyup_handler_1(event) {
+		bubble.call(this, $$self, event);
+	}
+
+	return [keydown_handler, keyup_handler, keydown_handler_1, keyup_handler_1];
+}
+
+class Component extends SvelteComponent {
+	constructor(options) {
+		super();
+		init(this, options, instance, create_fragment, safe_not_equal, {});
+	}
+}
+
+export default Component;
\ No newline at end of file
diff --git a/test/js/samples/svelte-element-event-handlers/input.svelte b/test/js/samples/svelte-element-event-handlers/input.svelte
new file mode 100644
index 0000000000..bb0b7b57a9
--- /dev/null
+++ b/test/js/samples/svelte-element-event-handlers/input.svelte
@@ -0,0 +1,3 @@
+<svelte:element class="outer" this="a" on:keydown on:keyup>
+    <svelte:element class="inner" this="span" on:keydown on:keyup></svelte:element>
+</svelte:element>
\ No newline at end of file
diff --git a/test/js/samples/svelte-element-svg/expected.js b/test/js/samples/svelte-element-svg/expected.js
index 263f6c842b..7db210219b 100644
--- a/test/js/samples/svelte-element-svg/expected.js
+++ b/test/js/samples/svelte-element-svg/expected.js
@@ -14,11 +14,6 @@ import {
 	svg_element
 } from "svelte/internal";
 
-function create_dynamic_element_1(ctx) {
-	return { c: noop, m: noop, p: noop, d: noop };
-}
-
-// (5:0) <svelte:element this={tag.svg} xmlns="http://www.w3.org/2000/svg">
 function create_dynamic_element(ctx) {
 	let svelte_element1;
 	let svelte_element0;
@@ -61,35 +56,35 @@ function create_dynamic_element(ctx) {
 
 function create_fragment(ctx) {
 	let previous_tag = /*tag*/ ctx[0].svg;
-	let svelte_element1_anchor;
-	let svelte_element1 = /*tag*/ ctx[0].svg && create_dynamic_element(ctx);
+	let svelte_element_anchor;
+	let svelte_element = /*tag*/ ctx[0].svg && create_dynamic_element(ctx);
 
 	return {
 		c() {
-			if (svelte_element1) svelte_element1.c();
-			svelte_element1_anchor = empty();
+			if (svelte_element) svelte_element.c();
+			svelte_element_anchor = empty();
 		},
 		m(target, anchor) {
-			if (svelte_element1) svelte_element1.m(target, anchor);
-			insert(target, svelte_element1_anchor, anchor);
+			if (svelte_element) svelte_element.m(target, anchor);
+			insert(target, svelte_element_anchor, anchor);
 		},
 		p(ctx, [dirty]) {
 			if (/*tag*/ ctx[0].svg) {
 				if (!previous_tag) {
-					svelte_element1 = create_dynamic_element(ctx);
-					svelte_element1.c();
-					svelte_element1.m(svelte_element1_anchor.parentNode, svelte_element1_anchor);
+					svelte_element = create_dynamic_element(ctx);
+					svelte_element.c();
+					svelte_element.m(svelte_element_anchor.parentNode, svelte_element_anchor);
 				} else if (safe_not_equal(previous_tag, /*tag*/ ctx[0].svg)) {
-					svelte_element1.d(1);
-					svelte_element1 = create_dynamic_element(ctx);
-					svelte_element1.c();
-					svelte_element1.m(svelte_element1_anchor.parentNode, svelte_element1_anchor);
+					svelte_element.d(1);
+					svelte_element = create_dynamic_element(ctx);
+					svelte_element.c();
+					svelte_element.m(svelte_element_anchor.parentNode, svelte_element_anchor);
 				} else {
-					svelte_element1.p(ctx, dirty);
+					svelte_element.p(ctx, dirty);
 				}
 			} else if (previous_tag) {
-				svelte_element1.d(1);
-				svelte_element1 = null;
+				svelte_element.d(1);
+				svelte_element = null;
 			}
 
 			previous_tag = /*tag*/ ctx[0].svg;
@@ -97,8 +92,8 @@ function create_fragment(ctx) {
 		i: noop,
 		o: noop,
 		d(detaching) {
-			if (detaching) detach(svelte_element1_anchor);
-			if (svelte_element1) svelte_element1.d(detaching);
+			if (detaching) detach(svelte_element_anchor);
+			if (svelte_element) svelte_element.d(detaching);
 		}
 	};
 }
@@ -115,4 +110,4 @@ class Component extends SvelteComponent {
 	}
 }
 
-export default Component;
+export default Component;
\ No newline at end of file

From 1d658e75012a361de6f6ae841995d423fb8d4e30 Mon Sep 17 00:00:00 2001
From: Tan Li Hau <tanhauhau@users.noreply.github.com>
Date: Mon, 2 Jan 2023 10:51:01 +0800
Subject: [PATCH 13/61] Update CHANGELOG.md

---
 CHANGELOG.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f1e7b6b5b1..4dc3e9390d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,8 @@
 * Fix static `<svelte:element>` optimization in production mode ([#7938](https://github.com/sveltejs/svelte/pull/7938))
 * Fix `draw` transition with delay showing a dot at the beginning of transition ([#6816](https://github.com/sveltejs/svelte/issues/6816))
 * Fix `svelte-ignore` comment breaks named slot ([#8075](https://github.com/sveltejs/svelte/issues/8075))
+* Fix duplicate event listeners for `<svelte:element on:event>` ([#8129](https://github.com/sveltejs/svelte/issues/8129))
+
 
 ## 3.55.0
 

From 762d0429b1fd2c3743fe7836108b3c1c557db750 Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Mon, 2 Jan 2023 06:51:01 +0100
Subject: [PATCH 14/61] [fix] propagate bindings correctly (#8114)

Fixes #8103 introduced through #7981
Keeps the infinite loop from happening but reopens #6298 and #5689
---
 .../wrappers/InlineComponent/index.ts         |  2 +-
 src/runtime/internal/Component.ts             |  6 ++---
 src/runtime/internal/scheduler.ts             | 25 +++++++++++++++----
 .../binding-indirect-value/Component.svelte   |  6 +++++
 .../_config.js                                |  3 ++-
 .../binding-indirect-value/main.svelte        |  8 ++++++
 .../Tab.svelte                                |  0
 .../_config.js                                | 10 ++++++++
 .../main.svelte                               |  0
 9 files changed, 49 insertions(+), 11 deletions(-)
 create mode 100644 test/runtime/samples/binding-indirect-value/Component.svelte
 rename test/runtime/samples/{binding-no-unnecessary-invalidation => binding-indirect-value}/_config.js (62%)
 create mode 100644 test/runtime/samples/binding-indirect-value/main.svelte
 rename test/runtime/samples/{binding-no-unnecessary-invalidation => binding-no-unnecessary-invalidation.skip}/Tab.svelte (100%)
 create mode 100644 test/runtime/samples/binding-no-unnecessary-invalidation.skip/_config.js
 rename test/runtime/samples/{binding-no-unnecessary-invalidation => binding-no-unnecessary-invalidation.skip}/main.svelte (100%)

diff --git a/src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts b/src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts
index f7875dc1b0..bca01fdb4c 100644
--- a/src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts
+++ b/src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts
@@ -393,7 +393,7 @@ export default class InlineComponentWrapper extends Wrapper {
 
 			component.partly_hoisted.push(body);
 
-			return b`@binding_callbacks.push(() => @bind(${this.var}, '${binding.name}', ${id}, ${snippet}));`;
+			return b`@binding_callbacks.push(() => @bind(${this.var}, '${binding.name}', ${id}));`;
 		});
 
 		const munged_handlers = this.node.handlers.map(handler => {
diff --git a/src/runtime/internal/Component.ts b/src/runtime/internal/Component.ts
index eedf8dd1ad..5aec24c651 100644
--- a/src/runtime/internal/Component.ts
+++ b/src/runtime/internal/Component.ts
@@ -5,13 +5,11 @@ import { children, detach, start_hydrating, end_hydrating } from './dom';
 import { transition_in } from './transitions';
 import { T$$ } from './types';
 
-export function bind(component, name, callback, value) {
+export function bind(component, name, callback) {
 	const index = component.$$.props[name];
 	if (index !== undefined) {
 		component.$$.bound[index] = callback;
-		if (value === undefined) {
-			callback(component.$$.ctx[index]);
-		}
+		callback(component.$$.ctx[index]);
 	}
 }
 
diff --git a/src/runtime/internal/scheduler.ts b/src/runtime/internal/scheduler.ts
index c0b8e57b08..f95ba446f5 100644
--- a/src/runtime/internal/scheduler.ts
+++ b/src/runtime/internal/scheduler.ts
@@ -52,17 +52,32 @@ export function add_flush_callback(fn) {
 const seen_callbacks = new Set();
 let flushidx = 0;  // Do *not* move this inside the flush() function
 export function flush() {
+	// Do not reenter flush while dirty components are updated, as this can
+	// result in an infinite loop. Instead, let the inner flush handle it.
+	// Reentrancy is ok afterwards for bindings etc.
+	if (flushidx !== 0) {
+		return;
+	}
+
 	const saved_component = current_component;
 
 	do {
 		// first, call beforeUpdate functions
 		// and update components
-		while (flushidx < dirty_components.length) {
-			const component = dirty_components[flushidx];
-			flushidx++;
-			set_current_component(component);
-			update(component.$$);
+		try {
+			while (flushidx < dirty_components.length) {
+				const component = dirty_components[flushidx];
+				flushidx++;
+				set_current_component(component);
+				update(component.$$);
+			}
+		} catch (e) {
+			// reset dirty state to not end up in a deadlocked state and then rethrow
+			dirty_components.length = 0;
+			flushidx = 0;
+			throw e;
 		}
+
 		set_current_component(null);
 
 		dirty_components.length = 0;
diff --git a/test/runtime/samples/binding-indirect-value/Component.svelte b/test/runtime/samples/binding-indirect-value/Component.svelte
new file mode 100644
index 0000000000..25bf0d6758
--- /dev/null
+++ b/test/runtime/samples/binding-indirect-value/Component.svelte
@@ -0,0 +1,6 @@
+<script>
+	export let value;
+	value = "bar";
+</script>
+
+Child component "{value}"<br />
diff --git a/test/runtime/samples/binding-no-unnecessary-invalidation/_config.js b/test/runtime/samples/binding-indirect-value/_config.js
similarity index 62%
rename from test/runtime/samples/binding-no-unnecessary-invalidation/_config.js
rename to test/runtime/samples/binding-indirect-value/_config.js
index a34cf0121f..4eaf6839aa 100644
--- a/test/runtime/samples/binding-no-unnecessary-invalidation/_config.js
+++ b/test/runtime/samples/binding-indirect-value/_config.js
@@ -1,7 +1,8 @@
 export default {
 	async test({ assert, target }) {
 		assert.htmlEqual(target.innerHTML, `
-			<p>0</p>
+		Parent component "bar"<br />
+		Child component "bar"<br />
 		`);
 	}
 };
diff --git a/test/runtime/samples/binding-indirect-value/main.svelte b/test/runtime/samples/binding-indirect-value/main.svelte
new file mode 100644
index 0000000000..db2734c890
--- /dev/null
+++ b/test/runtime/samples/binding-indirect-value/main.svelte
@@ -0,0 +1,8 @@
+<script>
+	import Component from "./Component.svelte";
+
+	let value = "foo";
+</script>
+
+Parent component "{value}"<br />
+<Component bind:value />
diff --git a/test/runtime/samples/binding-no-unnecessary-invalidation/Tab.svelte b/test/runtime/samples/binding-no-unnecessary-invalidation.skip/Tab.svelte
similarity index 100%
rename from test/runtime/samples/binding-no-unnecessary-invalidation/Tab.svelte
rename to test/runtime/samples/binding-no-unnecessary-invalidation.skip/Tab.svelte
diff --git a/test/runtime/samples/binding-no-unnecessary-invalidation.skip/_config.js b/test/runtime/samples/binding-no-unnecessary-invalidation.skip/_config.js
new file mode 100644
index 0000000000..d7e553fd46
--- /dev/null
+++ b/test/runtime/samples/binding-no-unnecessary-invalidation.skip/_config.js
@@ -0,0 +1,10 @@
+// this test currently fails because the fix that made it pass broke other tests,
+// see https://github.com/sveltejs/svelte/pull/8114 for more context.
+export default {
+	skip: true,
+	async test({ assert, target }) {
+		assert.htmlEqual(target.innerHTML, `
+			<p>0</p>
+		`);
+	}
+};
diff --git a/test/runtime/samples/binding-no-unnecessary-invalidation/main.svelte b/test/runtime/samples/binding-no-unnecessary-invalidation.skip/main.svelte
similarity index 100%
rename from test/runtime/samples/binding-no-unnecessary-invalidation/main.svelte
rename to test/runtime/samples/binding-no-unnecessary-invalidation.skip/main.svelte

From 26c0d3f17d067fa5eab6e980dbeda5733b8998dd Mon Sep 17 00:00:00 2001
From: Yuichiro Yamashita <xydybaseball@gmail.com>
Date: Mon, 2 Jan 2023 15:47:14 +0900
Subject: [PATCH 15/61] Update CHANGELOG.md

---
 CHANGELOG.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4dc3e9390d..7f6127ad87 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,7 +7,8 @@
 * Fix `draw` transition with delay showing a dot at the beginning of transition ([#6816](https://github.com/sveltejs/svelte/issues/6816))
 * Fix `svelte-ignore` comment breaks named slot ([#8075](https://github.com/sveltejs/svelte/issues/8075))
 * Fix duplicate event listeners for `<svelte:element on:event>` ([#8129](https://github.com/sveltejs/svelte/issues/8129))
-
+* Fix max call stack exceeded ([#7032](https://github.com/sveltejs/svelte/issues/7032))
+* Revert to prevent running init binding unnecessarily ([#8103](https://github.com/sveltejs/svelte/issues/8103))
 
 ## 3.55.0
 

From e1a1c7fa87aca46d5cf5ac68596df01631da585d Mon Sep 17 00:00:00 2001
From: Yuichiro Yamashita <xydybaseball@gmail.com>
Date: Mon, 2 Jan 2023 15:55:14 +0900
Subject: [PATCH 16/61] [chore] Fix CI (#8160)

* ci build

* fix test

* add test for #7938
---
 generate-type-definitions.js                  |  8 +++-
 src/runtime/transition/index.ts               |  2 +-
 .../svelte-element-event-handlers/expected.js | 25 ++++++-----
 .../input.svelte                              | 11 +++--
 .../samples/svelte-element-static/expected.js | 41 +++++++++++++++++++
 .../svelte-element-static/input.svelte        |  3 ++
 6 files changed, 73 insertions(+), 17 deletions(-)
 create mode 100644 test/js/samples/svelte-element-static/expected.js
 create mode 100644 test/js/samples/svelte-element-static/input.svelte

diff --git a/generate-type-definitions.js b/generate-type-definitions.js
index d8f6e9f826..6ec2f313c3 100644
--- a/generate-type-definitions.js
+++ b/generate-type-definitions.js
@@ -3,8 +3,12 @@
 const { execSync } = require('child_process');
 const { readFileSync, writeFileSync } = require('fs');
 
-execSync('tsc -p src/compiler --emitDeclarationOnly && tsc -p src/runtime --emitDeclarationOnly');
-
+try {
+	execSync('tsc -p src/compiler --emitDeclarationOnly && tsc -p src/runtime --emitDeclarationOnly');
+} catch (err) {
+	console.error(err.stderr.toString());
+	throw err;
+}
 // We need to add these types to the .d.ts files here because if we add them before building, the build will fail,
 // because the TS->JS transformation doesn't know these exports are types and produces code that fails at runtime.
 // We can't use `export type` syntax either because the TS version we're on doesn't have this feature yet.
diff --git a/src/runtime/transition/index.ts b/src/runtime/transition/index.ts
index 5940d054d3..c6d9dbc97a 100644
--- a/src/runtime/transition/index.ts
+++ b/src/runtime/transition/index.ts
@@ -198,7 +198,7 @@ export function draw(node: SVGElement & { getTotalLength(): number }, {
 		delay,
 		duration,
 		easing,
-		css: (t, u) => `
+		css: (_, u) => `
 			stroke-dasharray: ${len};
 			stroke-dashoffset: ${u * len};
 		`
diff --git a/test/js/samples/svelte-element-event-handlers/expected.js b/test/js/samples/svelte-element-event-handlers/expected.js
index b9e648aadc..ab24f2e924 100644
--- a/test/js/samples/svelte-element-event-handlers/expected.js
+++ b/test/js/samples/svelte-element-event-handlers/expected.js
@@ -39,16 +39,16 @@ function create_dynamic_element(ctx) {
 
 	return {
 		c() {
-			svelte_element1 = element("a");
-			svelte_element0 = element("span");
+			svelte_element1 = element(a);
+			svelte_element0 = element(span);
 
-			if ((/-/).test("span")) {
+			if ((/-/).test(span)) {
 				set_custom_element_data_map(svelte_element0, svelte_element0_data);
 			} else {
 				set_attributes(svelte_element0, svelte_element0_data);
 			}
 
-			if ((/-/).test("a")) {
+			if ((/-/).test(a)) {
 				set_custom_element_data_map(svelte_element1, svelte_element1_data);
 			} else {
 				set_attributes(svelte_element1, svelte_element1_data);
@@ -72,7 +72,7 @@ function create_dynamic_element(ctx) {
 		p(ctx, dirty) {
 			svelte_element0_data = get_spread_update(svelte_element0_levels, [{ class: "inner" }]);
 
-			if ((/-/).test("span")) {
+			if ((/-/).test(span)) {
 				set_custom_element_data_map(svelte_element0, svelte_element0_data);
 			} else {
 				set_attributes(svelte_element0, svelte_element0_data);
@@ -80,7 +80,7 @@ function create_dynamic_element(ctx) {
 
 			svelte_element1_data = get_spread_update(svelte_element1_levels, [{ class: "outer" }]);
 
-			if ((/-/).test("a")) {
+			if ((/-/).test(a)) {
 				set_custom_element_data_map(svelte_element1, svelte_element1_data);
 			} else {
 				set_attributes(svelte_element1, svelte_element1_data);
@@ -95,9 +95,9 @@ function create_dynamic_element(ctx) {
 }
 
 function create_fragment(ctx) {
-	let previous_tag = "a";
+	let previous_tag = a;
 	let svelte_element_anchor;
-	let svelte_element = "a" && create_dynamic_element(ctx);
+	let svelte_element = a && create_dynamic_element(ctx);
 
 	return {
 		c() {
@@ -109,12 +109,12 @@ function create_fragment(ctx) {
 			insert(target, svelte_element_anchor, anchor);
 		},
 		p(ctx, [dirty]) {
-			if ("a") {
+			if (a) {
 				if (!previous_tag) {
 					svelte_element = create_dynamic_element(ctx);
 					svelte_element.c();
 					svelte_element.m(svelte_element_anchor.parentNode, svelte_element_anchor);
-				} else if (safe_not_equal(previous_tag, "a")) {
+				} else if (safe_not_equal(previous_tag, a)) {
 					svelte_element.d(1);
 					svelte_element = create_dynamic_element(ctx);
 					svelte_element.c();
@@ -127,7 +127,7 @@ function create_fragment(ctx) {
 				svelte_element = null;
 			}
 
-			previous_tag = "a";
+			previous_tag = a;
 		},
 		i: noop,
 		o: noop,
@@ -138,6 +138,9 @@ function create_fragment(ctx) {
 	};
 }
 
+const a = 'a';
+const span = 'span';
+
 function instance($$self) {
 	function keydown_handler(event) {
 		bubble.call(this, $$self, event);
diff --git a/test/js/samples/svelte-element-event-handlers/input.svelte b/test/js/samples/svelte-element-event-handlers/input.svelte
index bb0b7b57a9..3a7b0f9800 100644
--- a/test/js/samples/svelte-element-event-handlers/input.svelte
+++ b/test/js/samples/svelte-element-event-handlers/input.svelte
@@ -1,3 +1,8 @@
-<svelte:element class="outer" this="a" on:keydown on:keyup>
-    <svelte:element class="inner" this="span" on:keydown on:keyup></svelte:element>
-</svelte:element>
\ No newline at end of file
+<script>
+	const a = 'a';
+	const span = 'span';
+</script>
+
+<svelte:element this={a} class='outer' on:keydown on:keyup>
+	<svelte:element this={span} class='inner' on:keydown on:keyup />
+</svelte:element>
diff --git a/test/js/samples/svelte-element-static/expected.js b/test/js/samples/svelte-element-static/expected.js
new file mode 100644
index 0000000000..68d895db3c
--- /dev/null
+++ b/test/js/samples/svelte-element-static/expected.js
@@ -0,0 +1,41 @@
+/* generated by Svelte vX.Y.Z */
+import {
+	SvelteComponent,
+	attr,
+	detach,
+	element,
+	init,
+	insert,
+	noop,
+	safe_not_equal
+} from "svelte/internal";
+
+function create_fragment(ctx) {
+	let a;
+
+	return {
+		c() {
+			a = element("a");
+			a.innerHTML = `<span class="inner"></span>`;
+			attr(a, "class", "outer");
+		},
+		m(target, anchor) {
+			insert(target, a, anchor);
+		},
+		p: noop,
+		i: noop,
+		o: noop,
+		d(detaching) {
+			if (detaching) detach(a);
+		}
+	};
+}
+
+class Component extends SvelteComponent {
+	constructor(options) {
+		super();
+		init(this, options, null, create_fragment, safe_not_equal, {});
+	}
+}
+
+export default Component;
\ No newline at end of file
diff --git a/test/js/samples/svelte-element-static/input.svelte b/test/js/samples/svelte-element-static/input.svelte
new file mode 100644
index 0000000000..4893d49847
--- /dev/null
+++ b/test/js/samples/svelte-element-static/input.svelte
@@ -0,0 +1,3 @@
+<svelte:element this='a' class='outer'>
+	<svelte:element this='span' class='inner' />
+</svelte:element>

From 4b84c4df3a8c07f0a992e255350eb97db36c5cf6 Mon Sep 17 00:00:00 2001
From: Yuichiro Yamashita <xydybaseball@gmail.com>
Date: Tue, 3 Jan 2023 12:48:06 +0900
Subject: [PATCH 17/61] [fix] Improve `is_promise` handling (#8162)

* correctly handle promises that are of function type

* add License

Co-authored-by: Vilsol <me@vil.so>
---
 src/runtime/internal/utils.ts                 |  4 +++-
 .../samples/await-function-promise/_config.js | 19 +++++++++++++++++++
 .../await-function-promise/main.svelte        |  7 +++++++
 3 files changed, 29 insertions(+), 1 deletion(-)
 create mode 100644 test/runtime/samples/await-function-promise/_config.js
 create mode 100644 test/runtime/samples/await-function-promise/main.svelte

diff --git a/src/runtime/internal/utils.ts b/src/runtime/internal/utils.ts
index 8868e38ee2..8adb0c279b 100644
--- a/src/runtime/internal/utils.ts
+++ b/src/runtime/internal/utils.ts
@@ -10,8 +10,10 @@ export function assign<T, S>(tar: T, src: S): T & S {
 	return tar as T & S;
 }
 
+// Adapted from https://github.com/then/is-promise/blob/master/index.js
+// Distributed under MIT License https://github.com/then/is-promise/blob/master/LICENSE
 export function is_promise<T = any>(value: any): value is PromiseLike<T> {
-	return value && typeof value === 'object' && typeof value.then === 'function';
+	return !!value && (typeof value === 'object' || typeof value === 'function') && typeof value.then === 'function';
 }
 
 export function add_location(element, file, line, column, char) {
diff --git a/test/runtime/samples/await-function-promise/_config.js b/test/runtime/samples/await-function-promise/_config.js
new file mode 100644
index 0000000000..b6a9de6856
--- /dev/null
+++ b/test/runtime/samples/await-function-promise/_config.js
@@ -0,0 +1,19 @@
+const realPromise = Promise.resolve(42);
+
+const promise = () => {};
+promise.then = realPromise.then.bind(realPromise);
+promise.catch = realPromise.catch.bind(realPromise);
+
+export default {
+	props: {
+		promise
+	},
+
+	test({ assert, target }) {
+		return promise.then(() => {
+			assert.htmlEqual(target.innerHTML, `
+				<p>42</p>
+			`);
+		});
+	}
+};
diff --git a/test/runtime/samples/await-function-promise/main.svelte b/test/runtime/samples/await-function-promise/main.svelte
new file mode 100644
index 0000000000..aaefc6b782
--- /dev/null
+++ b/test/runtime/samples/await-function-promise/main.svelte
@@ -0,0 +1,7 @@
+<script>
+	export let promise;
+</script>
+
+{#await promise then value}
+	<p>{JSON.stringify(value)}</p>
+{/await}

From dd11917fe523a66d8f5d66aab8cbcf965f30f25f Mon Sep 17 00:00:00 2001
From: Yuichiro Yamashita <xydybaseball@gmail.com>
Date: Tue, 3 Jan 2023 12:49:02 +0900
Subject: [PATCH 18/61] Update CHANGELOG.md

---
 CHANGELOG.md | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7f6127ad87..2c071d874f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,14 +1,15 @@
 # Svelte changelog
 
-## 3.55.1 (unreleased)
+## Unreleased
 
-* add missing `submitter` property to `on:submit` event type
+* Add missing `submitter` property to `on:submit` event type
 * Fix static `<svelte:element>` optimization in production mode ([#7938](https://github.com/sveltejs/svelte/pull/7938))
 * Fix `draw` transition with delay showing a dot at the beginning of transition ([#6816](https://github.com/sveltejs/svelte/issues/6816))
 * Fix `svelte-ignore` comment breaks named slot ([#8075](https://github.com/sveltejs/svelte/issues/8075))
 * Fix duplicate event listeners for `<svelte:element on:event>` ([#8129](https://github.com/sveltejs/svelte/issues/8129))
 * Fix max call stack exceeded ([#7032](https://github.com/sveltejs/svelte/issues/7032))
 * Revert to prevent running init binding unnecessarily ([#8103](https://github.com/sveltejs/svelte/issues/8103))
+* Improve `is_promise` logic ([#8162](https://github.com/sveltejs/svelte/pull/8162))
 
 ## 3.55.0
 

From 1f8e53a37ff8dba1d8001709e9ac809dca07f73a Mon Sep 17 00:00:00 2001
From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon, 9 Jan 2023 08:35:13 -0800
Subject: [PATCH 19/61] Bump json5 from 1.0.1 to 1.0.2 (#8175)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
---
 package-lock.json | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index eeef42a72c..70fac43f0e 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -3410,9 +3410,9 @@
       "dev": true
     },
     "node_modules/json5": {
-      "version": "1.0.1",
-      "resolved": "https://registry.npmjs.org/json5/-/json5-1.0.1.tgz",
-      "integrity": "sha512-aKS4WQjPenRxiQsC93MNfjx+nbF4PAdYzmd/1JIj8HYzqfbu86beTuNgXDzPknWk0n0uARlyewZo4s++ES36Ow==",
+      "version": "1.0.2",
+      "resolved": "https://registry.npmjs.org/json5/-/json5-1.0.2.tgz",
+      "integrity": "sha512-g1MWMLBiz8FKi1e4w0UyVL3w+iJceWAFBAaBnnGKOpNa5f8TLktkbre1+s6oICydWAm+HRUGTmI+//xv2hvXYA==",
       "dev": true,
       "dependencies": {
         "minimist": "^1.2.0"
@@ -7854,9 +7854,9 @@
       "dev": true
     },
     "json5": {
-      "version": "1.0.1",
-      "resolved": "https://registry.npmjs.org/json5/-/json5-1.0.1.tgz",
-      "integrity": "sha512-aKS4WQjPenRxiQsC93MNfjx+nbF4PAdYzmd/1JIj8HYzqfbu86beTuNgXDzPknWk0n0uARlyewZo4s++ES36Ow==",
+      "version": "1.0.2",
+      "resolved": "https://registry.npmjs.org/json5/-/json5-1.0.2.tgz",
+      "integrity": "sha512-g1MWMLBiz8FKi1e4w0UyVL3w+iJceWAFBAaBnnGKOpNa5f8TLktkbre1+s6oICydWAm+HRUGTmI+//xv2hvXYA==",
       "dev": true,
       "requires": {
         "minimist": "^1.2.0"

From f0dcf1416ccf3dbc53d0684df16ed4f79917b103 Mon Sep 17 00:00:00 2001
From: cunzaizhuyi <877824709@qq.com>
Date: Tue, 10 Jan 2023 00:37:28 +0800
Subject: [PATCH 20/61] [chore] shorten import statement (#8178)

---
 src/compiler/compile/render_dom/wrappers/RawMustacheTag.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/compile/render_dom/wrappers/RawMustacheTag.ts b/src/compiler/compile/render_dom/wrappers/RawMustacheTag.ts
index 8dc8460e1d..6cd8820b87 100644
--- a/src/compiler/compile/render_dom/wrappers/RawMustacheTag.ts
+++ b/src/compiler/compile/render_dom/wrappers/RawMustacheTag.ts
@@ -1,4 +1,4 @@
-import { namespaces } from './../../../utils/namespaces';
+import { namespaces } from '../../../utils/namespaces';
 import { b, x } from 'code-red';
 import Renderer from '../Renderer';
 import Block from '../Block';

From 7e6acbece31fbd68e2c07e37f3c849c405eb6983 Mon Sep 17 00:00:00 2001
From: Chris Reade <christopher.reade@gmail.com>
Date: Tue, 10 Jan 2023 00:36:51 -0800
Subject: [PATCH 21/61] [fix] Adding part HTML attribute to typings (#8182)

fixes #8181
---
 elements/index.d.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/elements/index.d.ts b/elements/index.d.ts
index 4668d190f9..d57d97ad28 100644
--- a/elements/index.d.ts
+++ b/elements/index.d.ts
@@ -478,6 +478,7 @@ export interface HTMLAttributes<T extends EventTarget> extends AriaAttributes, D
 	hidden?: boolean | undefined | null;
 	id?: string | undefined | null;
 	lang?: string | undefined | null;
+	part?: string | undefined | null;
 	placeholder?: string | undefined | null;
 	slot?: string | undefined | null;
 	spellcheck?: Booleanish | undefined | null;

From be38cec3c10b83f76450c9125fa778c8af6453f7 Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Tue, 10 Jan 2023 09:38:16 +0100
Subject: [PATCH 22/61] update changelog

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2c071d874f..4432fe446e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Unreleased
 
 * Add missing `submitter` property to `on:submit` event type
+* Add missing typing for global `part` attribute ([#8181](https://github.com/sveltejs/svelte/issues/8181))
 * Fix static `<svelte:element>` optimization in production mode ([#7938](https://github.com/sveltejs/svelte/pull/7938))
 * Fix `draw` transition with delay showing a dot at the beginning of transition ([#6816](https://github.com/sveltejs/svelte/issues/6816))
 * Fix `svelte-ignore` comment breaks named slot ([#8075](https://github.com/sveltejs/svelte/issues/8075))

From aa98397440baa06743cead6a2955e98b75ee4515 Mon Sep 17 00:00:00 2001
From: Josh <44098505+josh-fnbtech@users.noreply.github.com>
Date: Tue, 10 Jan 2023 02:38:47 -0600
Subject: [PATCH 23/61] [docs] fix typo (#8180)

---
 .../02-reactivity/04-updating-arrays-and-objects/text.md      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/site/content/tutorial/02-reactivity/04-updating-arrays-and-objects/text.md b/site/content/tutorial/02-reactivity/04-updating-arrays-and-objects/text.md
index a298d1d1bb..bc8330206e 100644
--- a/site/content/tutorial/02-reactivity/04-updating-arrays-and-objects/text.md
+++ b/site/content/tutorial/02-reactivity/04-updating-arrays-and-objects/text.md
@@ -23,7 +23,7 @@ function addNumber() {
 }
 ```
 
-The same rule applies to array methods such as `pop`, `shift`, and `splice` and to objects methods such as `Map.set`, `Set.add`, etc.
+The same rule applies to array methods such as `pop`, `shift`, and `splice` and to object methods such as `Map.set`, `Set.add`, etc.
 
 Assignments to *properties* of arrays and objects — e.g. `obj.foo += 1` or `array[i] = x` — work the same way as assignments to the values themselves.
 
@@ -51,4 +51,4 @@ quox(obj);
 
 ...won't trigger reactivity on `obj.foo.bar`, unless you follow it up with `obj = obj`.
 
-A simple rule of thumb: the updated variable must directly appear on the left hand side of the assignment.
\ No newline at end of file
+A simple rule of thumb: the updated variable must directly appear on the left hand side of the assignment.

From b06e4356848ab3375797e634fd6c6114a9643252 Mon Sep 17 00:00:00 2001
From: Emil Tholin <emtholin@gmail.com>
Date: Tue, 10 Jan 2023 09:39:50 +0100
Subject: [PATCH 24/61] [fix] Spread component props immutably during SSR
 (#8176)

By passing an empty object literal as first argument to Object.assign we can avoid having objects spread as props on a component being mutated during SSR.

Fixes #8171
---
 .../render_ssr/handlers/InlineComponent.ts        |  2 +-
 .../spread-component-immutable/Widget.svelte      |  0
 .../samples/spread-component-immutable/_config.js | 15 +++++++++++++++
 .../spread-component-immutable/main.svelte        |  7 +++++++
 4 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 test/runtime/samples/spread-component-immutable/Widget.svelte
 create mode 100644 test/runtime/samples/spread-component-immutable/_config.js
 create mode 100644 test/runtime/samples/spread-component-immutable/main.svelte

diff --git a/src/compiler/compile/render_ssr/handlers/InlineComponent.ts b/src/compiler/compile/render_ssr/handlers/InlineComponent.ts
index 8287b46268..73d31940e2 100644
--- a/src/compiler/compile/render_ssr/handlers/InlineComponent.ts
+++ b/src/compiler/compile/render_ssr/handlers/InlineComponent.ts
@@ -36,7 +36,7 @@ export default function(node: InlineComponent, renderer: Renderer, options: Rend
 	let props;
 
 	if (uses_spread) {
-		props = x`@_Object.assign(${
+		props = x`@_Object.assign({}, ${
 			node.attributes
 				.map(attribute => {
 					if (attribute.is_spread) {
diff --git a/test/runtime/samples/spread-component-immutable/Widget.svelte b/test/runtime/samples/spread-component-immutable/Widget.svelte
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/test/runtime/samples/spread-component-immutable/_config.js b/test/runtime/samples/spread-component-immutable/_config.js
new file mode 100644
index 0000000000..634fac24c1
--- /dev/null
+++ b/test/runtime/samples/spread-component-immutable/_config.js
@@ -0,0 +1,15 @@
+const obj = {
+	x: 1,
+	y: 2,
+	z: 3
+};
+
+export default {
+	props: {
+		obj
+	},
+
+	test({ assert }) {
+		assert.deepEqual(obj, { x: 1, y: 2, z: 3 });
+	}
+};
diff --git a/test/runtime/samples/spread-component-immutable/main.svelte b/test/runtime/samples/spread-component-immutable/main.svelte
new file mode 100644
index 0000000000..44e0954856
--- /dev/null
+++ b/test/runtime/samples/spread-component-immutable/main.svelte
@@ -0,0 +1,7 @@
+<script>
+	import Widget from './Widget.svelte';
+
+	export let obj;
+</script>
+
+<Widget {...obj} x={2} />

From 492d7d6f67ba3a065651f860fdcca477df0d1d04 Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Tue, 10 Jan 2023 09:41:59 +0100
Subject: [PATCH 25/61] update changelog

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4432fe446e..136927af52 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,7 @@
 * Fix max call stack exceeded ([#7032](https://github.com/sveltejs/svelte/issues/7032))
 * Revert to prevent running init binding unnecessarily ([#8103](https://github.com/sveltejs/svelte/issues/8103))
 * Improve `is_promise` logic ([#8162](https://github.com/sveltejs/svelte/pull/8162))
+* Spread component props for immutably during SSR ([#8171](https://github.com/sveltejs/svelte/issues/8171))
 
 ## 3.55.0
 

From 3b3e1c839c9991559547ca3e203d2282d4f90c36 Mon Sep 17 00:00:00 2001
From: Conduitry <git@chor.date>
Date: Tue, 10 Jan 2023 12:17:09 -0500
Subject: [PATCH 26/61] -> v3.55.1

---
 CHANGELOG.md      | 22 +++++++++++-----------
 package-lock.json |  4 ++--
 package.json      |  2 +-
 3 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 136927af52..ce1e2a2621 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,17 +1,17 @@
 # Svelte changelog
 
-## Unreleased
-
-* Add missing `submitter` property to `on:submit` event type
+## 3.55.1
+
+* Fix `draw` transition with delay showing a dot at the beginning of the path ([#6816](https://github.com/sveltejs/svelte/issues/6816))
+* Fix infinity runtime call stack when propagating bindings ([#7032](https://github.com/sveltejs/svelte/issues/7032))
+* Fix static `<svelte:element>` optimization in production mode ([#7937](https://github.com/sveltejs/svelte/issues/7937))
+* Fix `svelte-ignore` comment breaking named slot ([#8075](https://github.com/sveltejs/svelte/issues/8075))
+* Revert change to prevent running init binding unnecessarily ([#8103](https://github.com/sveltejs/svelte/issues/8103))
+* Fix adding duplicate event listeners with `<svelte:element on:event>` ([#8129](https://github.com/sveltejs/svelte/issues/8129))
+* Improve detection of promises that are also functions ([#8162](https://github.com/sveltejs/svelte/pull/8162))
+* Avoid mutating spread component props during SSR ([#8171](https://github.com/sveltejs/svelte/issues/8171))
 * Add missing typing for global `part` attribute ([#8181](https://github.com/sveltejs/svelte/issues/8181))
-* Fix static `<svelte:element>` optimization in production mode ([#7938](https://github.com/sveltejs/svelte/pull/7938))
-* Fix `draw` transition with delay showing a dot at the beginning of transition ([#6816](https://github.com/sveltejs/svelte/issues/6816))
-* Fix `svelte-ignore` comment breaks named slot ([#8075](https://github.com/sveltejs/svelte/issues/8075))
-* Fix duplicate event listeners for `<svelte:element on:event>` ([#8129](https://github.com/sveltejs/svelte/issues/8129))
-* Fix max call stack exceeded ([#7032](https://github.com/sveltejs/svelte/issues/7032))
-* Revert to prevent running init binding unnecessarily ([#8103](https://github.com/sveltejs/svelte/issues/8103))
-* Improve `is_promise` logic ([#8162](https://github.com/sveltejs/svelte/pull/8162))
-* Spread component props for immutably during SSR ([#8171](https://github.com/sveltejs/svelte/issues/8171))
+* Add missing `submitter` property to `on:submit` event type
 
 ## 3.55.0
 
diff --git a/package-lock.json b/package-lock.json
index 70fac43f0e..f993cad461 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "svelte",
-  "version": "3.55.0",
+  "version": "3.55.1",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "svelte",
-      "version": "3.55.0",
+      "version": "3.55.1",
       "license": "MIT",
       "devDependencies": {
         "@ampproject/remapping": "^0.3.0",
diff --git a/package.json b/package.json
index 8839b95c75..1efd4cb780 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "svelte",
-  "version": "3.55.0",
+  "version": "3.55.1",
   "description": "Cybernetically enhanced web apps",
   "module": "index.mjs",
   "main": "index",

From 967e9f51ff649f776fa034db8aba23a5a1546294 Mon Sep 17 00:00:00 2001
From: Yuichiro Yamashita <xydybaseball@gmail.com>
Date: Thu, 12 Jan 2023 11:11:14 +0900
Subject: [PATCH 27/61] chore: add Node18 for CI (#8078)

---
 .github/workflows/ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index e24f106477..1e0ce53864 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -46,7 +46,7 @@ jobs:
     timeout-minutes: 15
     strategy:
       matrix:
-        node-version: [8, 10, 12, 14, 16]
+        node-version: [8, 10, 12, 14, 16, 18]
         os: [ubuntu-latest, windows-latest, macOS-latest]
     steps:
       - uses: actions/checkout@v3

From 79fa5b36a1b0d90407d1bf6b1d6b2504427f3f96 Mon Sep 17 00:00:00 2001
From: Gabriel Francisco <gabrinelson27@gmail.com>
Date: Fri, 27 Jan 2023 13:22:52 -0300
Subject: [PATCH 28/61] Update license year (#8227)

---
 LICENSE.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/LICENSE.md b/LICENSE.md
index cd8f94f4ca..aa74406768 100644
--- a/LICENSE.md
+++ b/LICENSE.md
@@ -1,4 +1,4 @@
-Copyright (c) 2016-22 [these people](https://github.com/sveltejs/svelte/graphs/contributors)
+Copyright (c) 2016-23 [these people](https://github.com/sveltejs/svelte/graphs/contributors)
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
 

From 4f42daeff78a98877d58dff49b6e05b3a4ae0f73 Mon Sep 17 00:00:00 2001
From: Jay Harris <jay.harris@outlook.co.nz>
Date: Sat, 28 Jan 2023 13:25:04 +1300
Subject: [PATCH 29/61] feat: `trusted-types` CSP compatibility for Web
 Components (#8135)

---
 src/compiler/compile/render_dom/index.ts             | 5 ++++-
 test/js/samples/css-shadow-dom-keyframes/expected.js | 4 +++-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/compiler/compile/render_dom/index.ts b/src/compiler/compile/render_dom/index.ts
index 44155f8464..58b7a8317b 100644
--- a/src/compiler/compile/render_dom/index.ts
+++ b/src/compiler/compile/render_dom/index.ts
@@ -531,7 +531,10 @@ export default function dom(
 				constructor(options) {
 					super();
 
-					${css.code && b`this.shadowRoot.innerHTML = \`<style>${css.code.replace(regex_backslashes, '\\\\')}${css_sourcemap_enabled && options.dev ? `\n/*# sourceMappingURL=${css.map.toUrl()} */` : ''}</style>\`;`}
+					${css.code && b`
+						const style = document.createElement('style');
+						style.textContent = \`${css.code.replace(regex_backslashes, '\\\\')}${css_sourcemap_enabled && options.dev ? `\n/*# sourceMappingURL=${css.map.toUrl()} */` : ''}\`
+						this.shadowRoot.appendChild(style)`}
 
 					@init(this, { target: this.shadowRoot, props: ${init_props}, customElement: true }, ${definition}, ${has_create_fragment ? 'create_fragment' : 'null'}, ${not_equal}, ${prop_indexes}, null, ${dirty});
 
diff --git a/test/js/samples/css-shadow-dom-keyframes/expected.js b/test/js/samples/css-shadow-dom-keyframes/expected.js
index 5d65949488..ba7ca9a667 100644
--- a/test/js/samples/css-shadow-dom-keyframes/expected.js
+++ b/test/js/samples/css-shadow-dom-keyframes/expected.js
@@ -34,7 +34,9 @@ function create_fragment(ctx) {
 class Component extends SvelteElement {
 	constructor(options) {
 		super();
-		this.shadowRoot.innerHTML = `<style>div{animation:foo 1s}@keyframes foo{0%{opacity:0}100%{opacity:1}}</style>`;
+		const style = document.createElement('style');
+		style.textContent = `div{animation:foo 1s}@keyframes foo{0%{opacity:0}100%{opacity:1}}`;
+		this.shadowRoot.appendChild(style);
 
 		init(
 			this,

From eb90a15c2959d0d02ee27b4920dc1f197b77b70a Mon Sep 17 00:00:00 2001
From: Ben McCann <322311+benmccann@users.noreply.github.com>
Date: Fri, 27 Jan 2023 16:27:19 -0800
Subject: [PATCH 30/61] update changelog

---
 CHANGELOG.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ce1e2a2621..865ed07b53 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Svelte changelog
 
+## Unreleased
+
+* `trusted-types` CSP compatibility for Web Components ([#8134](https://github.com/sveltejs/svelte/issues/8134))
+
 ## 3.55.1
 
 * Fix `draw` transition with delay showing a dot at the beginning of the path ([#6816](https://github.com/sveltejs/svelte/issues/6816))

From 34ae6aaf1f3279e2c0f0515f64db59d31ecb46f9 Mon Sep 17 00:00:00 2001
From: Ben McCann <322311+benmccann@users.noreply.github.com>
Date: Sat, 28 Jan 2023 08:50:14 -0800
Subject: [PATCH 31/61] fix: make `noreferrer` warning less zealous (#8230)

Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
---
 src/compiler/compile/nodes/Element.ts         | 17 +++++-----
 .../_config.js                                |  3 ++
 .../input.svelte                              |  0
 .../warnings.json                             |  0
 .../input.svelte                              | 33 +++++++++++++++++++
 .../warnings.json                             |  1 +
 6 files changed, 46 insertions(+), 8 deletions(-)
 create mode 100644 test/validator/samples/security-anchor-rel-noreferer-legacy/_config.js
 rename test/validator/samples/{security-anchor-rel-noreferrer => security-anchor-rel-noreferer-legacy}/input.svelte (100%)
 rename test/validator/samples/{security-anchor-rel-noreferrer => security-anchor-rel-noreferer-legacy}/warnings.json (100%)
 create mode 100644 test/validator/samples/security-anchor-rel-noreferer/input.svelte
 create mode 100644 test/validator/samples/security-anchor-rel-noreferer/warnings.json

diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts
index 06ef1ba9c1..0d3e8a01bd 100644
--- a/src/compiler/compile/nodes/Element.ts
+++ b/src/compiler/compile/nodes/Element.ts
@@ -621,22 +621,23 @@ export default class Element extends Node {
 			const name_attribute = attribute_map.get('name');
 			const target_attribute = attribute_map.get('target');
 
-			if (target_attribute && target_attribute.get_static_value() === '_blank' && href_attribute) {
+			// links with target="_blank" should have noopener or noreferrer: https://developer.chrome.com/docs/lighthouse/best-practices/external-anchors-use-rel-noopener/
+			// modern browsers add noopener by default, so we only need to check legacy browsers
+			// legacy browsers don't support noopener so we only check for noreferrer there
+			if (component.compile_options.legacy && target_attribute && target_attribute.get_static_value() === '_blank' && href_attribute) {
 				const href_static_value = href_attribute.get_static_value() ? href_attribute.get_static_value().toLowerCase() : null;
 
 				if (href_static_value === null || href_static_value.match(/^(https?:)?\/\//i)) {
 					const rel = attribute_map.get('rel');
 					if (rel == null || rel.is_static) {
 						const rel_values = rel ? rel.get_static_value().split(regex_any_repeated_whitespaces) : [];
-						const expected_values = ['noreferrer'];
-						expected_values.forEach(expected_value => {
-							if (!rel || rel && rel_values.indexOf(expected_value) < 0) {
+						if (!rel || !rel_values.includes('noreferrer')) {
 								component.warn(this, {
-									code: `security-anchor-rel-${expected_value}`,
-									message: `Security: Anchor with "target=_blank" should have rel attribute containing the value "${expected_value}"`
+									code: 'security-anchor-rel-noreferrer',
+									message:
+										'Security: Anchor with "target=_blank" should have rel attribute containing the value "noreferrer"'
 								});
-							}
-						});
+						}
 					}
 				}
 			}
diff --git a/test/validator/samples/security-anchor-rel-noreferer-legacy/_config.js b/test/validator/samples/security-anchor-rel-noreferer-legacy/_config.js
new file mode 100644
index 0000000000..52f59c8767
--- /dev/null
+++ b/test/validator/samples/security-anchor-rel-noreferer-legacy/_config.js
@@ -0,0 +1,3 @@
+export default {
+	legacy: true
+};
diff --git a/test/validator/samples/security-anchor-rel-noreferrer/input.svelte b/test/validator/samples/security-anchor-rel-noreferer-legacy/input.svelte
similarity index 100%
rename from test/validator/samples/security-anchor-rel-noreferrer/input.svelte
rename to test/validator/samples/security-anchor-rel-noreferer-legacy/input.svelte
diff --git a/test/validator/samples/security-anchor-rel-noreferrer/warnings.json b/test/validator/samples/security-anchor-rel-noreferer-legacy/warnings.json
similarity index 100%
rename from test/validator/samples/security-anchor-rel-noreferrer/warnings.json
rename to test/validator/samples/security-anchor-rel-noreferer-legacy/warnings.json
diff --git a/test/validator/samples/security-anchor-rel-noreferer/input.svelte b/test/validator/samples/security-anchor-rel-noreferer/input.svelte
new file mode 100644
index 0000000000..f5361e5cfe
--- /dev/null
+++ b/test/validator/samples/security-anchor-rel-noreferer/input.svelte
@@ -0,0 +1,33 @@
+<a href="https://svelte.dev" target="_blank">svelte website (invalid)</a>
+<a href="https://svelte.dev" target="_blank" rel="">svelte website (invalid)</a>
+<a href="https://svelte.dev" target="_blank" rel="noopener">svelte website (invalid)</a>
+<a href={'https://svelte.dev'} target="_blank">svelte website (invalid)</a>
+<a href={'https://svelte.dev'} target="_blank" rel="">svelte website (invalid)</a>
+<a href={'https://svelte.dev'} target="_blank" rel="noopener">svelte website (invalid)</a>
+<a href="//svelte.dev" target="_blank">svelte website (invalid)</a>
+<a href="//svelte.dev" target="_blank" rel="">svelte website (invalid)</a>
+<a href="//svelte.dev" target="_blank" rel="noopener">svelte website (invalid)</a>
+<a href="http://svelte.dev" target="_blank">svelte website (invalid)</a>
+<a href="http://svelte.dev" target="_blank" rel="">svelte website (invalid)</a>
+<a href="http://svelte.dev" target="_blank" rel="noopener">svelte website (invalid)</a>
+<a href="HTTP://svelte.dev" target="_blank">svelte website (invalid)</a>
+<a href="HTTP://svelte.dev" target="_blank" rel="">svelte website (invalid)</a>
+<a href="HTTP://svelte.dev" target="_blank" rel="noopener">svelte website (invalid)</a>
+<a href={'HTTPS://svelte.dev'} target="_blank">svelte website (invalid)</a>
+<a href={'HTTPS://svelte.dev'} target="_blank" rel="">svelte website (invalid)</a>
+<a href={'HTTPS://svelte.dev'} target="_blank" rel="noopener">svelte website (invalid)</a>
+<a href="same-host" target="_blank">Same host (valid)</a>
+<a href="same-host" target="_blank" rel="">Same host (valid)</a>
+<a href="same-host" target="_blank" rel="noopener">Same host (valid)</a>
+<a href="http://svelte.dev" target="_blank" rel="noreferrer">svelte website (valid)</a>
+<a href="http://svelte.dev" target="_blank" rel="noreferrer noopener">svelte website (valid)</a>
+<a href="HTTP://svelte.dev" target="_blank" rel="noreferrer">svelte website (valid)</a>
+<a href="HTTP://svelte.dev" target="_blank" rel="noreferrer noopener">svelte website (valid)</a>
+<a href="https://svelte.dev" target="_blank" rel="noreferrer">svelte website (valid)</a>
+<a href="https://svelte.dev" target="_blank" rel="noreferrer noopener">svelte website (valid)</a>
+<a href="HTTPS://svelte.dev" target="_blank" rel="noreferrer">svelte website (valid)</a>
+<a href="HTTPS://svelte.dev" target="_blank" rel="noreferrer noopener">svelte website (valid)</a>
+<a href="//svelte.dev" target="_blank" rel="noreferrer">svelte website (valid)</a>
+<a href="//svelte.dev" target="_blank" rel="noreferrer noopener">svelte website (valid)</a>
+<!-- dynamic rel value should not warn-->
+<a href="//svelte.dev" target="_blank" rel={`${Math.random()}`}>svelte website (valid)</a>
diff --git a/test/validator/samples/security-anchor-rel-noreferer/warnings.json b/test/validator/samples/security-anchor-rel-noreferer/warnings.json
new file mode 100644
index 0000000000..fe51488c70
--- /dev/null
+++ b/test/validator/samples/security-anchor-rel-noreferer/warnings.json
@@ -0,0 +1 @@
+[]

From e875a76ad1675c21aea0911a8b32c8ad3abc070b Mon Sep 17 00:00:00 2001
From: Ben McCann <322311+benmccann@users.noreply.github.com>
Date: Sat, 28 Jan 2023 08:51:35 -0800
Subject: [PATCH 32/61] update changelog

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 865ed07b53..fba777ad9c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+* Make `noreferrer` warning less zealous ([#6289](https://github.com/sveltejs/svelte/issues/6289))
 * `trusted-types` CSP compatibility for Web Components ([#8134](https://github.com/sveltejs/svelte/issues/8134))
 
 ## 3.55.1

From cb972ecdba92326e67c6cc37f672c58b88fdc3a5 Mon Sep 17 00:00:00 2001
From: Tim McCabe <me@timmcca.be>
Date: Sun, 5 Feb 2023 06:23:43 -0500
Subject: [PATCH 33/61] [chore] fix `a11y-no-nointeractive-tabindex` typo
 (#8252)

---
 .../input.svelte                                                  | 0
 .../warnings.json                                                 | 0
 2 files changed, 0 insertions(+), 0 deletions(-)
 rename test/validator/samples/{a11y-no-nointeractive-tabindex => a11y-no-noninteractive-tabindex}/input.svelte (100%)
 rename test/validator/samples/{a11y-no-nointeractive-tabindex => a11y-no-noninteractive-tabindex}/warnings.json (100%)

diff --git a/test/validator/samples/a11y-no-nointeractive-tabindex/input.svelte b/test/validator/samples/a11y-no-noninteractive-tabindex/input.svelte
similarity index 100%
rename from test/validator/samples/a11y-no-nointeractive-tabindex/input.svelte
rename to test/validator/samples/a11y-no-noninteractive-tabindex/input.svelte
diff --git a/test/validator/samples/a11y-no-nointeractive-tabindex/warnings.json b/test/validator/samples/a11y-no-noninteractive-tabindex/warnings.json
similarity index 100%
rename from test/validator/samples/a11y-no-nointeractive-tabindex/warnings.json
rename to test/validator/samples/a11y-no-noninteractive-tabindex/warnings.json

From 6ac24f1d5c9174b161bb6e27743c84c0a117ea7f Mon Sep 17 00:00:00 2001
From: Satvik <satvikgsu@gmail.com>
Date: Sun, 5 Feb 2023 07:00:54 -0500
Subject: [PATCH 34/61] [docs] add missing semicolon (#8190)

---
 site/content/docs/02-component-format.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/site/content/docs/02-component-format.md b/site/content/docs/02-component-format.md
index 268444ab7d..d9f7a35662 100644
--- a/site/content/docs/02-component-format.md
+++ b/site/content/docs/02-component-format.md
@@ -147,7 +147,7 @@ Any top-level statement (i.e. not inside a block or a function) can be made reac
 ```sv
 <script>
 	export let title;
-	export let person
+	export let person;
 
 	// this will update `document.title` whenever
 	// the `title` prop changes

From 82d2982845df188631993db6b18c2842e3613acf Mon Sep 17 00:00:00 2001
From: Ben McCann <322311+benmccann@users.noreply.github.com>
Date: Sun, 5 Feb 2023 06:20:51 -0800
Subject: [PATCH 35/61] chore: update PR template (#8255)

---
 .github/PULL_REQUEST_TEMPLATE.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 7de5a35e13..05b48f2ae0 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,6 +1,6 @@
 ### Before submitting the PR, please make sure you do the following
 - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
-- [ ] Prefix your PR title with `[feat]`, `[fix]`, `[chore]`, or `[docs]`.
+- [ ] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`.
 - [ ] This message body should clearly illustrate what problems it solves.
 - [ ] Ideally, include a test that fails without this PR but passes with it.
 

From 7706a5f7138ef07bfc67a8366f910427994a087f Mon Sep 17 00:00:00 2001
From: James Scott-Brown <james@jamesscottbrown.com>
Date: Tue, 14 Feb 2023 16:18:06 +0000
Subject: [PATCH 36/61] docs: link to MDN page on void elements (#8261)

---
 site/content/docs/03-template-syntax.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/site/content/docs/03-template-syntax.md b/site/content/docs/03-template-syntax.md
index e08cc6216f..6ab05cbb29 100644
--- a/site/content/docs/03-template-syntax.md
+++ b/site/content/docs/03-template-syntax.md
@@ -1670,7 +1670,7 @@ The only supported binding is `bind:this`, since the element type specific bindi
 
 If `this` has a nullish value, the element and its children will not be rendered.
 
-If `this` is the name of a void tag (e.g., `br`) and `<svelte:element>` has child elements, a runtime error will be thrown in development mode.
+If `this` is the name of a [void element](https://developer.mozilla.org/en-US/docs/Glossary/Void_element) (e.g., `br`) and `<svelte:element>` has child elements, a runtime error will be thrown in development mode.
 
 ```sv
 <script>

From ff5c14dc71ead7834b6f0ce3ee8f63f6185ce777 Mon Sep 17 00:00:00 2001
From: James Scott-Brown <james@jamesscottbrown.com>
Date: Tue, 14 Feb 2023 16:19:57 +0000
Subject: [PATCH 37/61] docs: format `window.navigator.onLine` reference as
 code (#8262)

---
 site/content/docs/03-template-syntax.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/site/content/docs/03-template-syntax.md b/site/content/docs/03-template-syntax.md
index 6ab05cbb29..596950815c 100644
--- a/site/content/docs/03-template-syntax.md
+++ b/site/content/docs/03-template-syntax.md
@@ -1716,7 +1716,7 @@ You can also bind to the following properties:
 * `outerHeight`
 * `scrollX`
 * `scrollY`
-* `online` — an alias for window.navigator.onLine
+* `online` — an alias for `window.navigator.onLine`
 
 All except `scrollX` and `scrollY` are readonly.
 

From d7e4b1c8fc91bbfc53d72165cc80390502540313 Mon Sep 17 00:00:00 2001
From: Kyrre Gjerstad <98534972+kyrregjerstad@users.noreply.github.com>
Date: Tue, 14 Feb 2023 17:25:23 +0100
Subject: [PATCH 38/61] docs: fix minor typos (#8268)

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
---
 site/content/docs/03-template-syntax.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/site/content/docs/03-template-syntax.md b/site/content/docs/03-template-syntax.md
index 596950815c..012faeadf8 100644
--- a/site/content/docs/03-template-syntax.md
+++ b/site/content/docs/03-template-syntax.md
@@ -1024,7 +1024,7 @@ Like actions, transitions can have parameters.
 
 Transitions can use custom functions. If the returned object has a `css` function, Svelte will create a CSS animation that plays on the element.
 
-The `t` argument passed to `css` is a value between `0` and `1` after the `easing` function has been applied. *In* transitions run from `0` to `1`, *out* transitions run from `1` to `0` — in other words `1` is the element's natural state, as though no transition had been applied. The `u` argument is equal to `1 - t`.
+The `t` argument passed to `css` is a value between `0` and `1` after the `easing` function has been applied. *In* transitions run from `0` to `1`, *out* transitions run from `1` to `0` — in other words, `1` is the element's natural state, as though no transition had been applied. The `u` argument is equal to `1 - t`.
 
 The function is called repeatedly *before* the transition begins, with different `t` and `u` arguments.
 
@@ -1415,7 +1415,7 @@ Svelte's CSS Variables support allows for easily themeable components:
 
 ---
 
-So you can set a high level theme color:
+So you can set a high-level theme color:
 
 ```css
 /* global.css */
@@ -1575,7 +1575,7 @@ Note that explicitly passing in an empty named slot will add that slot's name to
 
 ---
 
-Slots can be rendered zero or more times, and can pass values *back* to the parent using props. The parent exposes the values to the slot template using the `let:` directive.
+Slots can be rendered zero or more times and can pass values *back* to the parent using props. The parent exposes the values to the slot template using the `let:` directive.
 
 The usual shorthand rules apply — `let:item` is equivalent to `let:item={item}`, and `<slot {item}>` is equivalent to `<slot item={item}>`.
 
@@ -1666,7 +1666,7 @@ If `this` is falsy, no component is rendered.
 
 The `<svelte:element>` element lets you render an element of a dynamically specified type. This is useful for example when displaying rich text content from a CMS. Any properties and event listeners present will be applied to the element.
 
-The only supported binding is `bind:this`, since the element type specific bindings that Svelte does at build time (e.g. `bind:value` for input elements) do not work with a dynamic tag type.
+The only supported binding is `bind:this`, since the element type-specific bindings that Svelte does at build time (e.g. `bind:value` for input elements) do not work with a dynamic tag type.
 
 If `this` has a nullish value, the element and its children will not be rendered.
 

From 0598c989a03f1a5c7b67f2dac9dc09de7c42c34a Mon Sep 17 00:00:00 2001
From: Alicia Sykes <alicia@omg.lol>
Date: Tue, 14 Feb 2023 16:57:07 +0000
Subject: [PATCH 39/61] docs: corrects syntax error in transition code sample
 (#8169)

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
---
 site/content/docs/03-template-syntax.md | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/site/content/docs/03-template-syntax.md b/site/content/docs/03-template-syntax.md
index 012faeadf8..31e712229e 100644
--- a/site/content/docs/03-template-syntax.md
+++ b/site/content/docs/03-template-syntax.md
@@ -1307,14 +1307,12 @@ A custom animation function can also return a `tick` function, which is called *
 		const d = Math.sqrt(dx * dx + dy * dy);
 
 		return {
-		delay: 0,
-		duration: Math.sqrt(d) * 120,
-		easing: cubicOut,
-		tick: (t, u) =>
-			Object.assign(node.style, {
-				color: t > 0.5 ? 'Pink' : 'Blue'
-			});
-	};
+			delay: 0,
+			duration: Math.sqrt(d) * 120,
+			easing: cubicOut,
+			tick: (t, u) =>
+				Object.assign(node.style, { color: t > 0.5 ? 'Pink' : 'Blue' })
+		};
 	}
 </script>
 

From d9253963f79d2066edd164580a684cd066042638 Mon Sep 17 00:00:00 2001
From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>
Date: Tue, 14 Feb 2023 09:05:19 -0800
Subject: [PATCH 40/61] Bump qs from 6.5.2 to 6.5.3 (#8090)

Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/ljharb/qs/releases)
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ljharb/qs/compare/v6.5.2...v6.5.3)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
---
 package-lock.json | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index f993cad461..5ab035cd2e 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -4138,9 +4138,9 @@
       }
     },
     "node_modules/qs": {
-      "version": "6.5.2",
-      "resolved": "https://registry.npmjs.org/qs/-/qs-6.5.2.tgz",
-      "integrity": "sha512-N5ZAX4/LxJmF+7wN74pUD6qAh9/wnvdQcjq9TZjevvXzSUo7bfmw91saqMjzGS2xq91/odN2dW/WOl7qQHNDGA==",
+      "version": "6.5.3",
+      "resolved": "https://registry.npmjs.org/qs/-/qs-6.5.3.tgz",
+      "integrity": "sha512-qxXIEh4pCGfHICj1mAJQ2/2XVZkjCDTcEgfoSQxc/fYivUZxTkk7L3bDBJSoNrEzXI17oUO5Dp07ktqE5KzczA==",
       "dev": true,
       "engines": {
         "node": ">=0.6"
@@ -8432,9 +8432,9 @@
       }
     },
     "qs": {
-      "version": "6.5.2",
-      "resolved": "https://registry.npmjs.org/qs/-/qs-6.5.2.tgz",
-      "integrity": "sha512-N5ZAX4/LxJmF+7wN74pUD6qAh9/wnvdQcjq9TZjevvXzSUo7bfmw91saqMjzGS2xq91/odN2dW/WOl7qQHNDGA==",
+      "version": "6.5.3",
+      "resolved": "https://registry.npmjs.org/qs/-/qs-6.5.3.tgz",
+      "integrity": "sha512-qxXIEh4pCGfHICj1mAJQ2/2XVZkjCDTcEgfoSQxc/fYivUZxTkk7L3bDBJSoNrEzXI17oUO5Dp07ktqE5KzczA==",
       "dev": true
     },
     "queue-microtask": {

From acba4b72e23c90939ca8c39a22aca185d588aa1b Mon Sep 17 00:00:00 2001
From: James Scott-Brown <james@jamesscottbrown.com>
Date: Tue, 14 Feb 2023 18:04:49 +0000
Subject: [PATCH 41/61] docs: clarify bindings for `<select multiple>` (#8260)

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
---
 site/content/docs/03-template-syntax.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/site/content/docs/03-template-syntax.md b/site/content/docs/03-template-syntax.md
index 31e712229e..481fbd4405 100644
--- a/site/content/docs/03-template-syntax.md
+++ b/site/content/docs/03-template-syntax.md
@@ -663,7 +663,7 @@ A `<select>` value binding corresponds to the `value` property on the selected `
 
 ---
 
-A `<select multiple>` element behaves similarly to a checkbox group.
+A `<select multiple>` element behaves similarly to a checkbox group. The bound variable is an array with an entry corresponding to the `value` property of each selected `<option>`.
 
 ```sv
 <select multiple bind:value={fillings}>

From 5a3a1e488a2df94c1d56a04429015ad7125b9b23 Mon Sep 17 00:00:00 2001
From: Lioness100 <jchickmm2@gmail.com>
Date: Tue, 14 Feb 2023 13:36:48 -0500
Subject: [PATCH 42/61] fix: correct typos in variable names (#8257)

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
---
 CHANGELOG.md                                      | 2 +-
 src/compiler/compile/compiler_errors.ts           | 2 +-
 src/compiler/compile/nodes/Binding.ts             | 2 +-
 src/compiler/compile/nodes/Element.ts             | 4 ++--
 test/js/samples/capture-inject-state/expected.js  | 8 ++++----
 test/js/samples/capture-inject-state/input.svelte | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index fba777ad9c..e8b4979fde 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1043,7 +1043,7 @@ Also:
 
 ## 3.5.1
 
-* Accommodate webpack idiosyncracies
+* Accommodate webpack idiosyncrasies
 
 ## 3.5.0
 
diff --git a/src/compiler/compile/compiler_errors.ts b/src/compiler/compile/compiler_errors.ts
index e4d4ffddad..b0c836681c 100644
--- a/src/compiler/compile/compiler_errors.ts
+++ b/src/compiler/compile/compiler_errors.ts
@@ -44,7 +44,7 @@ export default {
 		code: 'invalid-binding',
 		message: 'Cannot bind to a variable declared with {@const ...}'
 	},
-	invalid_binding_writibale: {
+	invalid_binding_writable: {
 		code: 'invalid-binding',
 		message: 'Cannot bind to a variable which is not writable'
 	},
diff --git a/src/compiler/compile/nodes/Binding.ts b/src/compiler/compile/nodes/Binding.ts
index f826df4828..46112a03a3 100644
--- a/src/compiler/compile/nodes/Binding.ts
+++ b/src/compiler/compile/nodes/Binding.ts
@@ -80,7 +80,7 @@ export default class Binding extends Node {
 			variable[this.expression.node.type === 'MemberExpression' ? 'mutated' : 'reassigned'] = true;
 
 			if (info.expression.type === 'Identifier' && !variable.writable) {
-				component.error(this.expression.node as any, compiler_errors.invalid_binding_writibale);
+				component.error(this.expression.node as any, compiler_errors.invalid_binding_writable);
 				return;
 			}
 		}
diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts
index 0d3e8a01bd..cb3d8c718f 100644
--- a/src/compiler/compile/nodes/Element.ts
+++ b/src/compiler/compile/nodes/Element.ts
@@ -1034,14 +1034,14 @@ export default class Element extends Node {
 	}
 }
 
-const regex_starts_with_vovel = /^[aeiou]/;
+const regex_starts_with_vowel = /^[aeiou]/;
 
 function should_have_attribute(
 	node,
 	attributes: string[],
 	name = node.name
 ) {
-	const article = regex_starts_with_vovel.test(attributes[0]) ? 'an' : 'a';
+	const article = regex_starts_with_vowel.test(attributes[0]) ? 'an' : 'a';
 	const sequence = attributes.length > 1 ?
 		attributes.slice(0, -1).join(', ') + ` or ${attributes[attributes.length - 1]}` :
 		attributes[0];
diff --git a/test/js/samples/capture-inject-state/expected.js b/test/js/samples/capture-inject-state/expected.js
index 882b3e9cf6..41f9b966b0 100644
--- a/test/js/samples/capture-inject-state/expected.js
+++ b/test/js/samples/capture-inject-state/expected.js
@@ -48,7 +48,7 @@ function create_fragment(ctx) {
 			t8 = text(/*$prop*/ ctx[2]);
 			t9 = space();
 			t10 = text(/*shadowedByModule*/ ctx[4]);
-			add_location(p, file, 22, 0, 430);
+			add_location(p, file, 22, 0, 431);
 		},
 		l: function claim(nodes) {
 			throw new Error("options.hydrate only works if the component was compiled with the `hydratable: true` option");
@@ -91,7 +91,7 @@ function create_fragment(ctx) {
 }
 
 let moduleLiveBinding;
-const moduleContantProps = 4;
+const moduleConstantProps = 4;
 let moduleLet;
 const moduleConst = 2;
 let shadowedByModule;
@@ -137,7 +137,7 @@ function instance($$self, $$props, $$invalidate) {
 
 	$$self.$capture_state = () => ({
 		moduleLiveBinding,
-		moduleContantProps,
+		moduleConstantProps,
 		moduleLet,
 		moduleConst,
 		shadowedByModule,
@@ -197,4 +197,4 @@ class Component extends SvelteComponentDev {
 }
 
 export default Component;
-export { moduleLiveBinding, moduleContantProps };
\ No newline at end of file
+export { moduleLiveBinding, moduleConstantProps };
diff --git a/test/js/samples/capture-inject-state/input.svelte b/test/js/samples/capture-inject-state/input.svelte
index a1051bc147..a80fecf00f 100644
--- a/test/js/samples/capture-inject-state/input.svelte
+++ b/test/js/samples/capture-inject-state/input.svelte
@@ -1,6 +1,6 @@
 <script context="module">
   export let moduleLiveBinding;
-  export const moduleContantProps = 4;
+  export const moduleConstantProps = 4;
   let moduleLet;
   const moduleConst = 2;
   let shadowedByModule;

From b0fed256f71aeaed9a0dac3cde81f6d98ee0724b Mon Sep 17 00:00:00 2001
From: Andrew Walker <axwalker@users.noreply.github.com>
Date: Tue, 21 Feb 2023 10:23:13 +0000
Subject: [PATCH 43/61] feat: Add -replacestate/-keepfocus to SvelteKit anchor
 tag props (#8281)

---
 elements/index.d.ts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/elements/index.d.ts b/elements/index.d.ts
index d57d97ad28..9a4284af22 100644
--- a/elements/index.d.ts
+++ b/elements/index.d.ts
@@ -540,10 +540,12 @@ export interface HTMLAttributes<T extends EventTarget> extends AriaAttributes, D
 	'bind:textContent'?: string | undefined | null;
 
 	// SvelteKit
+	'data-sveltekit-keepfocus'?: true | '' | 'off' | undefined | null;
 	'data-sveltekit-noscroll'?: true | '' | 'off' | undefined | null;
 	'data-sveltekit-preload-code'?: true | '' | 'eager' | 'viewport' | 'hover' | 'tap' | 'off' | undefined | null;
 	'data-sveltekit-preload-data'?: true | '' | 'hover' | 'tap' | 'off' | undefined | null;
 	'data-sveltekit-reload'?: true | '' | 'off' | undefined | null;
+	'data-sveltekit-replacestate'?: true | '' | 'off' | undefined | null;
 }
 
 export type HTMLAttributeAnchorTarget =

From d5e46d647ee3f16945c3f475c8265f2e3e121875 Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Tue, 21 Feb 2023 11:24:53 +0100
Subject: [PATCH 44/61] chore: update changelog

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e8b4979fde..610e92f4a7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 * Make `noreferrer` warning less zealous ([#6289](https://github.com/sveltejs/svelte/issues/6289))
 * `trusted-types` CSP compatibility for Web Components ([#8134](https://github.com/sveltejs/svelte/issues/8134))
+* Add `data-sveltekit-replacestate` and `data-sveltekit-keepfocus` attribute typings ([#8281](https://github.com/sveltejs/svelte/issues/8281))
 
 ## 3.55.1
 

From 4dd12c0c61c647a9c5fafc4bde05c1bf7bcb8c1c Mon Sep 17 00:00:00 2001
From: Maxime Dupont <m.dupont103@gmail.com>
Date: Tue, 21 Feb 2023 11:33:01 +0100
Subject: [PATCH 45/61] docs: fix fly animation description (#8236)

---
 site/content/docs/04-run-time.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/site/content/docs/04-run-time.md b/site/content/docs/04-run-time.md
index bf5574ad44..ef21112034 100644
--- a/site/content/docs/04-run-time.md
+++ b/site/content/docs/04-run-time.md
@@ -698,7 +698,7 @@ out:fly={params}
 
 ---
 
-Animates the x and y positions and the opacity of an element. `in` transitions animate from an element's current (default) values to the provided values, passed as parameters. `out` transitions animate from the provided values to an element's default values.
+Animates the x and y positions and the opacity of an element. `in` transitions animate from the provided values, passed as parameters to the element's default values. `out` transitions animate from the element's default values to the provided values.
 
 `fly` accepts the following parameters:
 

From 7a6eee51e02c59cb2ae9d6276c19531ccf7fee6c Mon Sep 17 00:00:00 2001
From: Mike Plummer <mike-plummer@users.noreply.github.com>
Date: Tue, 21 Feb 2023 04:54:00 -0600
Subject: [PATCH 46/61] docs: Expand testing FAQ section (#8205)

---------

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
---
 .../content/faq/800-how-do-i-test-svelte-apps.md | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/site/content/faq/800-how-do-i-test-svelte-apps.md b/site/content/faq/800-how-do-i-test-svelte-apps.md
index 0e9bc9e146..5ebabdb214 100644
--- a/site/content/faq/800-how-do-i-test-svelte-apps.md
+++ b/site/content/faq/800-how-do-i-test-svelte-apps.md
@@ -2,12 +2,20 @@
 question: How do I test Svelte apps?
 ---
 
-We recommend trying to separate your view logic from your business logic. Data transformation or cross component state management is best kept outside of Svelte components. You can test those parts like you would test any JavaScript functionality that way. When it comes to testing the components, it is best to test the logic of the component and remember that the Svelte library has its own tests and you do not need to test implementation details provided by Svelte.
+How your application is structured and where logic is defined will determine the best way to ensure it is properly tested. It is important to note that not all logic belongs within a component - this includes concerns such as data transformation, cross-component state management, and logging, among others. Remember that the Svelte library has its own test suite, so you do not need to write tests to validate implementation details provided by Svelte.
 
-There are a few approaches that people take when testing, but it generally involves compiling the component and mounting it to something and then performing the tests. You essentially need to create a bundle for each component you're testing (since svelte is a compiler and not a normal library) and then mount them. You can mount to a JSDOM instance. Or you can use a real browser powered by a library like Playwright, Puppeteer, WebdriverIO or Cypress.
+A Svelte application will typically have three different types of tests: Unit, Component, and End-to-End (E2E).
 
-Some resources for getting started with unit testing:
+*Unit Tests*: Focus on testing business logic in isolation. Often this is validating individual functions and edge cases. By minimizing the surface area of these tests they can be kept lean and fast, and by extracting as much logic as possible from your Svelte components more of your application can be covered using them. When creating a new SvelteKit project, you will be asked whether you would like to setup [Vitest](https://vitest.dev/) for unit testing. There are a number of other test runners that could be used as well.
+
+*Component Tests*: Validating that a Svelte component mounts and interacts as expected throughout its lifecycle requires a tool that provides a Document Object Model (DOM). Components can be compiled (since Svelte is a compiler and not a normal library) and mounted to allow asserting against element structure, listeners, state, and all the other capabilities provided by a Svelte component. Tools for component testing range from an in-memory implementation like jsdom paired with a test runner like [Vitest](https://vitest.dev/) to solutions that leverage an actual browser to provide a visual testing capability such as [Playwright](https://playwright.dev/docs/test-components) or [Cypress](https://www.cypress.io/).
+
+*End-to-End Tests*: To ensure your users are able to interact with your application it is necessary to test it as a whole in a manner as close to production as possible. This is done by writing end-to-end (E2E) tests which load and interact with a deployed version of your application in order to simulate how the user will interact with your application. When creating a new SvelteKit project, you will be asked whether you would like to setup [Playwright](https://playwright.dev/) for end-to-end testing. There are many other E2E test libraries available for use as well.
+
+Some resources for getting started with testing:
 - [Svelte Testing Library](https://testing-library.com/docs/svelte-testing-library/example/)
+- [Svelte Component Testing in Cypress](https://docs.cypress.io/guides/component-testing/svelte/overview)
 - [Example using vitest](https://github.com/vitest-dev/vitest/tree/main/examples/svelte)
 - [Example using uvu test runner with JSDOM](https://github.com/lukeed/uvu/tree/master/examples/svelte)
-- [Component testing in real browser](https://webdriver.io/docs/component-testing/svelte)
+- [Test Svelte components using Vitest & Playwright](https://davipon.hashnode.dev/test-svelte-component-using-vitest-playwright)
+- [Component testing with WebdriverIO](https://webdriver.io/docs/component-testing/svelte)

From 213049cc2e6dfddb872c2286a2a8e5f00c22d73e Mon Sep 17 00:00:00 2001
From: Hyunbin <47051820+hyunbinseo@users.noreply.github.com>
Date: Tue, 21 Feb 2023 20:07:33 +0900
Subject: [PATCH 47/61] docs: update dialog example (#8200)

* feat: update dialog example

* button always autofocusses, allows us to simplify

---------

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
---
 .../15-composition/05-modal/App.svelte        |  36 +++---
 .../15-composition/05-modal/Modal.svelte      | 118 ++++++++----------
 2 files changed, 68 insertions(+), 86 deletions(-)

diff --git a/site/content/examples/15-composition/05-modal/App.svelte b/site/content/examples/15-composition/05-modal/App.svelte
index cfd3856447..af93ba39af 100644
--- a/site/content/examples/15-composition/05-modal/App.svelte
+++ b/site/content/examples/15-composition/05-modal/App.svelte
@@ -4,26 +4,26 @@
 	let showModal = false;
 </script>
 
-<button on:click="{() => showModal = true}">
+<button on:click={() => (showModal = true)}>
 	show modal
 </button>
 
-{#if showModal}
-	<Modal on:close="{() => showModal = false}">
-		<h2 slot="header">
-			modal
-			<small><em>adjective</em>  mod·al \ˈmō-dəl\</small>
-		</h2>
+<Modal bind:showModal>
+	<h2 slot="header">
+		modal
+		<small><em>adjective</em> mod·al \ˈmō-dəl\</small>
+	</h2>
 
-		<ol class="definition-list">
-			<li>of or relating to modality in logic</li>
-			<li>containing provisions as to the mode of procedure or the manner of taking effect —used of a contract or legacy</li>
-			<li>of or relating to a musical mode</li>
-			<li>of or relating to structure as opposed to substance</li>
-			<li>of, relating to, or constituting a grammatical form or category characteristically indicating predication</li>
-			<li>of or relating to a statistical mode</li>
-		</ol>
+	<ol class="definition-list">
+		<li>of or relating to modality in logic</li>
+		<li>
+			containing provisions as to the mode of procedure or the manner of taking effect —used of a contract or legacy
+		</li>
+		<li>of or relating to a musical mode</li>
+		<li>of or relating to structure as opposed to substance</li>
+		<li>of, relating to, or constituting a grammatical form or category characteristically indicating predication</li>
+		<li>of or relating to a statistical mode</li>
+	</ol>
 
-		<a href="https://www.merriam-webster.com/dictionary/modal">merriam-webster.com</a>
-	</Modal>
-{/if}
+	<a href="https://www.merriam-webster.com/dictionary/modal">merriam-webster.com</a>
+</Modal>
diff --git a/site/content/examples/15-composition/05-modal/Modal.svelte b/site/content/examples/15-composition/05-modal/Modal.svelte
index baa57824bc..acdbd50ab1 100644
--- a/site/content/examples/15-composition/05-modal/Modal.svelte
+++ b/site/content/examples/15-composition/05-modal/Modal.svelte
@@ -1,81 +1,63 @@
 <script>
-	import { createEventDispatcher, onDestroy } from 'svelte';
+	export let showModal; // boolean
 
-	const dispatch = createEventDispatcher();
-	const close = () => dispatch('close');
+	let dialog; // HTMLDialogElement
 
-	let modal;
-
-	const handle_keydown = e => {
-		if (e.key === 'Escape') {
-			close();
-			return;
-		}
-
-		if (e.key === 'Tab') {
-			// trap focus
-			const nodes = modal.querySelectorAll('*');
-			const tabbable = Array.from(nodes).filter(n => n.tabIndex >= 0);
-
-			let index = tabbable.indexOf(document.activeElement);
-			if (index === -1 && e.shiftKey) index = 0;
-
-			index += tabbable.length + (e.shiftKey ? -1 : 1);
-			index %= tabbable.length;
-
-			tabbable[index].focus();
-			e.preventDefault();
-		}
-	};
-
-	const previously_focused = typeof document !== 'undefined' && document.activeElement;
-
-	if (previously_focused) {
-		onDestroy(() => {
-			previously_focused.focus();
-		});
-	}
+	$: if (dialog && showModal) dialog.showModal();
 </script>
 
-<svelte:window on:keydown={handle_keydown}/>
-
-<div class="modal-background" on:click={close}></div>
-
-<div class="modal" role="dialog" aria-modal="true" bind:this={modal}>
-	<slot name="header"></slot>
-	<hr>
-	<slot></slot>
-	<hr>
-
-	<!-- svelte-ignore a11y-autofocus -->
-	<button autofocus on:click={close}>close modal</button>
-</div>
+<!-- svelte-ignore a11y-click-events-have-key-events -->
+<dialog
+	bind:this={dialog}
+	on:close={() => (showModal = false)}
+	on:click|self={() => dialog.close()}
+>
+	<div on:click|stopPropagation>
+		<slot name="header" />
+		<hr />
+		<slot />
+		<hr />
+		<!-- svelte-ignore a11y-autofocus -->
+		<button autofocus on:click={() => dialog.close()}>close modal</button>
+	</div>
+</dialog>
 
 <style>
-	.modal-background {
-		position: fixed;
-		top: 0;
-		left: 0;
-		width: 100%;
-		height: 100%;
-		background: rgba(0,0,0,0.3);
-	}
-
-	.modal {
-		position: absolute;
-		left: 50%;
-		top: 50%;
-		width: calc(100vw - 4em);
+	dialog {
 		max-width: 32em;
-		max-height: calc(100vh - 4em);
-		overflow: auto;
-		transform: translate(-50%,-50%);
-		padding: 1em;
 		border-radius: 0.2em;
-		background: white;
+		border: none;
+		padding: 0;
+	}
+	dialog::backdrop {
+		background: rgba(0, 0, 0, 0.3);
+	}
+	dialog > div {
+		padding: 1em;
+	}
+	dialog[open] {
+		animation: zoom 0.3s cubic-bezier(0.34, 1.56, 0.64, 1);
+	}
+	@keyframes zoom {
+		from {
+			transform: scale(0.95);
+		}
+		to {
+			transform: scale(1);
+		}
+	}
+	dialog[open]::backdrop {
+		animation: fade 0.2s ease-out;
+	}
+	@keyframes fade {
+		from {
+			opacity: 0;
+		}
+		to {
+			opacity: 1;
+		}
 	}
-
 	button {
 		display: block;
 	}
-</style>
\ No newline at end of file
+</style>

From 324b791d81203546d11af2a3d1062353c1b5b8b7 Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Tue, 21 Feb 2023 13:04:12 +0100
Subject: [PATCH 48/61] docs: note #if to wrap text only

taken from #7070
---
 site/content/docs/03-template-syntax.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/site/content/docs/03-template-syntax.md b/site/content/docs/03-template-syntax.md
index 481fbd4405..74a2069c68 100644
--- a/site/content/docs/03-template-syntax.md
+++ b/site/content/docs/03-template-syntax.md
@@ -206,6 +206,7 @@ Additional conditions can be added with `{:else if expression}`, optionally endi
 {/if}
 ```
 
+(Blocks don't have to wrap elements, they can also wrap text within elements!)
 
 ### {#each ...}
 

From 85f882f23dda881c2478f7828a82065aca6bbeb7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jhorman=20Ruswel=20=E3=85=A0=E3=85=A0?=
 <jhormanrus@gmail.com>
Date: Tue, 21 Feb 2023 07:13:50 -0500
Subject: [PATCH 49/61] docs: update Keyed Each Blocks tutorial (#8188)

log which element is removed

---------

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
---
 .../04-logic/05-keyed-each-blocks/app-a/Thing.svelte       | 7 +++++++
 .../04-logic/05-keyed-each-blocks/app-b/Thing.svelte       | 7 +++++++
 2 files changed, 14 insertions(+)

diff --git a/site/content/tutorial/04-logic/05-keyed-each-blocks/app-a/Thing.svelte b/site/content/tutorial/04-logic/05-keyed-each-blocks/app-a/Thing.svelte
index 02e6fa7640..e91026fb98 100644
--- a/site/content/tutorial/04-logic/05-keyed-each-blocks/app-a/Thing.svelte
+++ b/site/content/tutorial/04-logic/05-keyed-each-blocks/app-a/Thing.svelte
@@ -1,4 +1,6 @@
 <script>
+	import { onDestroy } from 'svelte';
+
 	const emojis = {
         apple: "🍎",
         banana: "🍌",
@@ -12,6 +14,11 @@
 
 	// ...but the "emoji" variable is fixed upon initialisation of the component
 	const emoji = emojis[name];
+
+	// observe in the console which entry is removed
+	onDestroy(() => {
+		console.log('thing destroyed: ' + name)
+	});
 </script>
 
 <p>
diff --git a/site/content/tutorial/04-logic/05-keyed-each-blocks/app-b/Thing.svelte b/site/content/tutorial/04-logic/05-keyed-each-blocks/app-b/Thing.svelte
index 02e6fa7640..e91026fb98 100644
--- a/site/content/tutorial/04-logic/05-keyed-each-blocks/app-b/Thing.svelte
+++ b/site/content/tutorial/04-logic/05-keyed-each-blocks/app-b/Thing.svelte
@@ -1,4 +1,6 @@
 <script>
+	import { onDestroy } from 'svelte';
+
 	const emojis = {
         apple: "🍎",
         banana: "🍌",
@@ -12,6 +14,11 @@
 
 	// ...but the "emoji" variable is fixed upon initialisation of the component
 	const emoji = emojis[name];
+
+	// observe in the console which entry is removed
+	onDestroy(() => {
+		console.log('thing destroyed: ' + name)
+	});
 </script>
 
 <p>

From f6ef6a9349a04cc8cab1dbb091c34621a2eace8f Mon Sep 17 00:00:00 2001
From: Ben Bucksch <1907525+benbucksch@users.noreply.github.com>
Date: Tue, 21 Feb 2023 13:52:39 +0100
Subject: [PATCH 50/61] fix: don't throw when calling writable() unsubscribe
 twice (#8186)

Fixes one case of #4765

---------

Co-authored-by: Ben Bucksch <bbucksch@jw.org>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
---
 src/runtime/store/index.ts | 2 +-
 test/store/index.ts        | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/runtime/store/index.ts b/src/runtime/store/index.ts
index e947fa0740..16832f10d9 100644
--- a/src/runtime/store/index.ts
+++ b/src/runtime/store/index.ts
@@ -98,7 +98,7 @@ export function writable<T>(value?: T, start: StartStopNotifier<T> = noop): Writ
 
 		return () => {
 			subscribers.delete(subscriber);
-			if (subscribers.size === 0) {
+			if (subscribers.size === 0 && stop) {
 				stop();
 				stop = null;
 			}
diff --git a/test/store/index.ts b/test/store/index.ts
index b6fc5940e1..389f29244b 100644
--- a/test/store/index.ts
+++ b/test/store/index.ts
@@ -88,6 +88,14 @@ describe('store', () => {
 
 			unsubscribe();
 		});
+
+		it('no error even if unsubscribe calls twice', () => {
+			let num = 0;
+			const store = writable(num, set => set(num += 1));
+			const unsubscribe = store.subscribe(() => { });
+			unsubscribe();
+			assert.doesNotThrow(() => unsubscribe());
+		});
 	});
 
 	describe('readable', () => {

From 2a5b48838648305b933de9d9ab5c9654ca24848a Mon Sep 17 00:00:00 2001
From: Valter Kraemer <valterkraemer@users.noreply.github.com>
Date: Tue, 21 Feb 2023 16:21:48 +0200
Subject: [PATCH 51/61] fix: empty value attribute selector doesn't produce
 "Unused CSS selector" warning (#8122)

Fixes: #8042

---------

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
---
 src/compiler/compile/css/Selector.ts          |  2 +-
 .../_config.js                                | 25 +++++++++++++++++++
 .../expected.css                              |  1 +
 .../expected.html                             |  1 +
 .../input.svelte                              | 11 ++++++++
 5 files changed, 39 insertions(+), 1 deletion(-)
 create mode 100644 test/css/samples/unused-selector-empty-attribute/_config.js
 create mode 100644 test/css/samples/unused-selector-empty-attribute/expected.css
 create mode 100644 test/css/samples/unused-selector-empty-attribute/expected.html
 create mode 100644 test/css/samples/unused-selector-empty-attribute/input.svelte

diff --git a/src/compiler/compile/css/Selector.ts b/src/compiler/compile/css/Selector.ts
index 07e2dc439e..5feb59ec0c 100644
--- a/src/compiler/compile/css/Selector.ts
+++ b/src/compiler/compile/css/Selector.ts
@@ -350,7 +350,7 @@ function attribute_matches(node: CssNode, name: string, expected_value: string,
 	const attr = node.attributes.find((attr: CssNode) => attr.name === name);
 	if (!attr) return false;
 	if (attr.is_true) return operator === null;
-	if (!expected_value) return true;
+	if (expected_value == null) return true;
 
 	if (attr.chunks.length === 1) {
 		const value = attr.chunks[0];
diff --git a/test/css/samples/unused-selector-empty-attribute/_config.js b/test/css/samples/unused-selector-empty-attribute/_config.js
new file mode 100644
index 0000000000..6f77c6a3e1
--- /dev/null
+++ b/test/css/samples/unused-selector-empty-attribute/_config.js
@@ -0,0 +1,25 @@
+export default {
+	warnings: [{
+		filename: 'SvelteComponent.svelte',
+		code: 'css-unused-selector',
+		message: 'Unused CSS selector "img[alt=""]"',
+		start: {
+			character: 87,
+			column: 1,
+			line: 8
+		  },
+		end: {
+			character: 98,
+			column: 12,
+			line: 8
+		  },
+		pos: 87,
+		frame: `
+			 6:   }
+			 7:
+			 8:   img[alt=""] {
+			      ^
+			 9:     border: 1px solid red;
+			10:   }`
+	}]
+};
diff --git a/test/css/samples/unused-selector-empty-attribute/expected.css b/test/css/samples/unused-selector-empty-attribute/expected.css
new file mode 100644
index 0000000000..987fa142db
--- /dev/null
+++ b/test/css/samples/unused-selector-empty-attribute/expected.css
@@ -0,0 +1 @@
+img[alt].svelte-xyz{border:1px solid green}
\ No newline at end of file
diff --git a/test/css/samples/unused-selector-empty-attribute/expected.html b/test/css/samples/unused-selector-empty-attribute/expected.html
new file mode 100644
index 0000000000..889908c217
--- /dev/null
+++ b/test/css/samples/unused-selector-empty-attribute/expected.html
@@ -0,0 +1 @@
+<img alt="a foo" class="svelte-xyz" src="foo.jpg">
\ No newline at end of file
diff --git a/test/css/samples/unused-selector-empty-attribute/input.svelte b/test/css/samples/unused-selector-empty-attribute/input.svelte
new file mode 100644
index 0000000000..0200e537be
--- /dev/null
+++ b/test/css/samples/unused-selector-empty-attribute/input.svelte
@@ -0,0 +1,11 @@
+<img src="foo.jpg" alt="a foo" />
+
+<style>
+	img[alt] {
+		border: 1px solid green;
+	}
+
+	img[alt=""] {
+		border: 1px solid red;
+	}
+</style>

From aa9b2dd5f3c54ae9918ec6659760cfaf1f7d8892 Mon Sep 17 00:00:00 2001
From: Carlos Ivanchuk <105121122+buhodev@users.noreply.github.com>
Date: Tue, 21 Feb 2023 12:27:49 -0400
Subject: [PATCH 52/61] fix: omit a11y warning on `<video>` when
 `aria-hidden="true"` (#7880)

Related to #5967. Closes #7874

---------

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
---
 src/compiler/compile/nodes/Element.ts         |  5 +++-
 .../a11y-media-has-caption/input.svelte       |  3 ++
 .../a11y-media-has-caption/warnings.json      | 30 +++++++++++++++++++
 3 files changed, 37 insertions(+), 1 deletion(-)

diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts
index cb3d8c718f..62e0de51bf 100644
--- a/src/compiler/compile/nodes/Element.ts
+++ b/src/compiler/compile/nodes/Element.ts
@@ -718,7 +718,10 @@ export default class Element extends Node {
 		}
 
 		if (this.name === 'video') {
-			if (attribute_map.has('muted')) {
+			const aria_hidden_attribute = attribute_map.get('aria-hidden');
+			const aria_hidden_exist = aria_hidden_attribute && aria_hidden_attribute.get_static_value();
+
+			if (attribute_map.has('muted') || aria_hidden_exist === 'true') {
 				return;
 			}
 
diff --git a/test/validator/samples/a11y-media-has-caption/input.svelte b/test/validator/samples/a11y-media-has-caption/input.svelte
index 6d98fd3734..30f9a05f91 100644
--- a/test/validator/samples/a11y-media-has-caption/input.svelte
+++ b/test/validator/samples/a11y-media-has-caption/input.svelte
@@ -2,3 +2,6 @@
 <video></video>
 <video><track /></video>
 <audio></audio>
+<video aria-hidden></video>
+<video aria-hidden="false"></video>
+<video aria-hidden="true"></video>
diff --git a/test/validator/samples/a11y-media-has-caption/warnings.json b/test/validator/samples/a11y-media-has-caption/warnings.json
index 72c2caae53..6db618f03c 100644
--- a/test/validator/samples/a11y-media-has-caption/warnings.json
+++ b/test/validator/samples/a11y-media-has-caption/warnings.json
@@ -28,5 +28,35 @@
       "column": 0,
       "line": 3
     }
+  },
+  {
+    "code": "a11y-media-has-caption",
+    "end": {
+      "character": 124,
+      "column": 27,
+      "line": 5
+    },
+    "message": "A11y: <video> elements must have a <track kind=\"captions\">",
+    "pos": 97,
+    "start": {
+      "character": 97,
+      "column": 0,
+      "line": 5
+    }
+  },
+  {
+    "code": "a11y-media-has-caption",
+    "end": {
+      "character": 160,
+      "column": 35,
+      "line": 6
+    },
+    "message": "A11y: <video> elements must have a <track kind=\"captions\">",
+    "pos": 125,
+    "start": {
+      "character": 125,
+      "column": 0,
+      "line": 6
+    }
   }
 ]

From 87424b3137557ac33479d7c814c017b546b6464b Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Tue, 21 Feb 2023 18:14:15 +0100
Subject: [PATCH 53/61] chore: update changelog

---
 CHANGELOG.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 610e92f4a7..9a47296f80 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,9 @@
 * Make `noreferrer` warning less zealous ([#6289](https://github.com/sveltejs/svelte/issues/6289))
 * `trusted-types` CSP compatibility for Web Components ([#8134](https://github.com/sveltejs/svelte/issues/8134))
 * Add `data-sveltekit-replacestate` and `data-sveltekit-keepfocus` attribute typings ([#8281](https://github.com/sveltejs/svelte/issues/8281))
+* Don't throw when calling `unsubscribe` twice ([#8186](https://github.com/sveltejs/svelte/pull/8186))
+* Detect unused empty attribute CSS selectors ([#8042](https://github.com/sveltejs/svelte/issues/8042))
+* Omit a11y warning on `<video>` tags with `aria-hidden="true"` ([#7874](https://github.com/sveltejs/svelte/issues/7874))
 
 ## 3.55.1
 

From 57d869d0289e24bf564ad76b62597846d27c4611 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A9mi=20Marche?=
 <35939574+ecstrema@users.noreply.github.com>
Date: Tue, 21 Feb 2023 20:00:15 +0100
Subject: [PATCH 54/61] [docs] move `@html` tutorial to end (partly fixing
 #7253) (#7254)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Move @html tutorial to end

* move debug and html tag into one section

* rename

---------

Co-authored-by: Rémi Marche <35939574+Marr11317@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
---
 .../{07-making-an-app => 06-making-an-app}/app-a/App.svelte    | 0
 .../{07-making-an-app => 06-making-an-app}/text.md             | 0
 site/content/tutorial/18-debugging/meta.json                   | 3 ---
 .../01-debug/app-a/App.svelte                                  | 0
 .../01-debug/app-b/App.svelte                                  | 0
 .../{18-debugging => 18-special-tags}/01-debug/text.md         | 0
 .../02-html-tags}/app-a/App.svelte                             | 0
 .../02-html-tags}/app-b/App.svelte                             | 0
 .../06-html-tags => 18-special-tags/02-html-tags}/text.md      | 2 +-
 site/content/tutorial/18-special-tags/meta.json                | 3 +++
 10 files changed, 4 insertions(+), 4 deletions(-)
 rename site/content/tutorial/01-introduction/{07-making-an-app => 06-making-an-app}/app-a/App.svelte (100%)
 rename site/content/tutorial/01-introduction/{07-making-an-app => 06-making-an-app}/text.md (100%)
 delete mode 100644 site/content/tutorial/18-debugging/meta.json
 rename site/content/tutorial/{18-debugging => 18-special-tags}/01-debug/app-a/App.svelte (100%)
 rename site/content/tutorial/{18-debugging => 18-special-tags}/01-debug/app-b/App.svelte (100%)
 rename site/content/tutorial/{18-debugging => 18-special-tags}/01-debug/text.md (100%)
 rename site/content/tutorial/{01-introduction/06-html-tags => 18-special-tags/02-html-tags}/app-a/App.svelte (100%)
 rename site/content/tutorial/{01-introduction/06-html-tags => 18-special-tags/02-html-tags}/app-b/App.svelte (100%)
 rename site/content/tutorial/{01-introduction/06-html-tags => 18-special-tags/02-html-tags}/text.md (57%)
 create mode 100644 site/content/tutorial/18-special-tags/meta.json

diff --git a/site/content/tutorial/01-introduction/07-making-an-app/app-a/App.svelte b/site/content/tutorial/01-introduction/06-making-an-app/app-a/App.svelte
similarity index 100%
rename from site/content/tutorial/01-introduction/07-making-an-app/app-a/App.svelte
rename to site/content/tutorial/01-introduction/06-making-an-app/app-a/App.svelte
diff --git a/site/content/tutorial/01-introduction/07-making-an-app/text.md b/site/content/tutorial/01-introduction/06-making-an-app/text.md
similarity index 100%
rename from site/content/tutorial/01-introduction/07-making-an-app/text.md
rename to site/content/tutorial/01-introduction/06-making-an-app/text.md
diff --git a/site/content/tutorial/18-debugging/meta.json b/site/content/tutorial/18-debugging/meta.json
deleted file mode 100644
index 5eeed281d3..0000000000
--- a/site/content/tutorial/18-debugging/meta.json
+++ /dev/null
@@ -1,3 +0,0 @@
-{
-	"title": "Debugging"
-}
\ No newline at end of file
diff --git a/site/content/tutorial/18-debugging/01-debug/app-a/App.svelte b/site/content/tutorial/18-special-tags/01-debug/app-a/App.svelte
similarity index 100%
rename from site/content/tutorial/18-debugging/01-debug/app-a/App.svelte
rename to site/content/tutorial/18-special-tags/01-debug/app-a/App.svelte
diff --git a/site/content/tutorial/18-debugging/01-debug/app-b/App.svelte b/site/content/tutorial/18-special-tags/01-debug/app-b/App.svelte
similarity index 100%
rename from site/content/tutorial/18-debugging/01-debug/app-b/App.svelte
rename to site/content/tutorial/18-special-tags/01-debug/app-b/App.svelte
diff --git a/site/content/tutorial/18-debugging/01-debug/text.md b/site/content/tutorial/18-special-tags/01-debug/text.md
similarity index 100%
rename from site/content/tutorial/18-debugging/01-debug/text.md
rename to site/content/tutorial/18-special-tags/01-debug/text.md
diff --git a/site/content/tutorial/01-introduction/06-html-tags/app-a/App.svelte b/site/content/tutorial/18-special-tags/02-html-tags/app-a/App.svelte
similarity index 100%
rename from site/content/tutorial/01-introduction/06-html-tags/app-a/App.svelte
rename to site/content/tutorial/18-special-tags/02-html-tags/app-a/App.svelte
diff --git a/site/content/tutorial/01-introduction/06-html-tags/app-b/App.svelte b/site/content/tutorial/18-special-tags/02-html-tags/app-b/App.svelte
similarity index 100%
rename from site/content/tutorial/01-introduction/06-html-tags/app-b/App.svelte
rename to site/content/tutorial/18-special-tags/02-html-tags/app-b/App.svelte
diff --git a/site/content/tutorial/01-introduction/06-html-tags/text.md b/site/content/tutorial/18-special-tags/02-html-tags/text.md
similarity index 57%
rename from site/content/tutorial/01-introduction/06-html-tags/text.md
rename to site/content/tutorial/18-special-tags/02-html-tags/text.md
index ff547247e2..0da4708020 100644
--- a/site/content/tutorial/01-introduction/06-html-tags/text.md
+++ b/site/content/tutorial/18-special-tags/02-html-tags/text.md
@@ -12,4 +12,4 @@ In Svelte, you do this with the special `{@html ...}` tag:
 <p>{@html string}</p>
 ```
 
-> Svelte doesn't perform any sanitization of the expression inside `{@html ...}` before it gets inserted into the DOM. In other words, if you use this feature it's critical that you manually escape HTML that comes from sources you don't trust, otherwise you risk exposing your users to XSS attacks.
+> **Warning!** Svelte doesn't perform any sanitization of the expression inside `{@html ...}` before it gets inserted into the DOM. In other words, if you use this feature it's **critical** that you manually escape HTML that comes from sources you don't trust, otherwise you risk exposing your users to XSS attacks.
diff --git a/site/content/tutorial/18-special-tags/meta.json b/site/content/tutorial/18-special-tags/meta.json
new file mode 100644
index 0000000000..06e1732030
--- /dev/null
+++ b/site/content/tutorial/18-special-tags/meta.json
@@ -0,0 +1,3 @@
+{
+	"title": "Special tags"
+}
\ No newline at end of file

From a0cedf8d82279113ef86ebc4dc77b6ec6cb609db Mon Sep 17 00:00:00 2001
From: Yuichiro Yamashita <xydybaseball@gmail.com>
Date: Wed, 22 Feb 2023 17:46:49 +0900
Subject: [PATCH 55/61] fix: flush remaining `afterUpdate` before `destroy`
 (#7516)

fixes #7476
---
 src/runtime/internal/Component.ts             |  4 ++-
 src/runtime/internal/scheduler.ts             | 13 ++++++++-
 .../Component.svelte                          | 27 +++++++++++++++++++
 .../action-update-before-destroy/_config.js   | 16 +++++++++++
 .../action-update-before-destroy/main.svelte  | 10 +++++++
 5 files changed, 68 insertions(+), 2 deletions(-)
 create mode 100644 test/runtime/samples/action-update-before-destroy/Component.svelte
 create mode 100644 test/runtime/samples/action-update-before-destroy/_config.js
 create mode 100644 test/runtime/samples/action-update-before-destroy/main.svelte

diff --git a/src/runtime/internal/Component.ts b/src/runtime/internal/Component.ts
index 5aec24c651..a8a500b25b 100644
--- a/src/runtime/internal/Component.ts
+++ b/src/runtime/internal/Component.ts
@@ -1,4 +1,4 @@
-import { add_render_callback, flush, schedule_update, dirty_components } from './scheduler';
+import { add_render_callback, flush, flush_render_callbacks, schedule_update, dirty_components } from './scheduler';
 import { current_component, set_current_component } from './lifecycle';
 import { blank_object, is_empty, is_function, run, run_all, noop } from './utils';
 import { children, detach, start_hydrating, end_hydrating } from './dom';
@@ -51,6 +51,8 @@ export function mount_component(component, target, anchor, customElement) {
 export function destroy_component(component, detaching) {
 	const $$ = component.$$;
 	if ($$.fragment !== null) {
+		flush_render_callbacks($$.after_update);
+
 		run_all($$.on_destroy);
 
 		$$.fragment && $$.fragment.d(detaching);
diff --git a/src/runtime/internal/scheduler.ts b/src/runtime/internal/scheduler.ts
index f95ba446f5..5327e7b5b5 100644
--- a/src/runtime/internal/scheduler.ts
+++ b/src/runtime/internal/scheduler.ts
@@ -5,7 +5,7 @@ export const dirty_components = [];
 export const intros = { enabled: false };
 
 export const binding_callbacks = [];
-const render_callbacks = [];
+let render_callbacks = [];
 const flush_callbacks = [];
 
 const resolved_promise = Promise.resolve();
@@ -122,3 +122,14 @@ function update($$) {
 		$$.after_update.forEach(add_render_callback);
 	}
 }
+
+/**
+ * Useful for example to execute remaining `afterUpdate` callbacks before executing `destroy`.
+ */
+export function flush_render_callbacks(fns: Function[]): void {
+	const filtered = [];
+	const targets = [];
+	render_callbacks.forEach((c) => fns.indexOf(c) === -1 ? filtered.push(c) : targets.push(c));
+	targets.forEach((c) => c());
+	render_callbacks = filtered;
+}
diff --git a/test/runtime/samples/action-update-before-destroy/Component.svelte b/test/runtime/samples/action-update-before-destroy/Component.svelte
new file mode 100644
index 0000000000..e38a0fff64
--- /dev/null
+++ b/test/runtime/samples/action-update-before-destroy/Component.svelte
@@ -0,0 +1,27 @@
+<script>
+  import { afterUpdate, onDestroy } from "svelte";
+
+  export let id;
+	export let items;
+
+  let item = $items[id];
+	let selected = true;
+
+  function onClick() {
+    selected = !selected;
+    items.set({});
+  }
+
+  onDestroy(() => {
+		console.log("onDestroy");
+  });
+
+  afterUpdate(() => {
+    console.log("afterUpdate");
+  });
+</script>
+
+<button on:click="{onClick}">Click Me</button>
+{#if selected}
+  <div>{item.id}</div>
+{/if}
diff --git a/test/runtime/samples/action-update-before-destroy/_config.js b/test/runtime/samples/action-update-before-destroy/_config.js
new file mode 100644
index 0000000000..a822c4d8a5
--- /dev/null
+++ b/test/runtime/samples/action-update-before-destroy/_config.js
@@ -0,0 +1,16 @@
+export default {
+	html: `
+		<button>Click Me</button>
+		<div>1</div>
+	`,
+	async test({ assert, target, window }) {
+		const button = target.querySelector('button');
+		const event = new window.MouseEvent('click');
+		const messages = [];
+		const log = console.log;
+		console.log = msg => messages.push(msg);
+		await button.dispatchEvent(event);
+		console.log = log;
+		assert.deepEqual(messages, ['afterUpdate', 'onDestroy']);
+	}
+};
diff --git a/test/runtime/samples/action-update-before-destroy/main.svelte b/test/runtime/samples/action-update-before-destroy/main.svelte
new file mode 100644
index 0000000000..7f99ce0f38
--- /dev/null
+++ b/test/runtime/samples/action-update-before-destroy/main.svelte
@@ -0,0 +1,10 @@
+<script>
+	import { writable } from 'svelte/store';
+  import Component from "./Component.svelte";
+
+	let items = writable({ 1: { id: 1 } });
+</script>
+
+{#each Object.values($items) as item (item.id)}
+  <Component id="{item.id}" {items} />
+{/each}

From e3e912ab58033c8f4e2b669bc923e2ce30134b8f Mon Sep 17 00:00:00 2001
From: brunnerh <brunnerh@users.noreply.github.com>
Date: Wed, 22 Feb 2023 09:51:26 +0100
Subject: [PATCH 56/61] Fix accessibility of options tutorial. (#8308)

Use button instead of non-interactive element (div).
(Removes a Svelte a11y warning.)
---
 .../08-svelte-options/app-a/Todo.svelte            | 14 ++++++++------
 .../08-svelte-options/app-b/Todo.svelte            | 14 ++++++++------
 2 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/site/content/tutorial/16-special-elements/08-svelte-options/app-a/Todo.svelte b/site/content/tutorial/16-special-elements/08-svelte-options/app-a/Todo.svelte
index 57d4dcc79a..cc3856316c 100644
--- a/site/content/tutorial/16-special-elements/08-svelte-options/app-a/Todo.svelte
+++ b/site/content/tutorial/16-special-elements/08-svelte-options/app-a/Todo.svelte
@@ -4,22 +4,24 @@
 
 	export let todo;
 
-	let div;
+	let button;
 
 	afterUpdate(() => {
-		flash(div);
+		flash(button);
 	});
 </script>
 
 <!-- the text will flash red whenever
      the `todo` object changes -->
-<div bind:this={div} on:click>
+<button bind:this={button} type="button" on:click>
 	{todo.done ? '👍': ''} {todo.text}
-</div>
+</button>
 
 <style>
-	div {
+	button {
+		all: unset;
+		display: block;
 		cursor: pointer;
 		line-height: 1.5;
 	}
-</style>
\ No newline at end of file
+</style>
diff --git a/site/content/tutorial/16-special-elements/08-svelte-options/app-b/Todo.svelte b/site/content/tutorial/16-special-elements/08-svelte-options/app-b/Todo.svelte
index fa81d35989..848f167d02 100644
--- a/site/content/tutorial/16-special-elements/08-svelte-options/app-b/Todo.svelte
+++ b/site/content/tutorial/16-special-elements/08-svelte-options/app-b/Todo.svelte
@@ -6,22 +6,24 @@
 
 	export let todo;
 
-	let div;
+	let button;
 
 	afterUpdate(() => {
-		flash(div);
+		flash(button);
 	});
 </script>
 
 <!-- the text will flash red whenever
      the `todo` object changes -->
-<div bind:this={div} on:click>
+<button bind:this={button} type="button" on:click>
 	{todo.done ? '👍': ''} {todo.text}
-</div>
+</button>
 
 <style>
-	div {
+	button {
+		all: unset;
+		display: block;
 		cursor: pointer;
 		line-height: 1.5;
 	}
-</style>
\ No newline at end of file
+</style>

From a71b8b99585bd636dd0e3ea250c9a092afb0533d Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Wed, 22 Feb 2023 16:18:36 +0100
Subject: [PATCH 57/61] chore: improve parser performance (#8303)

- fast path for attribute quote marks common case
- all regexes exclusively passed into read or match_regex which are only successful if matched at the beginning are altered so that the regex has this condition built in, preventing it from searching past the start index

---------

Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
---
 src/compiler/parse/index.ts          |  8 ++++++++
 src/compiler/parse/read/script.ts    |  3 ++-
 src/compiler/parse/read/style.ts     |  5 +++--
 src/compiler/parse/state/mustache.ts |  2 +-
 src/compiler/parse/state/tag.ts      | 19 ++++++++++---------
 5 files changed, 24 insertions(+), 13 deletions(-)

diff --git a/src/compiler/parse/index.ts b/src/compiler/parse/index.ts
index 8de6563c8b..86c27b33cf 100644
--- a/src/compiler/parse/index.ts
+++ b/src/compiler/parse/index.ts
@@ -132,6 +132,10 @@ export class Parser {
 		return this.template.slice(this.index, this.index + str.length) === str;
 	}
 
+	/**
+	 * Match a regex at the current index
+	 * @param pattern Should have a ^ anchor at the start so the regex doesn't search past the beginning, resulting in worse performance
+	 */
 	match_regex(pattern: RegExp) {
 		const match = pattern.exec(this.template.slice(this.index));
 		if (!match || match.index !== 0) return null;
@@ -148,6 +152,10 @@ export class Parser {
 		}
 	}
 
+	/**
+	 * Search for a regex starting at the current index and return the result if it matches
+	 * @param pattern Should have a ^ anchor at the start so the regex doesn't search past the beginning, resulting in worse performance
+	 */
 	read(pattern: RegExp) {
 		const result = this.match_regex(pattern);
 		if (result) this.index += result.length;
diff --git a/src/compiler/parse/read/script.ts b/src/compiler/parse/read/script.ts
index 02506ab3d5..43974c26ab 100644
--- a/src/compiler/parse/read/script.ts
+++ b/src/compiler/parse/read/script.ts
@@ -6,6 +6,7 @@ import parser_errors from '../errors';
 import { regex_not_newline_characters } from '../../utils/patterns';
 
 const regex_closing_script_tag = /<\/script\s*>/;
+const regex_starts_with_closing_script_tag = /^<\/script\s*>/;
 
 function get_context(parser: Parser, attributes: any[], start: number): string {
 	const context = attributes.find(attribute => attribute.name === 'context');
@@ -32,7 +33,7 @@ export default function read_script(parser: Parser, start: number, attributes: N
 	}
 
 	const source = parser.template.slice(0, script_start).replace(regex_not_newline_characters, ' ') + data;
-	parser.read(regex_closing_script_tag);
+	parser.read(regex_starts_with_closing_script_tag);
 
 	let ast: Program;
 
diff --git a/src/compiler/parse/read/style.ts b/src/compiler/parse/read/style.ts
index 560d377cec..3ed510c3d0 100644
--- a/src/compiler/parse/read/style.ts
+++ b/src/compiler/parse/read/style.ts
@@ -7,6 +7,7 @@ import { Style } from '../../interfaces';
 import parser_errors from '../errors';
 
 const regex_closing_style_tag = /<\/style\s*>/;
+const regex_starts_with_closing_style_tag = /^<\/style\s*>/;
 
 export default function read_style(parser: Parser, start: number, attributes: Node[]): Style {
 	const content_start = parser.index;
@@ -21,7 +22,7 @@ export default function read_style(parser: Parser, start: number, attributes: No
 
 	// discard styles when css is disabled
 	if (parser.css_mode === 'none') {
-		parser.read(regex_closing_style_tag);
+		parser.read(regex_starts_with_closing_style_tag);
 		return null;
 	}
 
@@ -76,7 +77,7 @@ export default function read_style(parser: Parser, start: number, attributes: No
 		}
 	});
 
-	parser.read(regex_closing_style_tag);
+	parser.read(regex_starts_with_closing_style_tag);
   
 	const end = parser.index;
 
diff --git a/src/compiler/parse/state/mustache.ts b/src/compiler/parse/state/mustache.ts
index c3b58afe2a..328a043677 100644
--- a/src/compiler/parse/state/mustache.ts
+++ b/src/compiler/parse/state/mustache.ts
@@ -33,7 +33,7 @@ function trim_whitespace(block: TemplateNode, trim_before: boolean, trim_after:
 	}
 }
 
-const regex_whitespace_with_closing_curly_brace = /\s*}/;
+const regex_whitespace_with_closing_curly_brace = /^\s*}/;
 
 export default function mustache(parser: Parser) {
 	const start = parser.index;
diff --git a/src/compiler/parse/state/tag.ts b/src/compiler/parse/state/tag.ts
index 9d1bf5e5c2..efcff645a7 100644
--- a/src/compiler/parse/state/tag.ts
+++ b/src/compiler/parse/state/tag.ts
@@ -12,6 +12,9 @@ import { closing_tag_omitted, decode_character_references } from '../utils/html'
 // eslint-disable-next-line no-useless-escape
 const valid_tag_name = /^\!?[a-zA-Z]{1,}:?[a-zA-Z0-9\-]*/;
 
+/** Invalid attribute characters if the attribute is not surrounded by quotes */
+const regex_starts_with_invalid_attr_value = /^(\/>|[\s"'=<>`])/;
+
 const meta_tags = new Map([
 	['svelte:head', 'Head'],
 	['svelte:options', 'Options'],
@@ -293,7 +296,7 @@ function read_tag_name(parser: Parser) {
 
 // eslint-disable-next-line no-useless-escape
 const regex_token_ending_character = /[\s=\/>"']/;
-const regex_quote_characters = /["']/;
+const regex_starts_with_quote_characters = /^["']/;
 
 function read_attribute(parser: Parser, unique_names: Set<string>) {
 	const start = parser.index;
@@ -368,7 +371,7 @@ function read_attribute(parser: Parser, unique_names: Set<string>) {
 		parser.allow_whitespace();
 		value = read_attribute_value(parser);
 		end = parser.index;
-	} else if (parser.match_regex(regex_quote_characters)) {
+	} else if (parser.match_regex(regex_starts_with_quote_characters)) {
 		parser.error(parser_errors.unexpected_token('='), parser.index);
 	}
 
@@ -475,15 +478,13 @@ function read_attribute_value(parser: Parser) {
 		}];
 	}
 
-	const regex = (
-		quote_mark === "'" ? /'/ :
-			quote_mark === '"' ? /"/ :
-				/(\/>|[\s"'=<>`])/
-	);
-
 	let value;
 	try {
-		value = read_sequence(parser, () => !!parser.match_regex(regex), 'in attribute value');
+		value = read_sequence(parser, () => {
+			// handle common case of quote marks existing outside of regex for performance reasons
+			if (quote_mark) return parser.match(quote_mark);
+			return !!parser.match_regex(regex_starts_with_invalid_attr_value);
+		}, 'in attribute value');
 	} catch (error) {
 		if (error.code === 'parse-error') {
 			// if the attribute value didn't close + self-closing tag

From 35599972233dceee9d2074ad85ebac9f5a43730a Mon Sep 17 00:00:00 2001
From: ngtr6788 <88808276+ngtr6788@users.noreply.github.com>
Date: Wed, 22 Feb 2023 11:14:21 -0500
Subject: [PATCH 58/61] feat: implement a11y
 `aria-activedescendant-has-tabindex` (#8172)

#820
---
 site/content/docs/06-accessibility-warnings.md  | 12 ++++++++++++
 src/compiler/compile/compiler_warnings.ts       |  4 ++++
 src/compiler/compile/nodes/Element.ts           |  5 +++++
 .../a11y-aria-activedescendant/input.svelte     | 17 +++++++++++++++++
 .../a11y-aria-activedescendant/warnings.json    | 17 +++++++++++++++++
 5 files changed, 55 insertions(+)
 create mode 100644 test/validator/samples/a11y-aria-activedescendant/input.svelte
 create mode 100644 test/validator/samples/a11y-aria-activedescendant/warnings.json

diff --git a/site/content/docs/06-accessibility-warnings.md b/site/content/docs/06-accessibility-warnings.md
index 8d3d44a94e..7aa3873cce 100644
--- a/site/content/docs/06-accessibility-warnings.md
+++ b/site/content/docs/06-accessibility-warnings.md
@@ -19,6 +19,18 @@ Enforce no `accesskey` on element. Access keys are HTML attributes that allow we
 
 ---
 
+### `a11y-aria-activedescendant-has-tabindex`
+
+An element with `aria-activedescendant` must be tabbable, so it must either have an inherent `tabindex` or declare `tabindex` as an attribute.
+
+```sv
+<!-- A11y: Elements with attribute aria-activedescendant should have tabindex value -->
+<div aria-activedescendant="some-id" />
+
+```
+
+---
+
 ### `a11y-aria-attributes`
 
 Certain reserved DOM elements do not support ARIA roles, states and properties. This is often because they are not visible, for example `meta`, `html`, `script`, `style`. This rule enforces that these DOM elements do not contain the `aria-*` props.
diff --git a/src/compiler/compile/compiler_warnings.ts b/src/compiler/compile/compiler_warnings.ts
index 3f552eb8b8..a10fe6155c 100644
--- a/src/compiler/compile/compiler_warnings.ts
+++ b/src/compiler/compile/compiler_warnings.ts
@@ -187,6 +187,10 @@ export default {
 		code: 'a11y-no-noninteractive-tabindex',
 		message: 'A11y: noninteractive element cannot have nonnegative tabIndex value'
 	},
+	a11y_aria_activedescendant_has_tabindex: {
+		code: 'a11y-aria-activedescendant-has-tabindex',
+		message: 'A11y: Elements with attribute aria-activedescendant should have tabindex value'
+	},
 	redundant_event_modifier_for_touch: {
 		code: 'redundant-event-modifier',
 		message: 'Touch event handlers that don\'t use the \'event\' object are passive by default'
diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts
index 62e0de51bf..8635355a12 100644
--- a/src/compiler/compile/nodes/Element.ts
+++ b/src/compiler/compile/nodes/Element.ts
@@ -484,6 +484,11 @@ export default class Element extends Node {
 						component.warn(attribute, compiler_warnings.a11y_incorrect_attribute_type(schema, name));
 					}
 				}
+
+				// aria-activedescendant-has-tabindex
+				if (name === 'aria-activedescendant' && !is_interactive_element(this.name, attribute_map) && !attribute_map.has('tabindex')) {
+			    component.warn(attribute, compiler_warnings.a11y_aria_activedescendant_has_tabindex);
+				}
 			}
 
 			// aria-role
diff --git a/test/validator/samples/a11y-aria-activedescendant/input.svelte b/test/validator/samples/a11y-aria-activedescendant/input.svelte
new file mode 100644
index 0000000000..22570e8c50
--- /dev/null
+++ b/test/validator/samples/a11y-aria-activedescendant/input.svelte
@@ -0,0 +1,17 @@
+<!-- VALID -->
+<input />
+<input tabindex="0" />
+<input aria-activedescendant="some-id" />
+<input aria-activedescendant="some-id" tabindex={0} />
+<input aria-activedescendant="some-id" tabindex={1} />
+<input aria-activedescendant="some-id" tabindex="0" />
+<input aria-activedescendant="some-id" tabindex={-1} />
+<input aria-activedescendant="some-id" tabindex="-1" />
+
+<div />
+<div aria-activedescendant="some-id" role="tablist" tabindex={-1} />
+<div aria-activedescendant="some-id" role="tablist" tabindex="-1" />
+
+<!-- INVALID -->
+<div aria-activedescendant="some-id" />
+
diff --git a/test/validator/samples/a11y-aria-activedescendant/warnings.json b/test/validator/samples/a11y-aria-activedescendant/warnings.json
new file mode 100644
index 0000000000..8749c1c125
--- /dev/null
+++ b/test/validator/samples/a11y-aria-activedescendant/warnings.json
@@ -0,0 +1,17 @@
+[
+  {
+    "code": "a11y-aria-activedescendant-has-tabindex",
+    "end": {
+      "character": 568,
+      "column": 36,
+      "line": 16
+    },
+    "message": "A11y: Elements with attribute aria-activedescendant should have tabindex value",
+    "pos": 537,
+    "start": {
+      "character": 537,
+      "column": 5,
+      "line": 16
+    }
+  }
+]

From c9a269c149cf968e5e21946fff8a3d14fa972058 Mon Sep 17 00:00:00 2001
From: Vaibhav <vibovenkat@gmail.com>
Date: Wed, 22 Feb 2023 10:19:33 -0600
Subject: [PATCH 59/61] fix: silence no content a11y warning if the tag has an
 aria-label (#8299)

fixes #8296

---------

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
---
 src/compiler/compile/nodes/Element.ts                  | 10 ++++++++++
 .../a11y-anchor-aria-label-has-no-content/input.svelte |  1 +
 .../warnings.json                                      |  1 +
 3 files changed, 12 insertions(+)
 create mode 100644 test/validator/samples/a11y-anchor-aria-label-has-no-content/input.svelte
 create mode 100644 test/validator/samples/a11y-anchor-aria-label-has-no-content/warnings.json

diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts
index 8635355a12..4d1cb758fe 100644
--- a/src/compiler/compile/nodes/Element.ts
+++ b/src/compiler/compile/nodes/Element.ts
@@ -225,6 +225,7 @@ export default class Element extends Node {
 	namespace: string;
 	needs_manual_style_scoping: boolean;
 	tag_expr: Expression;
+	contains_a11y_label: boolean;
 
 	get is_dynamic_element() {
 		return this.name === 'svelte:element';
@@ -625,6 +626,7 @@ export default class Element extends Node {
 			const id_attribute = attribute_map.get('id');
 			const name_attribute = attribute_map.get('name');
 			const target_attribute = attribute_map.get('target');
+			const aria_label_attribute = attribute_map.get('aria-label');
 
 			// links with target="_blank" should have noopener or noreferrer: https://developer.chrome.com/docs/lighthouse/best-practices/external-anchors-use-rel-noopener/
 			// modern browsers add noopener by default, so we only need to check legacy browsers
@@ -647,6 +649,13 @@ export default class Element extends Node {
 				}
 			}
 
+			if (aria_label_attribute) {
+				const aria_value = aria_label_attribute.get_static_value();
+				if (aria_value != '') {
+					this.contains_a11y_label = true;
+				}
+			}
+
 			if (href_attribute) {
 				const href_value = href_attribute.get_static_value();
 
@@ -930,6 +939,7 @@ export default class Element extends Node {
 
 	validate_content() {
 		if (!a11y_required_content.has(this.name)) return;
+		if (this.contains_a11y_label) return;
 		if (
 			this.bindings
 				.some((binding) => ['textContent', 'innerHTML'].includes(binding.name))
diff --git a/test/validator/samples/a11y-anchor-aria-label-has-no-content/input.svelte b/test/validator/samples/a11y-anchor-aria-label-has-no-content/input.svelte
new file mode 100644
index 0000000000..c13df04b22
--- /dev/null
+++ b/test/validator/samples/a11y-anchor-aria-label-has-no-content/input.svelte
@@ -0,0 +1 @@
+<a href="/foo" aria-label="baz"></a>
diff --git a/test/validator/samples/a11y-anchor-aria-label-has-no-content/warnings.json b/test/validator/samples/a11y-anchor-aria-label-has-no-content/warnings.json
new file mode 100644
index 0000000000..fe51488c70
--- /dev/null
+++ b/test/validator/samples/a11y-anchor-aria-label-has-no-content/warnings.json
@@ -0,0 +1 @@
+[]

From 53de73d08cdf2fb62dca7949767f120f3fac9629 Mon Sep 17 00:00:00 2001
From: Tan Li Hau <tanhauhau@users.noreply.github.com>
Date: Thu, 23 Feb 2023 03:02:42 +0800
Subject: [PATCH 60/61] feat: simpler output for reactive vars if dependencies
 are all static (#7942)

---
 src/compiler/compile/Component.ts             | 19 +++++-
 src/compiler/compile/render_dom/index.ts      | 17 ++++--
 src/compiler/compile/render_dom/invalidate.ts |  1 +
 src/compiler/interfaces.ts                    |  1 +
 .../reactive-class-optimized/expected.js      | 11 +---
 test/js/samples/reactive-values/expected.js   | 60 +++++++++++++++++++
 test/js/samples/reactive-values/input.svelte  |  7 +++
 7 files changed, 101 insertions(+), 15 deletions(-)
 create mode 100644 test/js/samples/reactive-values/expected.js
 create mode 100644 test/js/samples/reactive-values/input.svelte

diff --git a/src/compiler/compile/Component.ts b/src/compiler/compile/Component.ts
index c0d703892b..ffac6e1f07 100644
--- a/src/compiler/compile/Component.ts
+++ b/src/compiler/compile/Component.ts
@@ -38,6 +38,7 @@ import compiler_warnings from './compiler_warnings';
 import compiler_errors from './compiler_errors';
 import { extract_ignores_above_position, extract_svelte_ignore_from_comments } from '../utils/extract_svelte_ignore';
 import check_enable_sourcemap from './utils/check_enable_sourcemap';
+import is_dynamic from './render_dom/wrappers/shared/is_dynamic';
 
 interface ComponentOptions {
 	namespace?: string;
@@ -1380,12 +1381,11 @@ export default class Component {
 										module_dependencies.add(name);
 									}
 								}
-								const is_writable_or_mutated =
-									variable && (variable.writable || variable.mutated);
+
 								if (
 									should_add_as_dependency &&
 									(!owner || owner === component.instance_scope) &&
-									(name[0] === '$' || is_writable_or_mutated)
+									(name[0] === '$' || variable)
 								) {
 									dependencies.add(name);
 								}
@@ -1409,6 +1409,19 @@ export default class Component {
 				const { expression } = node.body as ExpressionStatement;
 				const declaration = expression && (expression as AssignmentExpression).left;
 
+				const is_dependency_static = Array.from(dependencies).every(
+					dependency => dependency !== '$$props' && dependency !== '$$restProps' && !is_dynamic(this.var_lookup.get(dependency))
+				);
+
+				if (is_dependency_static) {
+					assignees.forEach(assignee => {
+						const variable = component.var_lookup.get(assignee);
+						if (variable) {
+							variable.is_reactive_static = true;
+						}
+					});
+				}
+
 				unsorted_reactive_declarations.push({
 					assignees,
 					dependencies,
diff --git a/src/compiler/compile/render_dom/index.ts b/src/compiler/compile/render_dom/index.ts
index 58b7a8317b..bc56f2eb27 100644
--- a/src/compiler/compile/render_dom/index.ts
+++ b/src/compiler/compile/render_dom/index.ts
@@ -390,13 +390,13 @@ export default function dom(
 	const resubscribable_reactive_store_unsubscribers = reactive_stores
 		.filter(store => {
 			const variable = component.var_lookup.get(store.name.slice(1));
-			return variable && (variable.reassigned || variable.export_name);
+			return variable && (variable.reassigned || variable.export_name) && !variable.is_reactive_static;
 		})
 		.map(({ name }) => b`$$self.$$.on_destroy.push(() => ${`$$unsubscribe_${name.slice(1)}`}());`);
 
 	if (has_definition) {
-		const reactive_declarations: (Node | Node[]) = [];
-		const fixed_reactive_declarations: Node[] = []; // not really 'reactive' but whatever
+		const reactive_declarations: Node[] = [];
+		const fixed_reactive_declarations: Array<Node | Node[]> = []; // not really 'reactive' but whatever
 
 		component.reactive_declarations.forEach(d => {
 			const dependencies = Array.from(d.dependencies);
@@ -417,6 +417,15 @@ export default function dom(
 				reactive_declarations.push(statement);
 			} else {
 				fixed_reactive_declarations.push(statement);
+				for (const assignee of d.assignees) {
+					const variable = component.var_lookup.get(assignee);
+					if (variable && variable.subscribable) {
+						fixed_reactive_declarations.push(b`
+							${component.compile_options.dev && b`@validate_store(${assignee}, '${assignee}');`}
+							@component_subscribe($$self, ${assignee}, $$value => $$invalidate(${renderer.context_lookup.get('$' + assignee).index}, ${'$' + assignee} = $$value));
+						`);
+					}
+				}
 			}
 		});
 
@@ -430,7 +439,7 @@ export default function dom(
 			const name = $name.slice(1);
 
 			const store = component.var_lookup.get(name);
-			if (store && (store.reassigned || store.export_name)) {
+			if (store && (store.reassigned || store.export_name) && !store.is_reactive_static) {
 				const unsubscribe = `$$unsubscribe_${name}`;
 				const subscribe = `$$subscribe_${name}`;
 				const i = renderer.context_lookup.get($name).index;
diff --git a/src/compiler/compile/render_dom/invalidate.ts b/src/compiler/compile/render_dom/invalidate.ts
index ffc5b6b42e..d9efdb5142 100644
--- a/src/compiler/compile/render_dom/invalidate.ts
+++ b/src/compiler/compile/render_dom/invalidate.ts
@@ -19,6 +19,7 @@ export function invalidate(renderer: Renderer, scope: Scope, node: Node, names:
 				!variable.hoistable &&
 				!variable.global &&
 				!variable.module &&
+				!variable.is_reactive_static &&
 				(
 					variable.referenced ||
 					variable.subscribable ||
diff --git a/src/compiler/interfaces.ts b/src/compiler/interfaces.ts
index eb2cc336ed..402f9ff5e1 100644
--- a/src/compiler/interfaces.ts
+++ b/src/compiler/interfaces.ts
@@ -223,6 +223,7 @@ export interface Var {
 	subscribable?: boolean;
 	is_reactive_dependency?: boolean;
 	imported?: boolean;
+	is_reactive_static?: boolean;
 }
 
 export interface CssResult {
diff --git a/test/js/samples/reactive-class-optimized/expected.js b/test/js/samples/reactive-class-optimized/expected.js
index 1d0606ad60..f75a4015b0 100644
--- a/test/js/samples/reactive-class-optimized/expected.js
+++ b/test/js/samples/reactive-class-optimized/expected.js
@@ -9,7 +9,6 @@ import {
 	noop,
 	safe_not_equal,
 	space,
-	subscribe,
 	toggle_class
 } from "svelte/internal";
 
@@ -133,13 +132,8 @@ let reactiveModuleVar = Math.random();
 function instance($$self, $$props, $$invalidate) {
 	let reactiveDeclaration;
 	let $reactiveStoreVal;
-
-	let $reactiveDeclaration,
-		$$unsubscribe_reactiveDeclaration = noop,
-		$$subscribe_reactiveDeclaration = () => ($$unsubscribe_reactiveDeclaration(), $$unsubscribe_reactiveDeclaration = subscribe(reactiveDeclaration, $$value => $$invalidate(3, $reactiveDeclaration = $$value)), reactiveDeclaration);
-
+	let $reactiveDeclaration;
 	component_subscribe($$self, reactiveStoreVal, $$value => $$invalidate(2, $reactiveStoreVal = $$value));
-	$$self.$$.on_destroy.push(() => $$unsubscribe_reactiveDeclaration());
 	nonReactiveGlobal = Math.random();
 	const reactiveConst = { x: Math.random() };
 	reactiveModuleVar += 1;
@@ -148,7 +142,8 @@ function instance($$self, $$props, $$invalidate) {
 		reactiveConst.x += 1;
 	}
 
-	$: $$subscribe_reactiveDeclaration($$invalidate(1, reactiveDeclaration = reactiveModuleVar * 2));
+	$: reactiveDeclaration = reactiveModuleVar * 2;
+	component_subscribe($$self, reactiveDeclaration, $$value => $$invalidate(3, $reactiveDeclaration = $$value));
 	return [reactiveConst, reactiveDeclaration, $reactiveStoreVal, $reactiveDeclaration];
 }
 
diff --git a/test/js/samples/reactive-values/expected.js b/test/js/samples/reactive-values/expected.js
new file mode 100644
index 0000000000..7ed435d6ad
--- /dev/null
+++ b/test/js/samples/reactive-values/expected.js
@@ -0,0 +1,60 @@
+/* generated by Svelte vX.Y.Z */
+import {
+	SvelteComponent,
+	detach,
+	element,
+	init,
+	insert,
+	noop,
+	safe_not_equal,
+	set_data,
+	space,
+	text
+} from "svelte/internal";
+
+function create_fragment(ctx) {
+	let h1;
+	let t3;
+	let t4;
+
+	return {
+		c() {
+			h1 = element("h1");
+			h1.textContent = `Hello ${name}!`;
+			t3 = space();
+			t4 = text(/*foo*/ ctx[0]);
+		},
+		m(target, anchor) {
+			insert(target, h1, anchor);
+			insert(target, t3, anchor);
+			insert(target, t4, anchor);
+		},
+		p(ctx, [dirty]) {
+			if (dirty & /*foo*/ 1) set_data(t4, /*foo*/ ctx[0]);
+		},
+		i: noop,
+		o: noop,
+		d(detaching) {
+			if (detaching) detach(h1);
+			if (detaching) detach(t3);
+			if (detaching) detach(t4);
+		}
+	};
+}
+
+let name = 'world';
+
+function instance($$self) {
+	let foo;
+	$: foo = name + name;
+	return [foo];
+}
+
+class Component extends SvelteComponent {
+	constructor(options) {
+		super();
+		init(this, options, instance, create_fragment, safe_not_equal, {});
+	}
+}
+
+export default Component;
\ No newline at end of file
diff --git a/test/js/samples/reactive-values/input.svelte b/test/js/samples/reactive-values/input.svelte
new file mode 100644
index 0000000000..d713217771
--- /dev/null
+++ b/test/js/samples/reactive-values/input.svelte
@@ -0,0 +1,7 @@
+<script>
+	let name = 'world';
+	$: foo = name + name;
+</script>
+
+<h1>Hello {name}!</h1>
+{foo}
\ No newline at end of file

From 709264a94cbd29093349ac86e3edd0acc6af46b0 Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Wed, 22 Feb 2023 20:08:46 +0100
Subject: [PATCH 61/61] chore: update changelog

---
 CHANGELOG.md | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9a47296f80..f240db6dce 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,12 +2,18 @@
 
 ## Unreleased
 
+* Add a11y warnings:
+	* `aria-activedescendant-has-tabindex`: elements with `aria-activedescendant` need to have a `tabindex` ([#8172](https://github.com/sveltejs/svelte/pull/8172))
+	* 
+* Omit a11y warning on `<video>` tags with `aria-hidden="true"` ([#7874](https://github.com/sveltejs/svelte/issues/7874))
+* Omit a11y "no child content" warning on elements with `aria-label` ([#8299](https://github.com/sveltejs/svelte/pull/8299))
 * Make `noreferrer` warning less zealous ([#6289](https://github.com/sveltejs/svelte/issues/6289))
 * `trusted-types` CSP compatibility for Web Components ([#8134](https://github.com/sveltejs/svelte/issues/8134))
 * Add `data-sveltekit-replacestate` and `data-sveltekit-keepfocus` attribute typings ([#8281](https://github.com/sveltejs/svelte/issues/8281))
 * Don't throw when calling `unsubscribe` twice ([#8186](https://github.com/sveltejs/svelte/pull/8186))
 * Detect unused empty attribute CSS selectors ([#8042](https://github.com/sveltejs/svelte/issues/8042))
-* Omit a11y warning on `<video>` tags with `aria-hidden="true"` ([#7874](https://github.com/sveltejs/svelte/issues/7874))
+* Simpler output for reactive statements if dependencies are all static ([#7942](https://github.com/sveltejs/svelte/pull/7942))
+* Flush remaining `afterUpdate` calls before `onDestroy` ([#7476](https://github.com/sveltejs/svelte/issues/7476))
 
 ## 3.55.1