diff --git a/src/generators/dom/index.js b/src/generators/dom/index.js index 929d737700..de0c5dc496 100644 --- a/src/generators/dom/index.js +++ b/src/generators/dom/index.js @@ -98,9 +98,9 @@ class DomGenerator extends Generator { ` ); } - createAnchor ( name, description = '' ) { + createAnchor ( name ) { this.uses.createComment = true; - const renderStatement = `createComment( ${JSON.stringify( description )} )`; + const renderStatement = `createComment()`; this.addElement( name, renderStatement, true ); } diff --git a/src/generators/dom/visitors/EachBlock.js b/src/generators/dom/visitors/EachBlock.js index 2799a421b8..700e16ef7a 100644 --- a/src/generators/dom/visitors/EachBlock.js +++ b/src/generators/dom/visitors/EachBlock.js @@ -21,7 +21,7 @@ export default { const { dependencies, snippet } = generator.contextualise( node.expression ); const anchor = `${name}_anchor`; - generator.createAnchor( anchor, `#each ${generator.source.slice( node.expression.start, node.expression.end )}` ); + generator.createAnchor( anchor ); generator.current.builders.init.addLine( `var ${name}_value = ${snippet};` ); generator.current.builders.init.addLine( `var ${iterations} = [];` ); diff --git a/src/generators/dom/visitors/IfBlock.js b/src/generators/dom/visitors/IfBlock.js index 02133e539d..5ceb42d48b 100644 --- a/src/generators/dom/visitors/IfBlock.js +++ b/src/generators/dom/visitors/IfBlock.js @@ -41,7 +41,7 @@ export default { const conditionsAndBlocks = getConditionsAndBlocks( generator, node, generator.getUniqueName( `renderIfBlock` ) ); const anchor = `${name}_anchor`; - generator.createAnchor( anchor, `#if ${generator.source.slice( node.expression.start, node.expression.end )}` ); + generator.createAnchor( anchor ); generator.current.builders.init.addBlock( deindent` function ${getBlock} ( ${params} ) { diff --git a/src/generators/dom/visitors/YieldTag.js b/src/generators/dom/visitors/YieldTag.js index 5fefcd73a3..98996486c1 100644 --- a/src/generators/dom/visitors/YieldTag.js +++ b/src/generators/dom/visitors/YieldTag.js @@ -1,7 +1,7 @@ export default { enter ( generator ) { const anchor = `yield_anchor`; - generator.createAnchor( anchor, 'yield' ); + generator.createAnchor( anchor ); generator.current.builders.mount.addLine( `component._yield && component._yield.mount( ${generator.current.target}, ${anchor} );` diff --git a/src/shared/dom.js b/src/shared/dom.js index 9d4231572f..4007e90289 100644 --- a/src/shared/dom.js +++ b/src/shared/dom.js @@ -34,8 +34,8 @@ export function createText ( data ) { return document.createTextNode( data ); } -export function createComment ( data ) { - return document.createComment( data ); +export function createComment () { + return document.createComment( '' ); } export function addEventListener ( node, event, handler ) { diff --git a/test/generator/attribute-dynamic-multiple/_config.js b/test/generator/attribute-dynamic-multiple/_config.js index 83c6a58a86..1a0c602cb6 100644 --- a/test/generator/attribute-dynamic-multiple/_config.js +++ b/test/generator/attribute-dynamic-multiple/_config.js @@ -7,5 +7,5 @@ export default { ] }, - html: `
one
two
three
one
two
three
one
four
three
one
four
three
one
four
five
one
four
five
one
two
three
one
two
three
one
four
three
one
four
three
one
four
five
one
four
five
Hello
World
World
0: adder
1: blue whale
2: chameleon
` + html: `0: adder
1: blue whale
2: chameleon
` }; diff --git a/test/generator/each-block/_config.js b/test/generator/each-block/_config.js index 959bf88c04..655556bedf 100644 --- a/test/generator/each-block/_config.js +++ b/test/generator/each-block/_config.js @@ -2,11 +2,11 @@ export default { data: { animals: [ 'alpaca', 'baboon', 'capybara' ] }, - html: 'alpaca
baboon
capybara
', + html: 'alpaca
baboon
capybara
', test ( assert, component, target ) { component.set({ animals: [ 'alpaca', 'baboon', 'caribou', 'dogfish' ] }); - assert.equal( target.innerHTML, 'alpaca
baboon
caribou
dogfish
' ); + assert.equal( target.innerHTML, 'alpaca
baboon
caribou
dogfish
' ); component.set({ animals: [] }); - assert.equal( target.innerHTML, '' ); + assert.equal( target.innerHTML, '' ); } }; diff --git a/test/generator/each-blocks-expression/_config.js b/test/generator/each-blocks-expression/_config.js index b610b055b4..239a18b6dc 100644 --- a/test/generator/each-blocks-expression/_config.js +++ b/test/generator/each-blocks-expression/_config.js @@ -1,3 +1,3 @@ export default { - html: `a
b
c
` + html: `a
b
c
` }; diff --git a/test/generator/each-blocks-nested-b/_config.js b/test/generator/each-blocks-nested-b/_config.js index 806284ef2d..1ba0f685b8 100644 --- a/test/generator/each-blocks-nested-b/_config.js +++ b/test/generator/each-blocks-nested-b/_config.js @@ -28,7 +28,7 @@ export default { } ] }, - html: `animals: aardvark
animals: buffalo
animals: chinchilla
countries: albania
countries: brazil
countries: china
people: alice
people: bob
people: carol
people: dave
`, + html: `animals: aardvark
animals: buffalo
animals: chinchilla
countries: albania
countries: brazil
countries: china
people: alice
people: bob
people: carol
people: dave
`, test ( assert, component, target ) { // TODO } diff --git a/test/generator/each-blocks-nested/_config.js b/test/generator/each-blocks-nested/_config.js index 0c21561e75..5486c8274e 100644 --- a/test/generator/each-blocks-nested/_config.js +++ b/test/generator/each-blocks-nested/_config.js @@ -4,7 +4,7 @@ export default { rows: [ 1, 2, 3 ] }, - html: `hello!
' ); + assert.equal( target.innerHTML, '\n\nhello!
' ); button.dispatchEvent( event ); - assert.equal( target.innerHTML, '\n\n' ); + assert.equal( target.innerHTML, '\n\n' ); } }; diff --git a/test/generator/if-block-widget/_config.js b/test/generator/if-block-widget/_config.js index 674fefb0ba..40d9d050e9 100644 --- a/test/generator/if-block-widget/_config.js +++ b/test/generator/if-block-widget/_config.js @@ -2,11 +2,11 @@ export default { data: { visible: true }, - html: 'before\nWidget
\nafter', + html: 'before\nWidget
\nafter', test ( assert, component, target ) { component.set({ visible: false }); - assert.equal( target.innerHTML, 'before\n\nafter' ); + assert.equal( target.innerHTML, 'before\n\nafter' ); component.set({ visible: true }); - assert.equal( target.innerHTML, 'before\nWidget
\nafter' ); + assert.equal( target.innerHTML, 'before\nWidget
\nafter' ); } }; diff --git a/test/generator/if-block/_config.js b/test/generator/if-block/_config.js index f8014c5c9a..4194fd29bc 100644 --- a/test/generator/if-block/_config.js +++ b/test/generator/if-block/_config.js @@ -2,11 +2,11 @@ export default { data: { visible: true }, - html: 'i am visible
', + html: 'i am visible
', test ( assert, component, target ) { component.set({ visible: false }); - assert.equal( target.innerHTML, '' ); + assert.equal( target.innerHTML, '' ); component.set({ visible: true }); - assert.equal( target.innerHTML, 'i am visible
' ); + assert.equal( target.innerHTML, 'i am visible
' ); } };