From 524b74a456e36649d5c2b9874df024165c0229bf Mon Sep 17 00:00:00 2001 From: TheCymaera <69355340+TheCymaera@users.noreply.github.com> Date: Fri, 11 Nov 2022 21:59:35 +0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20Clean=20up?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../compile/render_dom/wrappers/Element/index.ts | 15 +++++++++------ src/runtime/internal/ResizeObserverSingleton.ts | 3 ++- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/compiler/compile/render_dom/wrappers/Element/index.ts b/src/compiler/compile/render_dom/wrappers/Element/index.ts index d38fbf532d..e77e444266 100644 --- a/src/compiler/compile/render_dom/wrappers/Element/index.ts +++ b/src/compiler/compile/render_dom/wrappers/Element/index.ts @@ -64,6 +64,7 @@ const events = [ node.name === 'input' && node.get_static_attribute_value('type') === 'range' }, + // resize events { event_names: ['elementresize'], filter: (_node: Element, name: string) => @@ -71,17 +72,19 @@ const events = [ }, { - event_names: ['elementresizeobservecontentbox'], + event_names: ['elementresizecontentbox'], filter: (_node: Element, name: string) => regex_content_rect.test(name) ?? regex_content_box_size.test(name) }, + { - event_names: ['elementresizeobserveborderbox'], + event_names: ['elementresizeborderbox'], filter: (_node: Element, name: string) => regex_border_box_size.test(name) }, + { - event_names: ['elementresizeobservedevicepixelcontentbox'], + event_names: ['elementresizedevicepixelcontentbox'], filter: (_node: Element, name: string) => regex_device_pixel_content_box_size.test(name) }, @@ -706,9 +709,9 @@ export default class ElementWrapper extends Wrapper { binding_group.events.forEach(name => { const resizeListenerFunctions = { elementresize: 'add_iframe_resize_listener', - elementresizeobservecontentbox: 'resize_observer_content_box.observe', - elementresizeobserveborderbox: 'resize_observer_border_box.observe', - elementresizeobservedevicepixelcontentbox: 'resize_observer_device_pixel_content_box.observe' + elementresizecontentbox: 'resize_observer_content_box.observe', + elementresizeborderbox: 'resize_observer_border_box.observe', + elementresizedevicepixelcontentbox: 'resize_observer_device_pixel_content_box.observe' }; if (name in resizeListenerFunctions) { diff --git a/src/runtime/internal/ResizeObserverSingleton.ts b/src/runtime/internal/ResizeObserverSingleton.ts index bd459a39c2..d0f824b8cf 100644 --- a/src/runtime/internal/ResizeObserverSingleton.ts +++ b/src/runtime/internal/ResizeObserverSingleton.ts @@ -1,7 +1,8 @@ const MapImplementation = 'WeakMap' in window ? WeakMap : ('Map' in window ? Map : undefined); /** - * Resize observer singleton + * Resize observer singleton. + * One listener per element only! * https://groups.google.com/a/chromium.org/g/blink-dev/c/z6ienONUb5A/m/F5-VcUZtBAAJ */ export class ResizeObserverSingleton {