From 4fe8d95a6d4963be3512c75ebbe52f5fe6b095e0 Mon Sep 17 00:00:00 2001
From: Rich Harris <richard.a.harris@gmail.com>
Date: Sun, 15 Apr 2018 20:07:08 -0400
Subject: [PATCH] dont typecast numeric attributes

---
 src/generators/nodes/shared/mungeAttribute.ts                 | 2 +-
 src/generators/server-side-rendering/visitors/Component.ts    | 2 +-
 test/helpers.js                                               | 4 ++--
 test/runtime/samples/component-data-static/main.html          | 2 +-
 .../samples/component-data-static/_actual.html                | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/generators/nodes/shared/mungeAttribute.ts b/src/generators/nodes/shared/mungeAttribute.ts
index 1cf85de9b7..9609f58d4b 100644
--- a/src/generators/nodes/shared/mungeAttribute.ts
+++ b/src/generators/nodes/shared/mungeAttribute.ts
@@ -55,7 +55,7 @@ export default function mungeAttribute(attribute: Node, block: Block): MungedAtt
 			return {
 				spread: false,
 				name: attribute.name,
-				value: isNaN(value.data) ? stringify(value.data) : value.data,
+				value: stringify(value.data),
 				dynamic: false,
 				dependencies: []
 			};
diff --git a/src/generators/server-side-rendering/visitors/Component.ts b/src/generators/server-side-rendering/visitors/Component.ts
index 9c7d7ce930..e7325261e3 100644
--- a/src/generators/server-side-rendering/visitors/Component.ts
+++ b/src/generators/server-side-rendering/visitors/Component.ts
@@ -57,7 +57,7 @@ export default function visitComponent(
 		if (attribute.value.length === 1) {
 			const chunk = attribute.value[0];
 			if (chunk.type === 'Text') {
-				return isNaN(chunk.data) ? stringify(chunk.data) : chunk.data;
+				return stringify(chunk.data);
 			}
 
 			block.contextualise(chunk.expression);
diff --git a/test/helpers.js b/test/helpers.js
index 767c4a1132..ee065d3675 100644
--- a/test/helpers.js
+++ b/test/helpers.js
@@ -190,7 +190,7 @@ export function showOutput(cwd, options = {}, compile = svelte.compile) {
 			.replace(/^\d/, '_$&')
 			.replace(/[^a-zA-Z0-9_$]/g, '');
 
-		const { code } = compile(
+		const { js } = compile(
 			fs.readFileSync(`${cwd}/${file}`, 'utf-8'),
 			Object.assign(options, {
 				filename: file,
@@ -200,7 +200,7 @@ export function showOutput(cwd, options = {}, compile = svelte.compile) {
 		);
 
 		console.log( // eslint-disable-line no-console
-			`\n>> ${chalk.cyan.bold(file)}\n${addLineNumbers(code)}\n<< ${chalk.cyan.bold(file)}`
+			`\n>> ${chalk.cyan.bold(file)}\n${addLineNumbers(js.code)}\n<< ${chalk.cyan.bold(file)}`
 		);
 	});
 }
diff --git a/test/runtime/samples/component-data-static/main.html b/test/runtime/samples/component-data-static/main.html
index 0df72c1465..6b62cad8fd 100644
--- a/test/runtime/samples/component-data-static/main.html
+++ b/test/runtime/samples/component-data-static/main.html
@@ -1,5 +1,5 @@
 <div>
-	<Widget foo='bar' baz='42'/>
+	<Widget foo='bar' baz={{42}}/>
 </div>
 
 <script>
diff --git a/test/server-side-rendering/samples/component-data-static/_actual.html b/test/server-side-rendering/samples/component-data-static/_actual.html
index 93f7e1839a..609215404e 100644
--- a/test/server-side-rendering/samples/component-data-static/_actual.html
+++ b/test/server-side-rendering/samples/component-data-static/_actual.html
@@ -1,4 +1,4 @@
 <div>
 	<p>foo: bar</p>
-<p>baz: 42 (number)</p>
+<p>baz: 42 (string)</p>
 </div>
\ No newline at end of file