Merge pull request #1652 from sveltejs/gh-1544-computed-whole-state

exclude current prop in computed properties using entire state #1544
pull/1662/head
Rich Harris 6 years ago committed by GitHub
commit 4ce2e1ddc5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -89,10 +89,8 @@ export default function dom(
} else {
// computed property depends on entire state object —
// these must go at the end
const arg = hasRestParam ? `@exclude(state, "${key}")` : `state`;
computationBuilder.addLine(
`if (this._differs(state.${key}, (state.${key} = %computed-${key}(${arg})))) changed.${key} = true;`
`if (this._differs(state.${key}, (state.${key} = %computed-${key}(@exclude(state, "${key}"))))) changed.${key} = true;`
);
}
});

@ -0,0 +1,25 @@
export default {
html: `
<pre>{"wanted":2}</pre>
`,
test(assert, component, target) {
component.set({
unwanted: 3,
wanted: 4,
});
assert.htmlEqual(target.innerHTML, `
<pre>{"wanted":4}</pre>
`);
component.set({
unwanted: 5,
wanted: 6,
});
assert.htmlEqual(target.innerHTML, `
<pre>{"wanted":6}</pre>
`);
},
};

@ -0,0 +1,22 @@
<pre>{JSON.stringify(props)}</pre>
<script>
export default {
data: () => ({
unwanted: 1,
wanted: 2
}),
helpers: {
// prevent this being mixed in with data
JSON
},
computed: {
props: (state) => {
var result = Object.assign({}, state);
delete result.unwanted;
return result;
}
}
};
</script>
Loading…
Cancel
Save