From 49665232ebe0621aed00fcc5e6f729585cca462f Mon Sep 17 00:00:00 2001 From: Rich-Harris Date: Sat, 10 Dec 2016 15:21:16 -0500 Subject: [PATCH] use builders in place of local.detach and local.teardown --- src/generate/visitors/Component.js | 4 +--- src/generate/visitors/Element.js | 4 +--- src/generate/visitors/attributes/addComponentAttributes.js | 2 +- src/generate/visitors/attributes/addElementAttributes.js | 6 +++--- src/generate/visitors/attributes/binding/index.js | 2 +- 5 files changed, 7 insertions(+), 11 deletions(-) diff --git a/src/generate/visitors/Component.js b/src/generate/visitors/Component.js index 274ea2a583..dda336aaab 100644 --- a/src/generate/visitors/Component.js +++ b/src/generate/visitors/Component.js @@ -110,13 +110,11 @@ export default { ` ); } - local.teardown.push( `${name}.teardown( ${isToplevel ? 'detach' : 'false'} );` ); + generator.current.builders.teardown.addLine( `${name}.teardown( ${isToplevel ? 'detach' : 'false'} );` ); generator.current.builders.init.addBlock( local.init.join( '\n' ) ); if ( local.update.length ) generator.current.builders.update.addBlock( local.update.join( '\n' ) ); if ( local.mount.length ) generator.current.builders.mount.addBlock( local.mount.join( '\n' ) ); - if ( local.detach.length ) generator.current.builders.detach.addBlock( local.detach.join( '\n' ) ); - generator.current.builders.teardown.addBlock( local.teardown.join( '\n' ) ); generator.push({ namespace: local.namespace, diff --git a/src/generate/visitors/Element.js b/src/generate/visitors/Element.js index 4154c810a7..e00029c57a 100644 --- a/src/generate/visitors/Element.js +++ b/src/generate/visitors/Element.js @@ -69,7 +69,7 @@ export default { local.init.unshift( render ); if ( isToplevel ) { - local.detach.push( `${name}.parentNode.removeChild( ${name} );` ); + generator.current.builders.detach.addLine( `${name}.parentNode.removeChild( ${name} );` ); } // special case – bound