From 4682ad43d26b4c835a82e220852a42076302606e Mon Sep 17 00:00:00 2001
From: Tan Li Hau <tanhauhau@users.noreply.github.com>
Date: Tue, 12 Apr 2022 16:48:09 +0800
Subject: [PATCH] each animate allow having comment siblings (#7435)

Co-authored-by: GHOST <ghostdevbusiness@gmail.com>

Co-authored-by: GHOST <ghostdevbusiness@gmail.com>
---
 src/compiler/compile/nodes/EachBlock.ts                  | 5 ++++-
 .../samples/animation-comment-siblings/errors.json       | 1 +
 .../samples/animation-comment-siblings/input.svelte      | 9 +++++++++
 3 files changed, 14 insertions(+), 1 deletion(-)
 create mode 100644 test/validator/samples/animation-comment-siblings/errors.json
 create mode 100644 test/validator/samples/animation-comment-siblings/input.svelte

diff --git a/src/compiler/compile/nodes/EachBlock.ts b/src/compiler/compile/nodes/EachBlock.ts
index bb78845dd9..bea6fb7910 100644
--- a/src/compiler/compile/nodes/EachBlock.ts
+++ b/src/compiler/compile/nodes/EachBlock.ts
@@ -63,7 +63,7 @@ export default class EachBlock extends AbstractBlock {
 		([this.const_tags, this.children] = get_const_tags(info.children, component, this, this));
 
 		if (this.has_animation) {
-			this.children = this.children.filter(child => !isEmptyNode(child));
+			this.children = this.children.filter(child => !isEmptyNode(child) && !isCommentNode(child));
 
 			if (this.children.length !== 1) {
 				const child = this.children.find(child => !!(child as Element).animation);
@@ -83,3 +83,6 @@ export default class EachBlock extends AbstractBlock {
 function isEmptyNode(node: INode) {
 	return node.type === 'Text' && node.data.trim() === '';
 }
+function isCommentNode(node: INode) {
+	return node.type === 'Comment';
+}
diff --git a/test/validator/samples/animation-comment-siblings/errors.json b/test/validator/samples/animation-comment-siblings/errors.json
new file mode 100644
index 0000000000..fe51488c70
--- /dev/null
+++ b/test/validator/samples/animation-comment-siblings/errors.json
@@ -0,0 +1 @@
+[]
diff --git a/test/validator/samples/animation-comment-siblings/input.svelte b/test/validator/samples/animation-comment-siblings/input.svelte
new file mode 100644
index 0000000000..1c8170950b
--- /dev/null
+++ b/test/validator/samples/animation-comment-siblings/input.svelte
@@ -0,0 +1,9 @@
+<script>
+	export let things;
+	function foo() {}
+</script>
+
+{#each things as thing (thing)}
+	<!-- some comment -->
+	<div animate:foo></div>
+{/each}
\ No newline at end of file