From 454ff8d84e009b0d6c822147ff3d075ec5a5277b Mon Sep 17 00:00:00 2001
From: Richard Harris <richard.a.harris@gmail.com>
Date: Sat, 29 Dec 2018 13:57:39 -0500
Subject: [PATCH] rewrite props after instrumentation - fixes #1931

---
 src/compile/Component.ts                               | 3 +--
 src/compile/render-dom/index.ts                        | 2 ++
 src/compile/render-ssr/index.ts                        | 1 +
 test/runtime/samples/prop-without-semicolon/_config.js | 3 +++
 test/runtime/samples/prop-without-semicolon/main.html  | 5 +++++
 5 files changed, 12 insertions(+), 2 deletions(-)
 create mode 100644 test/runtime/samples/prop-without-semicolon/_config.js
 create mode 100644 test/runtime/samples/prop-without-semicolon/main.html

diff --git a/src/compile/Component.ts b/src/compile/Component.ts
index 647068fdf1..a36a8e3e96 100644
--- a/src/compile/Component.ts
+++ b/src/compile/Component.ts
@@ -537,7 +537,6 @@ export default class Component {
 		});
 
 		this.extract_imports_and_exports(script.content, this.imports, this.props);
-		this.rewrite_props();
 		this.hoist_instance_declarations();
 		this.extract_reactive_declarations();
 		this.javascript = this.extract_javascript(script);
@@ -673,7 +672,7 @@ export default class Component {
 			});
 
 			if (combining) {
-				code.prependRight(c, ' } = $$props');
+				code.appendLeft(c, ' } = $$props');
 			}
 		});
 	}
diff --git a/src/compile/render-dom/index.ts b/src/compile/render-dom/index.ts
index f2e47532c9..5951135e35 100644
--- a/src/compile/render-dom/index.ts
+++ b/src/compile/render-dom/index.ts
@@ -228,6 +228,8 @@ export default function dom(
 		if (pending_assignments.size > 0) {
 			throw new Error(`TODO this should not happen!`);
 		}
+
+		component.rewrite_props();
 	}
 
 	const args = ['$$self'];
diff --git a/src/compile/render-ssr/index.ts b/src/compile/render-ssr/index.ts
index 51353d82f0..8d4b496eb6 100644
--- a/src/compile/render-ssr/index.ts
+++ b/src/compile/render-ssr/index.ts
@@ -25,6 +25,7 @@ export default function ssr(
 	let user_code;
 
 	if (component.javascript) {
+		component.rewrite_props();
 		user_code = component.javascript;
 	} else if (component.ast.js.length === 0 && component.props.length > 0) {
 		const props = component.props.map(prop => {
diff --git a/test/runtime/samples/prop-without-semicolon/_config.js b/test/runtime/samples/prop-without-semicolon/_config.js
new file mode 100644
index 0000000000..328d6cc2eb
--- /dev/null
+++ b/test/runtime/samples/prop-without-semicolon/_config.js
@@ -0,0 +1,3 @@
+export default {
+	html: `<h1>Hello world!</h1>`
+};
\ No newline at end of file
diff --git a/test/runtime/samples/prop-without-semicolon/main.html b/test/runtime/samples/prop-without-semicolon/main.html
new file mode 100644
index 0000000000..49a34d15ec
--- /dev/null
+++ b/test/runtime/samples/prop-without-semicolon/main.html
@@ -0,0 +1,5 @@
+<h1>Hello {name}!</h1>
+
+<script>
+	export let name='world'
+</script>
\ No newline at end of file