From 3ed4dc68eea2c6c97201a655cdfa7edbbff4642d Mon Sep 17 00:00:00 2001 From: Taylor Zane Glaeser Date: Tue, 4 Apr 2017 22:41:49 -0500 Subject: [PATCH] Fixes #452. Fixed an issue that caused setting `computed` to an empty object to prevent the component from compiling. --- src/generators/dom/index.js | 2 +- test/generator/samples/computed-empty/_config.js | 8 ++++++++ test/generator/samples/computed-empty/main.html | 14 ++++++++++++++ 3 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 test/generator/samples/computed-empty/_config.js create mode 100644 test/generator/samples/computed-empty/main.html diff --git a/src/generators/dom/index.js b/src/generators/dom/index.js index 4f829776fd..ee08ab4394 100644 --- a/src/generators/dom/index.js +++ b/src/generators/dom/index.js @@ -302,7 +302,7 @@ export default function dom ( parsed, source, options ) { constructorBlock.addBlock( generator.builders.metaBindings ); } - if ( templateProperties.computed ) { + if ( computations.length ) { constructorBlock.addLine( `${generator.alias( 'recompute' )}( this._state, this._state, {}, true );` ); diff --git a/test/generator/samples/computed-empty/_config.js b/test/generator/samples/computed-empty/_config.js new file mode 100644 index 0000000000..226be4cffe --- /dev/null +++ b/test/generator/samples/computed-empty/_config.js @@ -0,0 +1,8 @@ +export default { + html: '
empty
', + test ( assert, component, target ) { + assert.equal( component.get( 'created' ), true ); + assert.equal( target.innerHTML, '
empty
' ); + component.destroy(); + } +}; diff --git a/test/generator/samples/computed-empty/main.html b/test/generator/samples/computed-empty/main.html new file mode 100644 index 0000000000..9dd0e10923 --- /dev/null +++ b/test/generator/samples/computed-empty/main.html @@ -0,0 +1,14 @@ +
empty
+