mirror of https://github.com/sveltejs/svelte
chore: provide proper public type for `parseCss` result (#17654)
Currently, the [newly introduced `parseCss` from `svelte/compiler`](https://github.com/sveltejs/svelte/pull/17496) returns `Omit<AST.CSS.StyleSheet, 'attributes' | 'content'>`. If you try to work with this in external tooling, everywhere where you pass around the result of this method, you need to use that type as well, which is quite cumbersome. (I'm trying to integrate this into `sv` to get rid of a workaround) This creates a new type in the CSS AST to differentiate between one stylesheet only having the roles, and one beeing the full one that is used in `parse` itself. Im 100% open on the name of the new type or any better ideas. ### Before submitting the PR, please make sure you do the following - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>pull/17668/head
parent
b0ca0b84de
commit
3c6bb6faba
@ -0,0 +1,5 @@
|
||||
---
|
||||
'svelte': patch
|
||||
---
|
||||
|
||||
chore: provide proper public type for `parseCss` result
|
||||
Loading…
Reference in new issue