From 39275684e5f19c86ea976af4b2235e6b6588c27d Mon Sep 17 00:00:00 2001 From: Paolo Ricciuti Date: Tue, 3 Dec 2024 19:49:32 +0100 Subject: [PATCH] fix: don't throw with nullish actions (#13559) Co-authored-by: Oscar Dominguez --- .changeset/afraid-worms-clean.md | 5 +++++ .../phases/3-transform/client/visitors/UseDirective.js | 5 ++++- .../tests/runtime-runes/samples/nullish-actions/_config.js | 5 +++++ .../runtime-runes/samples/nullish-actions/main.svelte | 7 +++++++ 4 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 .changeset/afraid-worms-clean.md create mode 100644 packages/svelte/tests/runtime-runes/samples/nullish-actions/_config.js create mode 100644 packages/svelte/tests/runtime-runes/samples/nullish-actions/main.svelte diff --git a/.changeset/afraid-worms-clean.md b/.changeset/afraid-worms-clean.md new file mode 100644 index 0000000000..800177b95b --- /dev/null +++ b/.changeset/afraid-worms-clean.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: don't throw with nullish actions diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/UseDirective.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/UseDirective.js index f6d918ce45..be9eb2d516 100644 --- a/packages/svelte/src/compiler/phases/3-transform/client/visitors/UseDirective.js +++ b/packages/svelte/src/compiler/phases/3-transform/client/visitors/UseDirective.js @@ -20,7 +20,10 @@ export function UseDirective(node, context) { context.state.node, b.arrow( params, - b.call(/** @type {Expression} */ (context.visit(parse_directive_name(node.name))), ...params) + b.maybe_call( + /** @type {Expression} */ (context.visit(parse_directive_name(node.name))), + ...params + ) ) ]; diff --git a/packages/svelte/tests/runtime-runes/samples/nullish-actions/_config.js b/packages/svelte/tests/runtime-runes/samples/nullish-actions/_config.js new file mode 100644 index 0000000000..5d96dc96a4 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/nullish-actions/_config.js @@ -0,0 +1,5 @@ +import { test } from '../../test'; + +export default test({ + html: '
' +}); diff --git a/packages/svelte/tests/runtime-runes/samples/nullish-actions/main.svelte b/packages/svelte/tests/runtime-runes/samples/nullish-actions/main.svelte new file mode 100644 index 0000000000..2cbeb6722d --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/nullish-actions/main.svelte @@ -0,0 +1,7 @@ + + +
+
\ No newline at end of file