Merge pull request #135 from sveltejs/uniq-elem-attrs

Make sure parser only allows unique attribute names

compiler/parse/state/tag.js

@@ -74,9 +74,10 @@ export default function tag ( parser ) {
 	}
 
 	const attributes = [];
+	const uniqueNames = new Map();
 
 	let attribute;
-	while ( attribute = readAttribute( parser ) ) {
+	while ( attribute = readAttribute( parser, uniqueNames ) ) {
 		attributes.push( attribute );
 		parser.allowWhitespace();
 	}
@@ -133,11 +134,16 @@ function readTagName ( parser ) {
 	return name;
 }
 
-function readAttribute ( parser ) {
+function readAttribute ( parser, uniqueNames ) {
 	const start = parser.index;
 
 	const name = parser.readUntil( /(\s|=|\/|>)/ );
 	if ( !name ) return null;
+	if ( uniqueNames.has(name) ) {
+		parser.error( 'Attributes need to be unique', start );
+	}
+
+	uniqueNames.set(name, true);
 
 	parser.allowWhitespace();
 

test/parser/attribute-unique-error/error.json

@@ -0,0 +1,8 @@
+{
+	"message": "Attributes need to be unique",
+	"loc": {
+		"line": 1,
+		"column": 17
+	},
+	"pos": 17
+}

test/parser/attribute-unique-error/input.html

@@ -0,0 +1 @@
+<div class='foo' class='bar'></div>