From 34bb8119b737731f8640ccd6f342e2c9b868244c Mon Sep 17 00:00:00 2001 From: Tan Li Hau Date: Sun, 24 Nov 2019 23:37:21 +0800 Subject: [PATCH] no missing prop warning for non-writable props --- src/compiler/compile/render_dom/index.ts | 2 +- .../samples/dev-warning-missing-data-function/_config.js | 7 +++++++ .../samples/dev-warning-missing-data-function/main.svelte | 7 +++++++ 3 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 test/runtime/samples/dev-warning-missing-data-function/_config.js create mode 100644 test/runtime/samples/dev-warning-missing-data-function/main.svelte diff --git a/src/compiler/compile/render_dom/index.ts b/src/compiler/compile/render_dom/index.ts index 559b99f85a..cc1e05f82b 100644 --- a/src/compiler/compile/render_dom/index.ts +++ b/src/compiler/compile/render_dom/index.ts @@ -153,7 +153,7 @@ export default function dom( if (component.compile_options.dev) { // checking that expected ones were passed - const expected = props.filter(prop => !prop.initialised); + const expected = props.filter(prop => prop.writable && !prop.initialised); if (expected.length) { dev_props_check = b` diff --git a/test/runtime/samples/dev-warning-missing-data-function/_config.js b/test/runtime/samples/dev-warning-missing-data-function/_config.js new file mode 100644 index 0000000000..62ad08624d --- /dev/null +++ b/test/runtime/samples/dev-warning-missing-data-function/_config.js @@ -0,0 +1,7 @@ +export default { + compileOptions: { + dev: true + }, + + warnings: [] +}; diff --git a/test/runtime/samples/dev-warning-missing-data-function/main.svelte b/test/runtime/samples/dev-warning-missing-data-function/main.svelte new file mode 100644 index 0000000000..c60113964a --- /dev/null +++ b/test/runtime/samples/dev-warning-missing-data-function/main.svelte @@ -0,0 +1,7 @@ + + +

+ {foo()} +