From 33a159cd61bb80abe81f2c6bfb698508fd891959 Mon Sep 17 00:00:00 2001 From: Paolo Ricciuti Date: Sat, 17 Aug 2024 14:32:26 +0200 Subject: [PATCH] fix: allow store as initial value for props in ssr (#12885) --- .changeset/smart-poets-care.md | 5 +++++ .../3-transform/server/visitors/VariableDeclaration.js | 4 +++- .../samples/store-init-props/_config.js | 3 +++ .../samples/store-init-props/_expected.html | 1 + .../samples/store-init-props/main.svelte | 7 +++++++ 5 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 .changeset/smart-poets-care.md create mode 100644 packages/svelte/tests/server-side-rendering/samples/store-init-props/_config.js create mode 100644 packages/svelte/tests/server-side-rendering/samples/store-init-props/_expected.html create mode 100644 packages/svelte/tests/server-side-rendering/samples/store-init-props/main.svelte diff --git a/.changeset/smart-poets-care.md b/.changeset/smart-poets-care.md new file mode 100644 index 0000000000..bb0dc071e3 --- /dev/null +++ b/.changeset/smart-poets-care.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: allow store as initial value for props in ssr diff --git a/packages/svelte/src/compiler/phases/3-transform/server/visitors/VariableDeclaration.js b/packages/svelte/src/compiler/phases/3-transform/server/visitors/VariableDeclaration.js index bd8a8f435e..5e0b34a557 100644 --- a/packages/svelte/src/compiler/phases/3-transform/server/visitors/VariableDeclaration.js +++ b/packages/svelte/src/compiler/phases/3-transform/server/visitors/VariableDeclaration.js @@ -39,7 +39,9 @@ export function VariableDeclaration(node, context) { } } }); - declarations.push(b.declarator(id, b.id('$$props'))); + declarations.push( + b.declarator(/** @type {Pattern} */ (context.visit(id)), b.id('$$props')) + ); continue; } diff --git a/packages/svelte/tests/server-side-rendering/samples/store-init-props/_config.js b/packages/svelte/tests/server-side-rendering/samples/store-init-props/_config.js new file mode 100644 index 0000000000..f47bee71df --- /dev/null +++ b/packages/svelte/tests/server-side-rendering/samples/store-init-props/_config.js @@ -0,0 +1,3 @@ +import { test } from '../../test'; + +export default test({}); diff --git a/packages/svelte/tests/server-side-rendering/samples/store-init-props/_expected.html b/packages/svelte/tests/server-side-rendering/samples/store-init-props/_expected.html new file mode 100644 index 0000000000..56a6051ca2 --- /dev/null +++ b/packages/svelte/tests/server-side-rendering/samples/store-init-props/_expected.html @@ -0,0 +1 @@ +1 \ No newline at end of file diff --git a/packages/svelte/tests/server-side-rendering/samples/store-init-props/main.svelte b/packages/svelte/tests/server-side-rendering/samples/store-init-props/main.svelte new file mode 100644 index 0000000000..762a519e03 --- /dev/null +++ b/packages/svelte/tests/server-side-rendering/samples/store-init-props/main.svelte @@ -0,0 +1,7 @@ + + +{value}