From 32e5977c6f92e3f1cb28a39dcf1aaa394eda2396 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Tue, 19 Mar 2024 17:15:47 -0400 Subject: [PATCH] simplify --- .../svelte/src/internal/client/dom/blocks/css-props.js | 4 ++-- .../src/internal/client/dom/blocks/svelte-element.js | 9 +++++---- packages/svelte/src/internal/client/dom/reconciler.js | 2 +- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/packages/svelte/src/internal/client/dom/blocks/css-props.js b/packages/svelte/src/internal/client/dom/blocks/css-props.js index aee98617d7..5bfb41dd91 100644 --- a/packages/svelte/src/internal/client/dom/blocks/css-props.js +++ b/packages/svelte/src/internal/client/dom/blocks/css-props.js @@ -2,7 +2,7 @@ import { namespace_svg } from '../../../../constants.js'; import { current_hydration_fragment, hydrate_block_anchor, hydrating } from '../hydration.js'; import { empty } from '../operations.js'; import { render_effect } from '../../reactivity/effects.js'; -import { insert, remove } from '../reconciler.js'; +import { remove } from '../reconciler.js'; /** * @param {Element | Text | Comment} anchor @@ -33,7 +33,7 @@ export function css_props(anchor, is_html, props, component) { tag = document.createElementNS(namespace_svg, 'g'); } - insert(tag, null, anchor); + anchor.before(tag); component_anchor = empty(); tag.appendChild(component_anchor); } diff --git a/packages/svelte/src/internal/client/dom/blocks/svelte-element.js b/packages/svelte/src/internal/client/dom/blocks/svelte-element.js index cd82cd3967..8818274556 100644 --- a/packages/svelte/src/internal/client/dom/blocks/svelte-element.js +++ b/packages/svelte/src/internal/client/dom/blocks/svelte-element.js @@ -7,10 +7,10 @@ import { render_effect, resume_effect } from '../../reactivity/effects.js'; -import { insert, remove } from '../reconciler.js'; -import { current_block, execute_effect } from '../../runtime.js'; +import { remove } from '../reconciler.js'; +import { current_block } from '../../runtime.js'; import { is_array } from '../../utils.js'; -import { run_transitions, set_run_transitions } from '../../render.js'; +import { set_run_transitions } from '../../render.js'; /** * @param {import('#client').Block} block @@ -119,7 +119,8 @@ export function element(anchor_node, tag_fn, is_svg, render_fn) { render_fn(element, anchor); } - insert(element, null, anchor_node); + anchor_node.before(element); + if (prev_element) { swap_block_dom(block.p, prev_element, element); prev_element.remove(); diff --git a/packages/svelte/src/internal/client/dom/reconciler.js b/packages/svelte/src/internal/client/dom/reconciler.js index becdac20d9..fd4ed5ecc2 100644 --- a/packages/svelte/src/internal/client/dom/reconciler.js +++ b/packages/svelte/src/internal/client/dom/reconciler.js @@ -47,7 +47,7 @@ export function insert(current, parent_element, sibling) { } } return current[0]; - } else if (current !== null) { + } else { if (sibling === null) { append_child(/** @type {Element} */ (parent_element), /** @type {Node} */ (current)); } else {