From 2f68131e9a780f139d6bdcf1b27854d850542671 Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Tue, 1 Jul 2025 23:10:16 +0200
Subject: [PATCH] fix: revert props legacy mode regression (#16279)

#16270 removed a condition which seemed to keep passing the corresponding test, but it actually introduced a regression since the PROPS_IS_UPDATED is always set when accessors should be created, which is the case by default in legacy mode tests. Setting accessors to false in the test reveals the regression, so this reverts that part of the refactoring
---
 packages/svelte/src/internal/client/reactivity/props.js   | 8 +++++---
 .../runtime-legacy/samples/prop-no-change/_config.js      | 1 +
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/packages/svelte/src/internal/client/reactivity/props.js b/packages/svelte/src/internal/client/reactivity/props.js
index f51291b1cc..3501bcd3c7 100644
--- a/packages/svelte/src/internal/client/reactivity/props.js
+++ b/packages/svelte/src/internal/client/reactivity/props.js
@@ -336,7 +336,7 @@ export function prop(props, key, flags, fallback) {
 	}
 
 	// prop is never written to — we only need a getter
-	if ((flags & PROPS_IS_UPDATED) === 0) {
+	if (runes && (flags & PROPS_IS_UPDATED) === 0) {
 		return getter;
 	}
 
@@ -362,8 +362,10 @@ export function prop(props, key, flags, fallback) {
 		};
 	}
 
-	// prop is written to, but there's no binding, which means we
-	// create a derived that we can write to locally
+	// Either prop is written to, but there's no binding, which means we
+	// create a derived that we can write to locally.
+	// Or we are in legacy mode where we always create a derived to replicate that
+	// Svelte 4 did not trigger updates when a primitive value was updated to the same value.
 	var d = ((flags & PROPS_IS_IMMUTABLE) !== 0 ? derived : derived_safe_equal)(getter);
 
 	// Capture the initial value if it's bindable
diff --git a/packages/svelte/tests/runtime-legacy/samples/prop-no-change/_config.js b/packages/svelte/tests/runtime-legacy/samples/prop-no-change/_config.js
index 905c2a6226..84658336e2 100644
--- a/packages/svelte/tests/runtime-legacy/samples/prop-no-change/_config.js
+++ b/packages/svelte/tests/runtime-legacy/samples/prop-no-change/_config.js
@@ -2,6 +2,7 @@ import { flushSync } from 'svelte';
 import { test } from '../../test';
 
 export default test({
+	accessors: false,
 	test({ assert, logs, target }) {
 		assert.deepEqual(logs, ['primitive', 'object']);
 		target.querySelector('button')?.click();