From c314d1bb333759031e6d98763dde8159a19219f9 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Tue, 9 Jul 2024 04:28:52 -0700 Subject: [PATCH] chore: allow `` effects to be pruned (#12356) assign_nodes inside the branch sets the nodes property, and there's a dependency on the `this` value, which both (on its own) already prevent the effect from being pruned. --- .../src/internal/client/dom/blocks/svelte-element.js | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/packages/svelte/src/internal/client/dom/blocks/svelte-element.js b/packages/svelte/src/internal/client/dom/blocks/svelte-element.js index f966ac7fa6..428f7a5ca4 100644 --- a/packages/svelte/src/internal/client/dom/blocks/svelte-element.js +++ b/packages/svelte/src/internal/client/dom/blocks/svelte-element.js @@ -10,10 +10,9 @@ import { } from '../../reactivity/effects.js'; import { set_should_intro } from '../../render.js'; import { current_each_item, set_current_each_item } from './each.js'; -import { current_component_context, current_effect } from '../../runtime.js'; +import { current_component_context } from '../../runtime.js'; import { DEV } from 'esm-env'; import { assign_nodes } from '../template.js'; -import { noop } from '../../../shared/utils.js'; import { EFFECT_TRANSPARENT } from '../../constants.js'; /** @@ -121,9 +120,6 @@ export function element(node, get_tag, is_svg, render_fn, get_namespace, locatio } anchor.before(element); - - // See below - return noop; }); } @@ -132,9 +128,5 @@ export function element(node, get_tag, is_svg, render_fn, get_namespace, locatio set_should_intro(true); set_current_each_item(previous_each_item); - - // Inert effects are proactively detached from the effect tree. Returning a noop - // teardown function is an easy way to ensure that this is not discarded - return noop; }, EFFECT_TRANSPARENT); }