Merge pull request #1967 from sveltejs/gh-1939

set parent correctly for children of await blocks

src/compile/render-dom/wrappers/AwaitBlock.ts

@@ -80,7 +80,7 @@ export default class AwaitBlockWrapper extends Wrapper {
 				status,
 				renderer,
 				block,
-				parent,
+				this,
 				child,
 				stripWhitespace,
 				nextSibling

test/runtime/samples/await-containing-if/_config.js

@@ -0,0 +1,35 @@
+let fulfil;
+
+let thePromise = new Promise(f => {
+	fulfil = f;
+});
+
+export default {
+	props: {
+		thePromise,
+		show: true
+	},
+
+	html: `
+		<div><p>loading...</p></div>
+	`,
+
+	test({ assert, component, target }) {
+		fulfil(42);
+
+		return thePromise
+			.then(() => {
+				assert.htmlEqual(target.innerHTML, `
+					<div><p>the value is 42</p></div>
+				`);
+
+				component.show = false;
+				assert.htmlEqual(target.innerHTML, `<div></div>`);
+
+				component.show = true;
+				assert.htmlEqual(target.innerHTML, `
+					<div><p>the value is 42</p></div>
+				`);
+			});
+	}
+};

test/runtime/samples/await-containing-if/main.html

@@ -0,0 +1,11 @@
+<div>
+	{#await thePromise}
+		<p>loading...</p>
+	{:then theValue}
+		{#if show}
+			<p>the value is {theValue}</p>
+		{/if}
+	{:catch theError}
+		<p>oh no! {theError.message}</p>
+	{/await}
+</div>